diff options
| author | scheibelp <scheibel1@llnl.gov> | 2018-06-06 18:28:25 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-06-06 18:28:25 -0700 |
| commit | c97d058ce3ff0ffc4b1de063daca78cecff23d62 (patch) | |
| tree | f6cd362e93ecda8c01584c06a5ee1bd1f2e5fb48 /conftest.py | |
| parent | 728351faaef3b3db29d9bdfde55d2ee07a683c3b (diff) | |
| download | spack-c97d058ce3ff0ffc4b1de063daca78cecff23d62.tar.gz spack-c97d058ce3ff0ffc4b1de063daca78cecff23d62.tar.bz2 spack-c97d058ce3ff0ffc4b1de063daca78cecff23d62.tar.xz spack-c97d058ce3ff0ffc4b1de063daca78cecff23d62.zip | |
Fix bug where patches specified by dependents were not applied (#8272)
Fixes #7885
#7193 added the patches_to_apply function to collect patches which are then
applied in Package.do_patch. However this only collects patches that are
associated with the Package object and does not include Spec-related patches
(which are applied by dependents, added in #5476).
Spec.patches already collects patches from the package as well as those applied
by dependents, so the Package.patches_to_apply function isn't necessary. All
uses of Package.patches_to_apply are replaced with Package.spec.patches.
This also updates Package.content_hash to require the associated spec to be
concrete: Spec.patches is only set after concretization. Before this PR, it was
possible for Package.content_hash to be valid before concretizing the associated
Spec if all patches were associated with the Package (vs. being applied by
dependents). This behavior was unreliable though so the change is unlikely to
be disruptive.
Diffstat (limited to 'conftest.py')
0 files changed, 0 insertions, 0 deletions