diff options
| author | Massimiliano Culpo <massimiliano.culpo@gmail.com> | 2021-05-08 09:11:27 +0200 |
|---|---|---|
| committer | Todd Gamblin <tgamblin@llnl.gov> | 2021-05-08 06:14:44 -0700 |
| commit | 00a1418d1076f4ea77bbfa78098361cc7c292655 (patch) | |
| tree | b890a4368060dfe413e8b396938981e0d8dbe93b /lib | |
| parent | daebf5caf89969e99331896f4d285bb7bfa5e198 (diff) | |
| download | spack-00a1418d1076f4ea77bbfa78098361cc7c292655.tar.gz spack-00a1418d1076f4ea77bbfa78098361cc7c292655.tar.bz2 spack-00a1418d1076f4ea77bbfa78098361cc7c292655.tar.xz spack-00a1418d1076f4ea77bbfa78098361cc7c292655.zip | |
clingo: don't skip tests that deal with file permissions
When we first merged the ASP-based solver, unit-tests
were run in a Docker container with root permissions
and that was preventing a few tests to succeed.
Since some time though, clingo is tested as a regular
user within Github Actions VMs, so we should start to
run checks again.
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/spack/spack/test/cmd/buildcache.py | 4 | ||||
| -rw-r--r-- | lib/spack/spack/test/database.py | 8 | ||||
| -rw-r--r-- | lib/spack/spack/test/llnl/util/lock.py | 4 |
3 files changed, 0 insertions, 16 deletions
diff --git a/lib/spack/spack/test/cmd/buildcache.py b/lib/spack/spack/test/cmd/buildcache.py index 27ef4fca8f..5c056fb33b 100644 --- a/lib/spack/spack/test/cmd/buildcache.py +++ b/lib/spack/spack/test/cmd/buildcache.py @@ -125,10 +125,6 @@ def test_buildcache_create_fails_on_noargs(tmpdir): buildcache('create', '-d', str(tmpdir), '--unsigned') -@pytest.mark.skipif( - os.environ.get('SPACK_TEST_SOLVER') == 'clingo', - reason='Test for Clingo are run in a container with root permissions' -) def test_buildcache_create_fail_on_perm_denied( install_mockery, mock_fetch, monkeypatch, tmpdir): """Ensure that buildcache create fails on permission denied error.""" diff --git a/lib/spack/spack/test/database.py b/lib/spack/spack/test/database.py index 8d1a204ba9..cb9fbada2a 100644 --- a/lib/spack/spack/test/database.py +++ b/lib/spack/spack/test/database.py @@ -638,10 +638,6 @@ def test_090_non_root_ref_counts(mutable_database): assert mpich_rec.ref_count == 0 -@pytest.mark.skipif( - os.environ.get('SPACK_TEST_SOLVER') == 'clingo', - reason='Test for Clingo are run in a container with root permissions' -) def test_100_no_write_with_exception_on_remove(database): def fail_while_writing(): with database.write_transaction(): @@ -659,10 +655,6 @@ def test_100_no_write_with_exception_on_remove(database): assert len(database.query('mpileaks ^zmpi', installed=any)) == 1 -@pytest.mark.skipif( - os.environ.get('SPACK_TEST_SOLVER') == 'clingo', - reason='Test for Clingo are run in a container with root permissions' -) def test_110_no_write_with_exception_on_install(database): def fail_while_writing(): with database.write_transaction(): diff --git a/lib/spack/spack/test/llnl/util/lock.py b/lib/spack/spack/test/llnl/util/lock.py index 4911ac9ae3..928bded6ca 100644 --- a/lib/spack/spack/test/llnl/util/lock.py +++ b/lib/spack/spack/test/llnl/util/lock.py @@ -661,10 +661,6 @@ def test_upgrade_read_to_write(private_lock_path): assert lock._file is None -@pytest.mark.skipif( - os.environ.get('SPACK_TEST_SOLVER') == 'clingo', - reason='Test for Clingo are run in a container with root permissions' -) def test_upgrade_read_to_write_fails_with_readonly_file(private_lock_path): """Test that read-only file can be read-locked but not write-locked.""" # ensure lock file exists the first time |