diff options
author | Harmen Stoppels <harmenstoppels@gmail.com> | 2023-07-09 17:27:38 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-07-09 11:27:38 -0400 |
commit | 374fda10630103e2f900fdd15dbf99db97c88716 (patch) | |
tree | eebb417df00f0d69cbebf824d801262999db4b1e /lib | |
parent | 3c14569b8e5974509d16ec736cb4982f5981db14 (diff) | |
download | spack-374fda10630103e2f900fdd15dbf99db97c88716.tar.gz spack-374fda10630103e2f900fdd15dbf99db97c88716.tar.bz2 spack-374fda10630103e2f900fdd15dbf99db97c88716.tar.xz spack-374fda10630103e2f900fdd15dbf99db97c88716.zip |
Don’t call spec.format in Database._get_matching_spec_key (#38792)
`"%s" % spec` formats the spec with deps included, which produces sometimes KBs
of data and is slow to run in pure Python. It can delay otherwise very short-lived
read/write locks on the database.
Discovered in #38762 where profile output showed about 2 seconds is spent in
`spec.format`, which is significant overhead when using multiprocessing to install
from binary cache in parallel (installation often takes <5s for small packages). With
this change, `spec.format` no longer shows up in profile output.
(This line hasn't changed since Spack v0.9 ;p)
* move format() call to custom NoSuchSpecError exception
* add a comment saying why, so we can eventually change `Spec.__str__`
Diffstat (limited to 'lib')
-rw-r--r-- | lib/spack/spack/database.py | 16 |
1 files changed, 15 insertions, 1 deletions
diff --git a/lib/spack/spack/database.py b/lib/spack/spack/database.py index 4be5b6665f..a8fa85c558 100644 --- a/lib/spack/spack/database.py +++ b/lib/spack/spack/database.py @@ -1216,7 +1216,7 @@ class Database: match = self.query_one(spec, **kwargs) if match: return match.dag_hash() - raise KeyError("No such spec in database! %s" % spec) + raise NoSuchSpecError(spec) return key @_autospec @@ -1672,3 +1672,17 @@ class InvalidDatabaseVersionError(SpackError): @property def database_version_message(self): return f"The expected DB version is '{self.expected}', but '{self.found}' was found." + + +class NoSuchSpecError(KeyError): + """Raised when a spec is not found in the database.""" + + def __init__(self, spec): + self.spec = spec + super().__init__(spec) + + def __str__(self): + # This exception is raised frequently, and almost always + # caught, so ensure we don't pay the cost of Spec.__str__ + # unless the exception is actually printed. + return f"No such spec in database: {self.spec}" |