summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorMatt Belhorn <belhornmp@ornl.gov>2016-10-06 05:41:28 -0400
committerTodd Gamblin <tgamblin@llnl.gov>2016-10-06 02:41:28 -0700
commit6b98e8605654ea4cea064ae7f8c330d99e2c4d3e (patch)
tree99b30325d64991f2cb174c1011c40f6bad400a37 /lib
parent3de3664671409d9045fc6d907a053f547391ddce (diff)
downloadspack-6b98e8605654ea4cea064ae7f8c330d99e2c4d3e.tar.gz
spack-6b98e8605654ea4cea064ae7f8c330d99e2c4d3e.tar.bz2
spack-6b98e8605654ea4cea064ae7f8c330d99e2c4d3e.tar.xz
spack-6b98e8605654ea4cea064ae7f8c330d99e2c4d3e.zip
Fixes bug closing Executable file io-streams (#1890)
Input/output/error streams not directed to None or 'str' were not being closed because `close()` method was being called on the argument value (a string type) instead of the open file descriptor object.
Diffstat (limited to 'lib')
-rw-r--r--lib/spack/spack/util/executable.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/spack/spack/util/executable.py b/lib/spack/spack/util/executable.py
index 5c27b92df5..4fe4bd26ba 100644
--- a/lib/spack/spack/util/executable.py
+++ b/lib/spack/spack/util/executable.py
@@ -185,11 +185,11 @@ class Executable(object):
finally:
if close_ostream:
- output.close()
+ ostream.close()
if close_estream:
- error.close()
+ estream.close()
if close_istream:
- input.close()
+ istream.close()
def __eq__(self, other):
return self.exe == other.exe