diff options
| author | Tom Scogland <scogland1@llnl.gov> | 2022-05-28 09:55:44 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-28 12:55:44 -0400 |
| commit | 18c2f1a57a69224748e091e912851317d8a00eea (patch) | |
| tree | b5e2161e1071f42f06f2f5571fdf076fe1ca9856 /share | |
| parent | 3054cd0effa91ad48915ac5931604f80f0c9f4e5 (diff) | |
| download | spack-18c2f1a57a69224748e091e912851317d8a00eea.tar.gz spack-18c2f1a57a69224748e091e912851317d8a00eea.tar.bz2 spack-18c2f1a57a69224748e091e912851317d8a00eea.tar.xz spack-18c2f1a57a69224748e091e912851317d8a00eea.zip | |
refactor: packages import `spack.package` explicitly (#30404)
Explicitly import package utilities in all packages, and corresponding fallout.
This includes:
* rename `spack.package` to `spack.package_base`
* rename `spack.pkgkit` to `spack.package`
* update all packages in builtin, builtin_mock and tutorials to include `from spack.package import *`
* update spack style
* ensure packages include the import
* automatically add the new import and remove any/all imports of `spack` and `spack.pkgkit`
from packages when using `--fix`
* add support for type-checking packages with mypy when SPACK_MYPY_CHECK_PACKAGES
is set in the environment
* fix all type checking errors in packages in spack upstream
* update spack create to include the new imports
* update spack repo to inject the new import, injection persists to allow for a deprecation period
Original message below:
As requested @adamjstewart, update all packages to use pkgkit. I ended up using isort to do this,
so repro is easy:
```console
$ isort -a 'from spack.pkgkit import *' --rm 'spack' ./var/spack/repos/builtin/packages/*/package.py
$ spack style --fix
```
There were several line spacing fixups caused either by space manipulation in isort or by packages
that haven't been touched since we added requirements, but there are no functional changes in here.
* [x] add config to isort to make sure this is maintained going forward
Diffstat (limited to 'share')
| -rw-r--r-- | share/spack/qa/flake8_formatter.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/share/spack/qa/flake8_formatter.py b/share/spack/qa/flake8_formatter.py index 0611d54019..523ee7b4d0 100644 --- a/share/spack/qa/flake8_formatter.py +++ b/share/spack/qa/flake8_formatter.py @@ -16,10 +16,10 @@ from flake8.style_guide import Violation pattern_exemptions = { # exemptions applied only to package.py files. r"package.py$": { - # Allow 'from spack import *' in packages, but no other wildcards + # Allow 'from spack.package import *' in packages, but no other wildcards "F403": [ - r"^from spack import \*$", - r"^from spack.pkgkit import \*$", + r"^from spack.package import \*$", + r"^from spack.package_defs import \*$", ], # Exempt lines with urls and descriptions from overlong line errors. "E501": [ |