diff options
| author | Harmen Stoppels <harmenstoppels@gmail.com> | 2023-04-19 23:17:47 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-19 14:17:47 -0700 |
| commit | d51af675ef345a191aa995b82609e5f6776184a3 (patch) | |
| tree | b41f286020d2fe56abc67502a1c188a97492e515 /var/spack/repos/builder.test | |
| parent | c7508dc21625b80b0fc6a4b835f0a6fdd38480d3 (diff) | |
| download | spack-d51af675ef345a191aa995b82609e5f6776184a3.tar.gz spack-d51af675ef345a191aa995b82609e5f6776184a3.tar.bz2 spack-d51af675ef345a191aa995b82609e5f6776184a3.tar.xz spack-d51af675ef345a191aa995b82609e5f6776184a3.zip | |
make version(...) kwargs explicit (#36998)
- [x] Replace `version(ver, checksum=None, **kwargs)` signature with
`version(ver, checksum=None, *, sha256=..., ...)` explicitly listing all arguments.
- [x] Fix various issues in packages:
- `tags` instead of `tag`
- `default` instead of `preferred`
- `sha26` instead of `sha256`
- etc
Also, use `sha256=...` consistently.
Note: setting `sha256` currently doesn't validate the checksum length, so you could do
`sha256="a"*32` and it would get checked as `md5`... but that's something for another PR.
Diffstat (limited to 'var/spack/repos/builder.test')
6 files changed, 12 insertions, 12 deletions
diff --git a/var/spack/repos/builder.test/packages/callbacks/package.py b/var/spack/repos/builder.test/packages/callbacks/package.py index 1aee7bd87d..1e5fa97ef2 100644 --- a/var/spack/repos/builder.test/packages/callbacks/package.py +++ b/var/spack/repos/builder.test/packages/callbacks/package.py @@ -14,8 +14,8 @@ class Callbacks(Package): homepage = "http://www.example.com" url = "http://www.example.com/a-1.0.tar.gz" - version("2.0", "abcdef0123456789abcdef0123456789") - version("1.0", "0123456789abcdef0123456789abcdef") + version("2.0", md5="abcdef0123456789abcdef0123456789") + version("1.0", md5="0123456789abcdef0123456789abcdef") class GenericBuilder(spack.build_systems.generic.GenericBuilder): diff --git a/var/spack/repos/builder.test/packages/custom-phases/package.py b/var/spack/repos/builder.test/packages/custom-phases/package.py index aff6d819f3..cc63250a04 100644 --- a/var/spack/repos/builder.test/packages/custom-phases/package.py +++ b/var/spack/repos/builder.test/packages/custom-phases/package.py @@ -14,8 +14,8 @@ class CustomPhases(Package): homepage = "http://www.example.com" url = "http://www.example.com/a-1.0.tar.gz" - version("2.0", "abcdef0123456789abcdef0123456789") - version("1.0", "0123456789abcdef0123456789abcdef") + version("2.0", md5="abcdef0123456789abcdef0123456789") + version("1.0", md5="0123456789abcdef0123456789abcdef") class GenericBuilder(spack.build_systems.generic.GenericBuilder): diff --git a/var/spack/repos/builder.test/packages/gnuconfig/package.py b/var/spack/repos/builder.test/packages/gnuconfig/package.py index 0cd1261626..ecf32e2137 100644 --- a/var/spack/repos/builder.test/packages/gnuconfig/package.py +++ b/var/spack/repos/builder.test/packages/gnuconfig/package.py @@ -11,5 +11,5 @@ class Gnuconfig(Package): homepage = "http://www.example.com" url = "http://www.example.com/a-1.0.tar.gz" - version("2.0", "abcdef0123456789abcdef0123456789") - version("1.0", "0123456789abcdef0123456789abcdef") + version("2.0", md5="abcdef0123456789abcdef0123456789") + version("1.0", md5="0123456789abcdef0123456789abcdef") diff --git a/var/spack/repos/builder.test/packages/old-style-autotools/package.py b/var/spack/repos/builder.test/packages/old-style-autotools/package.py index ad1ab92472..41be49b5ba 100644 --- a/var/spack/repos/builder.test/packages/old-style-autotools/package.py +++ b/var/spack/repos/builder.test/packages/old-style-autotools/package.py @@ -15,8 +15,8 @@ class OldStyleAutotools(AutotoolsPackage): homepage = "http://www.example.com" url = "http://www.example.com/a-1.0.tar.gz" - version("2.0", "abcdef0123456789abcdef0123456789") - version("1.0", "0123456789abcdef0123456789abcdef") + version("2.0", md5="abcdef0123456789abcdef0123456789") + version("1.0", md5="0123456789abcdef0123456789abcdef") def configure(self, spec, prefix): pass diff --git a/var/spack/repos/builder.test/packages/old-style-custom-phases/package.py b/var/spack/repos/builder.test/packages/old-style-custom-phases/package.py index fba15767fa..a2f2040d1f 100644 --- a/var/spack/repos/builder.test/packages/old-style-custom-phases/package.py +++ b/var/spack/repos/builder.test/packages/old-style-custom-phases/package.py @@ -15,8 +15,8 @@ class OldStyleCustomPhases(AutotoolsPackage): homepage = "http://www.example.com" url = "http://www.example.com/a-1.0.tar.gz" - version("2.0", "abcdef0123456789abcdef0123456789") - version("1.0", "0123456789abcdef0123456789abcdef") + version("2.0", md5="abcdef0123456789abcdef0123456789") + version("1.0", md5="0123456789abcdef0123456789abcdef") phases = ["configure"] diff --git a/var/spack/repos/builder.test/packages/old-style-derived/package.py b/var/spack/repos/builder.test/packages/old-style-derived/package.py index 34c1d2b87a..159d0d4b13 100644 --- a/var/spack/repos/builder.test/packages/old-style-derived/package.py +++ b/var/spack/repos/builder.test/packages/old-style-derived/package.py @@ -14,8 +14,8 @@ class OldStyleDerived(spack.pkg.builder.test.old_style_autotools.OldStyleAutotoo homepage = "http://www.example.com" url = "http://www.example.com/a-1.0.tar.gz" - version("2.0", "abcdef0123456789abcdef0123456789") - version("1.0", "0123456789abcdef0123456789abcdef") + version("2.0", md5="abcdef0123456789abcdef0123456789") + version("1.0", md5="0123456789abcdef0123456789abcdef") def configure_args(self): return ["--with-bar"] + super(OldStyleDerived, self).configure_args() |