diff options
| author | markus-ferrell <116021216+markus-ferrell@users.noreply.github.com> | 2023-08-14 19:29:12 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-14 23:29:12 +0000 |
| commit | c202a045e69ea2968ddff41008518cc427d8ddac (patch) | |
| tree | 0589c387ec27ba8b6b02cd308463157c6ab89e1c /var/spack/repos/builtin.mock | |
| parent | 843e1e80f02bf89543acbb4bfdc6266413adc212 (diff) | |
| download | spack-c202a045e69ea2968ddff41008518cc427d8ddac.tar.gz spack-c202a045e69ea2968ddff41008518cc427d8ddac.tar.bz2 spack-c202a045e69ea2968ddff41008518cc427d8ddac.tar.xz spack-c202a045e69ea2968ddff41008518cc427d8ddac.zip | |
Windows: executable/path handling (#37762)
Windows executable paths can have spaces in them, which was leading to
errors when constructing Executable objects: the parser was intended
to handle cases where users could provide an executable along with one
or more space-delimited arguments.
* Executable now assumes that it is constructed with a string argument
that represents the path to the executable, but no additional arguments.
* Invocations of Executable.__init__ that depended on this have been
updated (this includes the core, tests, and one instance of builtin
repository package).
* The error handling for failed invocations of Executable.__call__ now
includes a check for whether the executable name/path contains a
space, to help users debug cases where they (now incorrectly)
concatenate the path and the arguments.
Diffstat (limited to 'var/spack/repos/builtin.mock')
| -rw-r--r-- | var/spack/repos/builtin.mock/packages/cmake-client/package.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/var/spack/repos/builtin.mock/packages/cmake-client/package.py b/var/spack/repos/builtin.mock/packages/cmake-client/package.py index 2ce5a98dd1..a0694f2d6d 100644 --- a/var/spack/repos/builtin.mock/packages/cmake-client/package.py +++ b/var/spack/repos/builtin.mock/packages/cmake-client/package.py @@ -109,7 +109,7 @@ class CmakeClient(CMakePackage): print(cmake) print(cmake.exe) check( - cmake.exe[0].startswith(spec["cmake"].prefix.bin), + cmake.path.startswith(spec["cmake"].prefix.bin), "Wrong cmake was in environment: %s" % cmake, ) |