Separate Apple Clang from LLVM Clang (#17110)

* Separate Apple Clang from LLVM Clang

Apple Clang is a compiler of its own. All places
referring to "-apple" suffix have been updated.

* Hack to use a dash in 'apple-clang'

To be able to use autodoc from Sphinx we need
a valid Python name for the module that contains
Apple's Clang code.

* Updated packages to account for the existence of apple-clang

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Added unit test for XCode related functions

Co-authored-by: Gregory Becker <becker33@llnl.gov>
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

1 files changed, 1 insertions, 5 deletions

diff --git a/var/spack/repos/builtin/packages/fftw/package.py b/var/spack/repos/builtin/packages/fftw/package.py
index 961c4cfc66..b644677fd1 100644
--- a/var/spack/repos/builtin/packages/fftw/package.py
+++ b/var/spack/repos/builtin/packages/fftw/package.py
@@ -57,6 +57,7 @@ class Fftw(AutotoolsPackage):
               msg='Long double precision is not supported in FFTW 2')
     conflicts('precision=quad', when='@2.1.5',
               msg='Quad precision is not supported in FFTW 2')
+    conflicts('+openmp', when='%apple-clang', msg="Apple's clang does not support OpenMP")
 
     provides('fftw-api@2', when='@2.1.5')
     provides('fftw-api@3', when='@3:')
@@ -124,11 +125,6 @@ class Fftw(AutotoolsPackage):
 
         # Variants that affect every precision
         if '+openmp' in spec:
-            # Note: Apple's Clang does not support OpenMP.
-            if spec.satisfies('%clang'):
-                ver = str(self.compiler.version)
-                if ver.endswith('-apple'):
-                    raise InstallError("Apple's clang does not support OpenMP")
             options.append('--enable-openmp')
             if spec.satisfies('@:2'):
                 # TODO: libtool strips CFLAGS, so 2.x libxfftw_threads