Add PythonPackage base class

- Add a PythonPackage class with build system support.
  - Support build phases in PythonPackage
  - Add a custom sanity check for PythonPackages
  - Get rid of nolink dependencies in python packages

- Update spack create to use new PythonPackage class

- Port most of Python packages to new PythonPackage class

- Conducted a massive install and activate of Python packages.
  - Fixed bugs introduced by install and activate.

- Update API docs on PythonPackage

1 files changed, 6 insertions, 7 deletions

diff --git a/var/spack/repos/builtin/packages/py-traitlets/package.py b/var/spack/repos/builtin/packages/py-traitlets/package.py
index 2a087dffb9..debd1dca43 100644
--- a/var/spack/repos/builtin/packages/py-traitlets/package.py
+++ b/var/spack/repos/builtin/packages/py-traitlets/package.py
@@ -25,7 +25,7 @@
 from spack import *
 
 
-class PyTraitlets(Package):
+class PyTraitlets(PythonPackage):
     """Traitlets Python config system"""
 
     homepage = "https://pypi.python.org/pypi/traitlets"
@@ -40,12 +40,11 @@ class PyTraitlets(Package):
     version('4.0.0', 'b5b95ea5941fd9619b4704dfd8201568')
     version('4.0',   '14544e25ccf8e920ed1cbf833852481f')
 
-    extends('python')
-
     depends_on('py-setuptools', type='build')
     depends_on('py-decorator', type=('build', 'run'))
-    depends_on('py-ipython-genutils')
-    depends_on('py-enum34', when='^python@:3.3')
+    depends_on('py-ipython-genutils', type=('build', 'run'))
 
-    def install(self, spec, prefix):
-        setup_py('install', '--prefix={0}'.format(prefix))
+    # This dependency breaks concretization
+    # See https://github.com/LLNL/spack/issues/2793
+    # depends_on('py-enum34', when='^python@:3.3', type=('build', 'run'))
+    depends_on('py-enum34', type=('build', 'run'))