diff options
| author | Adam J. Stewart <ajstewart426@gmail.com> | 2022-03-23 02:50:00 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-23 08:50:00 +0100 |
| commit | 5df10c04cd4ffe223f346b8bd9e5cd80dedbfe34 (patch) | |
| tree | b8ef0badda8ff94202d35c5bebd80e3163d8cb70 /var/spack/repos/builtin/packages/qt/package.py | |
| parent | 8f89932aad0bdba3e4ffad57e9973118f73a0bb6 (diff) | |
| download | spack-5df10c04cd4ffe223f346b8bd9e5cd80dedbfe34.tar.gz spack-5df10c04cd4ffe223f346b8bd9e5cd80dedbfe34.tar.bz2 spack-5df10c04cd4ffe223f346b8bd9e5cd80dedbfe34.tar.xz spack-5df10c04cd4ffe223f346b8bd9e5cd80dedbfe34.zip | |
Use stable URLs and `?full_index=1` for all github patches (#29239)
The number of commit characters in patch files fetched from GitHub can change,
so we should use `full_index=1` to enforce full commit hashes (and a stable
patch `sha256`).
Similarly, URLs for branches like `master` don't give us stable patch files,
because branches are moving targets. Use specific tags or commits for those.
- [x] update all github patch URLs to use `full_index=1`
- [x] don't use `master` or other branches for patches
- [x] add an audit check and a test for `?full_index=1`
Co-authored-by: Todd Gamblin <tgamblin@llnl.gov>
Diffstat (limited to 'var/spack/repos/builtin/packages/qt/package.py')
| -rw-r--r-- | var/spack/repos/builtin/packages/qt/package.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/var/spack/repos/builtin/packages/qt/package.py b/var/spack/repos/builtin/packages/qt/package.py index a5c87b62cc..8bc9e920af 100644 --- a/var/spack/repos/builtin/packages/qt/package.py +++ b/var/spack/repos/builtin/packages/qt/package.py @@ -118,8 +118,8 @@ class Qt(Package): # https://bugreports.qt.io/browse/QTBUG-58038 patch('qt5-8-freetype.patch', when='@5.8.0 +gui') # https://codereview.qt-project.org/c/qt/qtbase/+/245425 - patch('https://github.com/qt/qtbase/commit/a52d7861edfb5956de38ba80015c4dd0b596259b.patch', - sha256='c49b228c27e3ad46ec3af4bac0e9985af5b5b28760f238422d32e14f98e49b1e', + patch('https://github.com/qt/qtbase/commit/a52d7861edfb5956de38ba80015c4dd0b596259b.patch?full_index=1', + sha256='c113b4e31fc648d15d6d401f7625909d84f88320172bd1fbc5b100cc2cbf71e9', working_dir='qtbase', when='@5.10:5.12.0 %gcc@9:') # https://github.com/Homebrew/homebrew-core/pull/5951 |