diff options
author | Seth R. Johnson <johnsonsr@ornl.gov> | 2021-10-04 04:19:56 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-10-04 10:19:56 +0200 |
commit | 205b414162153e927b5fd2d1322ad1eda0fdc922 (patch) | |
tree | b73d9843a5c49b02f94e167633fc37d0a08c29ef /var/spack | |
parent | 5d431087ab59f8d44de1caa43f992cd59bd3bba1 (diff) | |
download | spack-205b414162153e927b5fd2d1322ad1eda0fdc922.tar.gz spack-205b414162153e927b5fd2d1322ad1eda0fdc922.tar.bz2 spack-205b414162153e927b5fd2d1322ad1eda0fdc922.tar.xz spack-205b414162153e927b5fd2d1322ad1eda0fdc922.zip |
hdf5: allow implicit functions on apple-clang (#26409)
Work around issues in older hdf5 build and overzealous build flags:
```
>> 1420 /var/folders/j4/fznvdyhx4875h6fhkqjn2kdr4jvyqd/T/9te/spack-stage/spack-stage-hdf5-1.10.4-feyl6tz6hpx5kl7m33avpuacwje2ubul/spack-src/src/H5Odeprec.c:141:8: error: implicit decl
aration of function 'H5CX_set_apl' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
```
Diffstat (limited to 'var/spack')
-rw-r--r-- | var/spack/repos/builtin/packages/hdf5/package.py | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/var/spack/repos/builtin/packages/hdf5/package.py b/var/spack/repos/builtin/packages/hdf5/package.py index 4fe7a8d0ae..48c05308cc 100644 --- a/var/spack/repos/builtin/packages/hdf5/package.py +++ b/var/spack/repos/builtin/packages/hdf5/package.py @@ -187,33 +187,33 @@ class Hdf5(CMakePackage): return url.format(version.up_to(2), version) def flag_handler(self, name, flags): + spec = self.spec cmake_flags = [] if name == "cflags": - if self.spec.satisfies('%gcc') \ - or self.spec.satisfies('%clang'): + if spec.compiler.name in ['gcc', 'clang', 'apple-clang']: # Quiet warnings/errors about implicit declaration of functions # in C99: cmake_flags.append("-Wno-implicit-function-declaration") # Note that this flag will cause an error if building %nvhpc. - if self.spec.satisfies('@:1.8.12~shared'): + if spec.satisfies('@:1.8.12~shared'): # More recent versions set CMAKE_POSITION_INDEPENDENT_CODE to # True and build with PIC flags. cmake_flags.append(self.compiler.cc_pic_flag) elif name == 'cxxflags': - if self.spec.satisfies('@:1.8.12+cxx~shared'): + if spec.satisfies('@:1.8.12+cxx~shared'): cmake_flags.append(self.compiler.cxx_pic_flag) elif name == "fflags": - if self.spec.satisfies('%cce+fortran'): + if spec.satisfies('%cce+fortran'): # Cray compiler generates module files with uppercase names by # default, which is not handled by the CMake scripts. The # following flag forces the compiler to produce module files # with lowercase names. cmake_flags.append('-ef') - if self.spec.satisfies('@:1.8.12+fortran~shared'): + if spec.satisfies('@:1.8.12+fortran~shared'): cmake_flags.append(self.compiler.fc_pic_flag) elif name == "ldlibs": - if '+fortran %fj' in self.spec: + if '+fortran %fj' in spec: cmake_flags.extend(['-lfj90i', '-lfj90f', '-lfjsrcinfo', '-lelf']) |