diff options
author | Massimiliano Culpo <massimiliano.culpo@gmail.com> | 2022-08-12 01:51:01 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-08-11 16:51:01 -0700 |
commit | 1913dc2da3f7b492761061a7413e9d52395f8a62 (patch) | |
tree | 48037a206a39405a65bff977132787151dc73c7a /var | |
parent | a550b8ce30033ccdfe2a52983aab03c1d485a528 (diff) | |
download | spack-1913dc2da3f7b492761061a7413e9d52395f8a62.tar.gz spack-1913dc2da3f7b492761061a7413e9d52395f8a62.tar.bz2 spack-1913dc2da3f7b492761061a7413e9d52395f8a62.tar.xz spack-1913dc2da3f7b492761061a7413e9d52395f8a62.zip |
Fix performance regression with `spack mirror create --all` (#32005)
This PR fixes the performance regression reported in #31985 and a few
other issues found while refactoring the spack mirror create command.
Modifications:
* (Primary) Do not require concretization for
`spack mirror create --all`
* Forbid using --versions-per-spec together with --all
* Fixed a few issues when reading specs from input file (specs were
not concretized, command would fail when trying to mirror
dependencies)
* Fix issue with default directory for spack mirror create not being
canonicalized
* Add more unit tests to poke spack mirror create
* Skip externals also when mirroring environments
* Changed slightly the wording for reporting (it was mentioning
"Successfully created" even in presence of errors)
* Fix issue with colify (was not called properly during error
reporting)
Diffstat (limited to 'var')
8 files changed, 15 insertions, 15 deletions
diff --git a/var/spack/repos/builtin/packages/rkt-base/package.py b/var/spack/repos/builtin/packages/rkt-base/package.py index 4ae2eda51c..256f90106e 100644 --- a/var/spack/repos/builtin/packages/rkt-base/package.py +++ b/var/spack/repos/builtin/packages/rkt-base/package.py @@ -17,6 +17,6 @@ class RktBase(RacketPackage): version("8.3", commit="cab83438422bfea0e4bd74bc3e8305e6517cf25f") # tag='v8.3' depends_on("racket@8.3", type=("build", "run"), when="@8.3") - name = "base" + racket_name = "base" pkgs = True - subdirectory = "pkgs/{0}".format(name) + subdirectory = "pkgs/{0}".format(racket_name) diff --git a/var/spack/repos/builtin/packages/rkt-cext-lib/package.py b/var/spack/repos/builtin/packages/rkt-cext-lib/package.py index 66de2376e8..8d9b257c05 100644 --- a/var/spack/repos/builtin/packages/rkt-cext-lib/package.py +++ b/var/spack/repos/builtin/packages/rkt-cext-lib/package.py @@ -20,6 +20,6 @@ class RktCextLib(RacketPackage): depends_on("rkt-dynext-lib@8.3", type=("build", "run"), when="@8.3") depends_on("rkt-scheme-lib@8.3", type=("build", "run"), when="@8.3") - name = "cext-lib" + racket_name = "cext-lib" pkgs = True - subdirectory = name + subdirectory = racket_name diff --git a/var/spack/repos/builtin/packages/rkt-compiler-lib/package.py b/var/spack/repos/builtin/packages/rkt-compiler-lib/package.py index 17ca12ab09..fee9b3ea9a 100644 --- a/var/spack/repos/builtin/packages/rkt-compiler-lib/package.py +++ b/var/spack/repos/builtin/packages/rkt-compiler-lib/package.py @@ -20,6 +20,6 @@ class RktCompilerLib(RacketPackage): depends_on("rkt-rackunit-lib@8.3", type=("build", "run"), when="@8.3") depends_on("rkt-zo-lib@1.3", type=("build", "run"), when="@8.3") - name = "compiler-lib" + racket_name = "compiler-lib" pkgs = True - subdirectory = "pkgs/{0}".format(name) + subdirectory = "pkgs/{0}".format(racket_name) diff --git a/var/spack/repos/builtin/packages/rkt-dynext-lib/package.py b/var/spack/repos/builtin/packages/rkt-dynext-lib/package.py index a235aca112..81f7ca811f 100644 --- a/var/spack/repos/builtin/packages/rkt-dynext-lib/package.py +++ b/var/spack/repos/builtin/packages/rkt-dynext-lib/package.py @@ -16,6 +16,6 @@ class RktDynextLib(RacketPackage): version("8.3", commit="cc22e2456df881a9008240d70dd9012ef37395f5") # tag = 'v8.3' depends_on("rkt-base@8.3", type=("build", "run"), when="@8.3") - name = "dynext-lib" + racket_name = "dynext-lib" pkgs = True - subdirectory = name + subdirectory = racket_name diff --git a/var/spack/repos/builtin/packages/rkt-rackunit-lib/package.py b/var/spack/repos/builtin/packages/rkt-rackunit-lib/package.py index e7661eec09..783aebe306 100644 --- a/var/spack/repos/builtin/packages/rkt-rackunit-lib/package.py +++ b/var/spack/repos/builtin/packages/rkt-rackunit-lib/package.py @@ -17,6 +17,6 @@ class RktRackunitLib(RacketPackage): depends_on("rkt-base@8.3:", type=("build", "run"), when="@8.3") depends_on("rkt-testing-util-lib@8.3", type=("build", "run"), when="@8.3") - name = "rackunit-lib" + racket_name = "rackunit-lib" pkgs = True - subdirectory = name + subdirectory = racket_name diff --git a/var/spack/repos/builtin/packages/rkt-scheme-lib/package.py b/var/spack/repos/builtin/packages/rkt-scheme-lib/package.py index 1765318158..75346eac70 100644 --- a/var/spack/repos/builtin/packages/rkt-scheme-lib/package.py +++ b/var/spack/repos/builtin/packages/rkt-scheme-lib/package.py @@ -16,5 +16,5 @@ class RktSchemeLib(RacketPackage): version("8.3", commit="a36e729680818712820ee5269f5208c3c0715a6a") # tag='v8.3' depends_on("rkt-base@8.3", type=("build", "run"), when="@8.3") - name = "scheme-lib" + racket_name = "scheme-lib" pkgs = True diff --git a/var/spack/repos/builtin/packages/rkt-testing-util-lib/package.py b/var/spack/repos/builtin/packages/rkt-testing-util-lib/package.py index aef3488150..9186845fc9 100644 --- a/var/spack/repos/builtin/packages/rkt-testing-util-lib/package.py +++ b/var/spack/repos/builtin/packages/rkt-testing-util-lib/package.py @@ -16,6 +16,6 @@ class RktTestingUtilLib(RacketPackage): version("8.3", commit="683237bee2a979c7b1541092922fb51a75ea8ca9") # tag='v8.3' depends_on("rkt-base@8.3:", type=("build", "run"), when="@8.3") - name = "testing-util-lib" + racket_name = "testing-util-lib" pkgs = True - subdirectory = name + subdirectory = racket_name diff --git a/var/spack/repos/builtin/packages/rkt-zo-lib/package.py b/var/spack/repos/builtin/packages/rkt-zo-lib/package.py index ae2373785a..66f3d498af 100644 --- a/var/spack/repos/builtin/packages/rkt-zo-lib/package.py +++ b/var/spack/repos/builtin/packages/rkt-zo-lib/package.py @@ -16,6 +16,6 @@ class RktZoLib(RacketPackage): version("1.3", commit="cab83438422bfea0e4bd74bc3e8305e6517cf25f") # tag='v1.3' depends_on("rkt-base@8.3:", type=("build", "run"), when="@1.3") - name = "zo-lib" + racket_name = "zo-lib" pkgs = True - subdirectory = "pkgs/{0}".format(name) + subdirectory = "pkgs/{0}".format(racket_name) |