summaryrefslogtreecommitdiff
path: root/var
diff options
context:
space:
mode:
authorTodd Gamblin <tgamblin@llnl.gov>2016-08-29 06:02:19 -0700
committerGitHub <noreply@github.com>2016-08-29 06:02:19 -0700
commitf5c9a8c2ee72244e8a8fb11a07880d5c962aad42 (patch)
tree64ea130986dbf5c21520e5d31921b8dfe8ca3b31 /var
parenta3f1ae8c4f27875363b2ab065a87d242649b4f55 (diff)
parent5333a799ea1dd22a829b509d30840b740206924a (diff)
downloadspack-f5c9a8c2ee72244e8a8fb11a07880d5c962aad42.tar.gz
spack-f5c9a8c2ee72244e8a8fb11a07880d5c962aad42.tar.bz2
spack-f5c9a8c2ee72244e8a8fb11a07880d5c962aad42.tar.xz
spack-f5c9a8c2ee72244e8a8fb11a07880d5c962aad42.zip
Merge pull request #1650 from davydden/pkg/ape_octopus_comments
ape octopus: in-code comments
Diffstat (limited to 'var')
-rw-r--r--var/spack/repos/builtin/packages/ape/package.py7
-rw-r--r--var/spack/repos/builtin/packages/octopus/package.py11
2 files changed, 14 insertions, 4 deletions
diff --git a/var/spack/repos/builtin/packages/ape/package.py b/var/spack/repos/builtin/packages/ape/package.py
index b1647798b5..48e436804f 100644
--- a/var/spack/repos/builtin/packages/ape/package.py
+++ b/var/spack/repos/builtin/packages/ape/package.py
@@ -45,6 +45,13 @@ class Ape(Package):
'--with-libxc-prefix=%s' % spec['libxc'].prefix
])
+ # When preprocessor expands macros (i.e. CFLAGS) defined as quoted
+ # strings the result may be > 132 chars and is terminated.
+ # This will look to a compiler as an Unterminated character constant
+ # and produce Line truncated errors. To vercome this, add flags to
+ # let compiler know that the entire line is meaningful.
+ # TODO: For the lack of better approach, assume that clang is mixed
+ # with GNU fortran.
if spec.satisfies('%clang') or spec.satisfies('%gcc'):
args.extend([
'FCFLAGS=-O2 -ffree-line-length-none'
diff --git a/var/spack/repos/builtin/packages/octopus/package.py b/var/spack/repos/builtin/packages/octopus/package.py
index 6fa2e0368f..ff4a106940 100644
--- a/var/spack/repos/builtin/packages/octopus/package.py
+++ b/var/spack/repos/builtin/packages/octopus/package.py
@@ -70,10 +70,13 @@ class Octopus(Package):
# --with-berkeleygw-prefix=${prefix}
])
- # Supposedly configure does not pick up the required flags for gfortran
- # Without it there are:
- # Error: Line truncated @ global.F90:157:132
- # Error: Unterminated character constant @ global.F90:157:20
+ # When preprocessor expands macros (i.e. CFLAGS) defined as quoted
+ # strings the result may be > 132 chars and is terminated.
+ # This will look to a compiler as an Unterminated character constant
+ # and produce Line truncated errors. To vercome this, add flags to
+ # let compiler know that the entire line is meaningful.
+ # TODO: For the lack of better approach, assume that clang is mixed
+ # with GNU fortran.
if spec.satisfies('%clang') or spec.satisfies('%gcc'):
args.extend([
'FCFLAGS=-O2 -ffree-line-length-none'