summaryrefslogtreecommitdiff
path: root/var
diff options
context:
space:
mode:
authorGlenn Johnson <glenn-johnson@uiowa.edu>2019-11-27 20:58:12 -0600
committerAdam J. Stewart <ajstewart426@gmail.com>2019-11-27 20:58:12 -0600
commite974f48be0a1fe1f622d6f5300c60b74d409fa20 (patch)
tree80d6960397f669a8ab03eca954995589ce70515a /var
parent1b24dfb8bafe86fbff47a9751b199e2707e3c23e (diff)
downloadspack-e974f48be0a1fe1f622d6f5300c60b74d409fa20.tar.gz
spack-e974f48be0a1fe1f622d6f5300c60b74d409fa20.tar.bz2
spack-e974f48be0a1fe1f622d6f5300c60b74d409fa20.tar.xz
spack-e974f48be0a1fe1f622d6f5300c60b74d409fa20.zip
Build R without recommended packages (#12015)
The documentation states that Spack builds R without the recommmened packages, with Spack handling the build of those packages to satisfy dependencies. From the docs: > Spack explicitly adds the --without-recommended-packages flag to > prevent the installation of these packages. Due to the way Spack > handles package activation (symlinking packages to the R installation > directory), pre-existing recommended packages will cause conflicts for > already-existing files. We could either not include these recommended > packages in Spack and require them to be installed through > --with-recommended-packages, or we could not install them with R and > let users choose the version of the package they want to install. We > chose the latter. However, this is not what Spack is actually doing. The `--without-recommended` configure option is not passed to R and therefore those packages are built. This prevents R extension activation from working as files in the recommended packages installed with R will block linking of file from the respective `r-` packages. This PR adds the `--without-recommended` flag to the configure options of the R package. This will then have the Spack R build match what is documented.
Diffstat (limited to 'var')
-rw-r--r--var/spack/repos/builtin/packages/r/package.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/var/spack/repos/builtin/packages/r/package.py b/var/spack/repos/builtin/packages/r/package.py
index 3755fb594f..e9897ffa28 100644
--- a/var/spack/repos/builtin/packages/r/package.py
+++ b/var/spack/repos/builtin/packages/r/package.py
@@ -115,6 +115,7 @@ class R(AutotoolsPackage):
'--enable-R-shlib',
'--enable-BLAS-shlib',
'--enable-R-framework=no',
+ '--without-recommended-packages',
'--with-tcl-config={0}'.format(tcl_config_path),
'LDFLAGS=-L{0} -Wl,-rpath,{0}'.format(join_path(prefix, 'rlib',
'R', 'lib')),