diff options
| author | Adam J. Stewart <ajstewart426@gmail.com> | 2022-01-19 05:33:59 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-01-19 12:33:59 +0100 |
| commit | cdac2cd4f292d9c8a85af56f09eba0750154224e (patch) | |
| tree | 3defea0b67e4ba9d556aed0d32820ab9c5d09a19 /var | |
| parent | d12bc3121a8f2aa26e96aa56e5209481d643425e (diff) | |
| download | spack-cdac2cd4f292d9c8a85af56f09eba0750154224e.tar.gz spack-cdac2cd4f292d9c8a85af56f09eba0750154224e.tar.bz2 spack-cdac2cd4f292d9c8a85af56f09eba0750154224e.tar.xz spack-cdac2cd4f292d9c8a85af56f09eba0750154224e.zip | |
py-pymol: don't install with pip (#28450)
Diffstat (limited to 'var')
| -rw-r--r-- | var/spack/repos/builtin/packages/py-pymol/package.py | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/var/spack/repos/builtin/packages/py-pymol/package.py b/var/spack/repos/builtin/packages/py-pymol/package.py index 768908a37d..2717fffe81 100644 --- a/var/spack/repos/builtin/packages/py-pymol/package.py +++ b/var/spack/repos/builtin/packages/py-pymol/package.py @@ -19,10 +19,8 @@ class PyPymol(PythonPackage): version('2.4.0', sha256='5ede4ce2e8f53713c5ee64f5905b2d29bf01e4391da7e536ce8909d6b9116581') version('2.3.0', sha256='62aa21fafd1db805c876f89466e47513809f8198395e1f00a5f5cc40d6f40ed0') - depends_on('python+tkinter@2.7:', type=('build', 'run'), when='@2.3.0:2.4.0') - depends_on('python+tkinter@3.6:', type=('build', 'run'), when='@2.5.0:') - # pip silently replaces distutils with setuptools - depends_on('py-setuptools', type='build') + depends_on('python+tkinter@2.7:', type=('build', 'link', 'run'), when='@2.3.0:2.4.0') + depends_on('python+tkinter@3.6:', type=('build', 'link', 'run'), when='@2.5.0:') depends_on('gl') depends_on('glew') depends_on('libpng') @@ -38,11 +36,19 @@ class PyPymol(PythonPackage): depends_on('libmmtf-cpp', type=('build', 'run', 'link')) depends_on('msgpack-c', type=('build', 'run')) depends_on('libpng', type=('build', 'run')) - depends_on('py-numpy', type=('build', 'run')) + depends_on('py-numpy', type=('build', 'link', 'run')) + depends_on('py-msgpack', type=('build', 'run')) def install_options(self, spec, prefix): return ['--no-launcher'] + def install(self, spec, prefix): + # Note: pymol monkeypatches distutils which breaks pip install, use deprecated + # `python setup.py install` and distutils instead of `pip install` and + # setuptools. See: https://github.com/schrodinger/pymol-open-source/issues/217 + python('setup.py', 'install', '--prefix=' + prefix, + *self.install_options(spec, prefix)) + @run_after('install') def install_launcher(self): binpath = self.prefix.bin |