summaryrefslogtreecommitdiff
path: root/var
diff options
context:
space:
mode:
authorHarmen Stoppels <harmenstoppels@gmail.com>2022-04-27 11:15:48 +0200
committerGitHub <noreply@github.com>2022-04-27 11:15:48 +0200
commitf273e7d3294026bcc8ba03310344893f5e5043bb (patch)
tree8812b84e1b1942c852faa87af68440075ab253a0 /var
parent351072cd9fba3b90f00cf8dc6e51c6d7cfd34fd1 (diff)
downloadspack-f273e7d3294026bcc8ba03310344893f5e5043bb.tar.gz
spack-f273e7d3294026bcc8ba03310344893f5e5043bb.tar.bz2
spack-f273e7d3294026bcc8ba03310344893f5e5043bb.tar.xz
spack-f273e7d3294026bcc8ba03310344893f5e5043bb.zip
openmpi: add toggle for rsh plm (#30251)
By default `openmpi` needs `rsh` from `openssh`, which is a somewhat redundant dependency for clusters using slurm. This PR adds a toggle to allow users to disable the ssh/rsh plm altogether.
Diffstat (limited to 'var')
-rw-r--r--var/spack/repos/builtin/packages/openmpi/package.py7
1 files changed, 6 insertions, 1 deletions
diff --git a/var/spack/repos/builtin/packages/openmpi/package.py b/var/spack/repos/builtin/packages/openmpi/package.py
index f5065a1847..6cf080cc0b 100644
--- a/var/spack/repos/builtin/packages/openmpi/package.py
+++ b/var/spack/repos/builtin/packages/openmpi/package.py
@@ -246,6 +246,7 @@ class Openmpi(AutotoolsPackage, CudaPackage):
variant('lustre', default=False,
description="Lustre filesystem library support")
variant('romio', default=True, description='Enable ROMIO support')
+ variant('rsh', default=True, description='Enable rsh (openssh) process lifecycle management')
# Adding support to build a debug version of OpenMPI that activates
# Memchecker, as described here:
#
@@ -329,7 +330,7 @@ class Openmpi(AutotoolsPackage, CudaPackage):
depends_on('pmix', when='+pmix')
depends_on('pmix@3.2:', when='@4.0:4 +pmix')
- depends_on('openssh', type='run')
+ depends_on('openssh', type='run', when='+rsh')
conflicts('+cxx_exceptions', when='%nvhpc',
msg='nvc does not ignore -fexceptions, but errors')
@@ -665,6 +666,10 @@ class Openmpi(AutotoolsPackage, CudaPackage):
# uct btl doesn't work with some UCX versions so just disable
config_args.append('--enable-mca-no-build=btl-uct')
+ # Remove ssh/rsh pml
+ if spec.satisfies('~rsh'):
+ config_args.append('--enable-mca-no-build=plm-rsh')
+
# some scientific packages ignore deprecated/remove symbols. Re-enable
# them for now, for discussion see
# https://github.com/open-mpi/ompi/issues/6114#issuecomment-446279495