Merge pull request #1650 from davydden/pkg/ape_octopus_comments

ape octopus: in-code comments

2 files changed, 14 insertions, 4 deletions

diff --git a/var/spack/repos/builtin/packages/ape/package.py b/var/spack/repos/builtin/packages/ape/package.py
index b1647798b5..48e436804f 100644
--- a/var/spack/repos/builtin/packages/ape/package.py
+++ b/var/spack/repos/builtin/packages/ape/package.py
@@ -45,6 +45,13 @@ class Ape(Package):
             '--with-libxc-prefix=%s' % spec['libxc'].prefix
         ])
 
+        # When preprocessor expands macros (i.e. CFLAGS) defined as quoted
+        # strings the result may be > 132 chars and is terminated.
+        # This will look to a compiler as an Unterminated character constant
+        # and produce Line truncated errors. To vercome this, add flags to
+        # let compiler know that the entire line is meaningful.
+        # TODO: For the lack of better approach, assume that clang is mixed
+        # with GNU fortran.
         if spec.satisfies('%clang') or spec.satisfies('%gcc'):
             args.extend([
                 'FCFLAGS=-O2 -ffree-line-length-none'
diff --git a/var/spack/repos/builtin/packages/octopus/package.py b/var/spack/repos/builtin/packages/octopus/package.py
index 6fa2e0368f..ff4a106940 100644
--- a/var/spack/repos/builtin/packages/octopus/package.py
+++ b/var/spack/repos/builtin/packages/octopus/package.py
@@ -70,10 +70,13 @@ class Octopus(Package):
             # --with-berkeleygw-prefix=${prefix}
         ])
 
-        # Supposedly configure does not pick up the required flags for gfortran
-        # Without it there are:
-        #   Error: Line truncated @ global.F90:157:132
-        #   Error: Unterminated character constant @ global.F90:157:20
+        # When preprocessor expands macros (i.e. CFLAGS) defined as quoted
+        # strings the result may be > 132 chars and is terminated.
+        # This will look to a compiler as an Unterminated character constant
+        # and produce Line truncated errors. To vercome this, add flags to
+        # let compiler know that the entire line is meaningful.
+        # TODO: For the lack of better approach, assume that clang is mixed
+        # with GNU fortran.
         if spec.satisfies('%clang') or spec.satisfies('%gcc'):
             args.extend([
                 'FCFLAGS=-O2 -ffree-line-length-none'