summaryrefslogtreecommitdiff
path: root/var
diff options
context:
space:
mode:
authorMassimiliano Culpo <massimiliano.culpo@gmail.com>2021-01-12 12:35:48 +0100
committerTamara Dahlgren <dahlgren1@llnl.gov>2021-02-17 17:07:42 -0800
commit7162e155314ce93f6a1ed28b0ea5cb06b53d1442 (patch)
tree422ae24b65c1f92b0d6159de769dd6cb7749dda2 /var
parentffa8479004a844b55ea4c1b04029aba28a5aff7d (diff)
downloadspack-7162e155314ce93f6a1ed28b0ea5cb06b53d1442.tar.gz
spack-7162e155314ce93f6a1ed28b0ea5cb06b53d1442.tar.bz2
spack-7162e155314ce93f6a1ed28b0ea5cb06b53d1442.tar.xz
spack-7162e155314ce93f6a1ed28b0ea5cb06b53d1442.zip
concretizer: dependency conditions cannot hold if package is external
fixes #20736 Before this one line fix we were erroneously deducing that dependency conditions hold even if a package was external. This may result in answer sets that contain imposed conditions on a node without the node being present in the DAG, hence #20736.
Diffstat (limited to 'var')
-rw-r--r--var/spack/repos/builtin.mock/packages/external-buildable-with-variant/package.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/var/spack/repos/builtin.mock/packages/external-buildable-with-variant/package.py b/var/spack/repos/builtin.mock/packages/external-buildable-with-variant/package.py
index 58de53054a..06245d6f69 100644
--- a/var/spack/repos/builtin.mock/packages/external-buildable-with-variant/package.py
+++ b/var/spack/repos/builtin.mock/packages/external-buildable-with-variant/package.py
@@ -11,5 +11,8 @@ class ExternalBuildableWithVariant(Package):
url = "http://somewhere.com/module-1.0.tar.gz"
version('1.0', '1234567890abcdef1234567890abcdef')
+ version('0.9', '1234567890abcdef1234567890abcdef')
variant('baz', default=False, description='nope')
+
+ depends_on('c@1.0', when='@0.9')