summaryrefslogtreecommitdiff
path: root/var
diff options
context:
space:
mode:
authorWouter Deconinck <wdconinc@gmail.com>2022-08-31 18:16:22 -0500
committerGitHub <noreply@github.com>2022-08-31 16:16:22 -0700
commitc75c27c95c49e64a14afad7b63632c55c123e03b (patch)
treeee332b4990202eda23a8349a46aad422b474df49 /var
parentf1f831edef535c1a271543f7265a3274d4395489 (diff)
downloadspack-c75c27c95c49e64a14afad7b63632c55c123e03b.tar.gz
spack-c75c27c95c49e64a14afad7b63632c55c123e03b.tar.bz2
spack-c75c27c95c49e64a14afad7b63632c55c123e03b.tar.xz
spack-c75c27c95c49e64a14afad7b63632c55c123e03b.zip
gdk-pixbuf: only build tests when requested (#32452)
The building of tests is optional [as of 2.42.9](https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/commit/801eef111df624f4377baed9a90c94b6a2d4340c). This applies this option in the build. The reason the option was added was to deal with test build failures in sandboxed environments and with certain glibc versions (caused by glib gresources). For example, with the latest version glibc and in the latest version of docker these tests [cannot be built](https://github.com/moby/moby/issues/43595).
Diffstat (limited to 'var')
-rw-r--r--var/spack/repos/builtin/packages/gdk-pixbuf/package.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/var/spack/repos/builtin/packages/gdk-pixbuf/package.py b/var/spack/repos/builtin/packages/gdk-pixbuf/package.py
index 153f04b8c5..2affe5fae9 100644
--- a/var/spack/repos/builtin/packages/gdk-pixbuf/package.py
+++ b/var/spack/repos/builtin/packages/gdk-pixbuf/package.py
@@ -91,6 +91,9 @@ class GdkPixbuf(Package):
def install(self, spec, prefix):
with working_dir("spack-build", create=True):
meson_args = std_meson_args + ["-Dman={0}".format("+man" in spec)]
+ # Only build tests when requested
+ if self.version >= Version("2.42.9"):
+ meson_args += ["-Dtests={0}".format(self.run_tests)]
# Based on suggestion by luigi-calori and the fixup shown by lee218llnl:
# https://github.com/spack/spack/pull/27254#issuecomment-974464174
if "+x11" in spec: