diff options
author | Massimiliano Culpo <massimiliano.culpo@gmail.com> | 2019-07-16 17:54:33 +0200 |
---|---|---|
committer | Greg Becker <becker33@llnl.gov> | 2019-07-16 10:54:33 -0500 |
commit | 2fe1ecbaa2f87bc3f11f73ee41828ea5b9a6b3d5 (patch) | |
tree | 121cfbe45760f6d2875764de4d1e7aed5085e9ed /var | |
parent | 5ed68d31a2a633b337a0730ebdd8c5c8611fbb0e (diff) | |
download | spack-2fe1ecbaa2f87bc3f11f73ee41828ea5b9a6b3d5.tar.gz spack-2fe1ecbaa2f87bc3f11f73ee41828ea5b9a6b3d5.tar.bz2 spack-2fe1ecbaa2f87bc3f11f73ee41828ea5b9a6b3d5.tar.xz spack-2fe1ecbaa2f87bc3f11f73ee41828ea5b9a6b3d5.zip |
Ignore Modules v4 environment variables in `from_sourcing_file` (#10753)
* from_sourcing_file: fixed a bug + added a few ignored variables
closes #7536
Credits for this change goes to mgsternberg (original author of #7536)
The new variables being ignored are specific to Modules v4.
* Use Spack Executable in 'EnvironmentModifications.from_sourcing_file'
Using this class avoids duplicating lower level logic to decode
stdout and handle non-zero return codes
* Extracted a function that returns the environment after sourcing files
The logic in `EnvironmentModifications.from_sourcing_file` has been
simplified by extracting a function that returns a dictionary with the
environment one would have after sourcing the files passed as argument.
* Further refactoring of EnvironmentModifications.from_sourcing_file
Extracted a function that sanitizes a dictionary removing keys that are
blacklisted, but keeping those that are whitelisted. Blacklisting and
whitelisting can be done on literals or regex.
Extracted a new factory that creates an instance of
EnvironmentModifications from a diff of two environments.
* Added unit tests
* PS1 is blacklisted + more readable names for some variables
Diffstat (limited to 'var')
0 files changed, 0 insertions, 0 deletions