Use GitLab's API endpoint for fetching a git snapshot. (#7881)

* Use GitLab's API endpoint for fetching a git snapshot.

* More GitLab packages use the API.

* find_list_url for GitLab's API URLs.

* Flake8

* Url for 'hacckernels'.

* Check GitLab API regexps before the non-API ones.

9 files changed, 19 insertions, 15 deletions

diff --git a/var/spack/repos/builtin/packages/busco/package.py b/var/spack/repos/builtin/packages/busco/package.py
index ca4220f29d..48c4c50719 100644
--- a/var/spack/repos/builtin/packages/busco/package.py
+++ b/var/spack/repos/builtin/packages/busco/package.py
@@ -30,10 +30,16 @@ class Busco(PythonPackage):
        Universal Single-Copy Orthologs"""
 
     homepage = "http://busco.ezlab.org/"
-    url      = "https://gitlab.com/ezlab/busco"
+    url      = "https://gitlab.com/api/v4/projects/ezlab%2Fbusco/repository/archive.tar.gz?sha=2.0.1"
 
-    version('3.0.1', git='https://gitlab.com/ezlab/busco.git', commit='078252e00399550d7b0e8941cd4d986c8e868a83')
-    version('2.0.1', git='https://gitlab.com/ezlab/busco.git', commit='89aa1ab2527f03a87a214ca90a504ad236582a11')
+    # TODO: check the installation procedure for version 3.0.2
+    # and uncomment the following line
+    # version('3.0.2', '31d80042bb7e96422843fa43d0acbd21')
+
+    # There is no tag for version 3.0.1
+    version('3.0.1', git='https://gitlab.com/ezlab/busco.git',
+            commit='078252e00399550d7b0e8941cd4d986c8e868a83')
+    version('2.0.1', '4dbcc8a0c18fa8f8312c103eb2fbb4e2')
 
     depends_on('python', type=('build', 'run'))
     depends_on('blast-plus')
diff --git a/var/spack/repos/builtin/packages/hacckernels/package.py b/var/spack/repos/builtin/packages/hacckernels/package.py
index 39a11c7011..e3a5c3cc12 100644
--- a/var/spack/repos/builtin/packages/hacckernels/package.py
+++ b/var/spack/repos/builtin/packages/hacckernels/package.py
@@ -33,7 +33,7 @@ class Hacckernels(CMakePackage):
     cores and beyond."""
 
     homepage = "https://xgitlab.cels.anl.gov/hacc/HACCKernels"
-    url      = "https://xgitlab.cels.anl.gov/hacc/HACCKernels.git"
+    url      = "https://xgitlab.cels.anl.gov/api/v4/projects/hacc%2FHACCKernels/repository/archive.tar.gz"
 
     tags = ['proxy-app']
 
diff --git a/var/spack/repos/builtin/packages/icet/package.py b/var/spack/repos/builtin/packages/icet/package.py
index ff934c553e..1a2181c24f 100644
--- a/var/spack/repos/builtin/packages/icet/package.py
+++ b/var/spack/repos/builtin/packages/icet/package.py
@@ -30,7 +30,7 @@ class Icet(CMakePackage):
        sort-last parallel rendering library."""
 
     homepage = "http://icet.sandia.gov"
-    url      = "https://gitlab.kitware.com/icet/icet/repository/archive.tar.bz2?ref=IceT-2.1.1"
+    url      = "https://gitlab.kitware.com/api/v4/projects/icet%2Ficet/repository/archive.tar.bz2?sha=IceT-2.1.1"
 
     version('develop', branch='master',
             git='https://gitlab.kitware.com/icet/icet.git')
diff --git a/var/spack/repos/builtin/packages/libaec/package.py b/var/spack/repos/builtin/packages/libaec/package.py
index f6b349942b..b89723131f 100644
--- a/var/spack/repos/builtin/packages/libaec/package.py
+++ b/var/spack/repos/builtin/packages/libaec/package.py
@@ -33,7 +33,7 @@ class Libaec(CMakePackage):
     """
 
     homepage = 'https://gitlab.dkrz.de/k202009/libaec'
-    url = 'https://gitlab.dkrz.de/k202009/libaec/repository/archive.tar.gz?ref=v1.0.2'
+    url = 'https://gitlab.dkrz.de/api/v4/projects/k202009%2Flibaec/repository/archive.tar.gz?sha=v1.0.2'
     list_url = 'https://gitlab.dkrz.de/k202009/libaec/tags'
 
     provides('szip')
diff --git a/var/spack/repos/builtin/packages/parsplice/package.py b/var/spack/repos/builtin/packages/parsplice/package.py
index 24b950548f..10b81171de 100644
--- a/var/spack/repos/builtin/packages/parsplice/package.py
+++ b/var/spack/repos/builtin/packages/parsplice/package.py
@@ -30,7 +30,7 @@ class Parsplice(CMakePackage):
     """ParSplice code implements the Parallel Trajectory Splicing algorithm"""
 
     homepage = "https://gitlab.com/exaalt/parsplice"
-    url      = "https://gitlab.com/exaalt/parsplice/repository/archive.tar.gz?ref=v1.1"
+    url      = "https://gitlab.com/api/v4/projects/exaalt%2Fparsplice/repository/archive.tar.gz?sha=v1.1"
 
     version('1.1', '3a72340d49d731a076e8942f2ae2f4e9')
     version('develop', git='https://gitlab.com/exaalt/parsplice', branch='master')
diff --git a/var/spack/repos/builtin/packages/swfft/package.py b/var/spack/repos/builtin/packages/swfft/package.py
index ce0b027c9e..ba77704770 100644
--- a/var/spack/repos/builtin/packages/swfft/package.py
+++ b/var/spack/repos/builtin/packages/swfft/package.py
@@ -31,8 +31,7 @@ class Swfft(MakefilePackage):
     parallel 3D FFT."""
 
     homepage = 'https://xgitlab.cels.anl.gov/hacc/SWFFT'
-
-    url = "https://xgitlab.cels.anl.gov/hacc/SWFFT/repository/v1.0/archive.tar.gz"
+    url = "https://xgitlab.cels.anl.gov/api/v4/projects/hacc%2FSWFFT/repository/archive.tar.gz?sha=v1.0"
 
     version('1.0', '0fbc34544b97ba9c3fb19ef2d7a0f076')
     version('develop', git='https://xgitlab.cels.anl.gov/hacc/SWFFT',
diff --git a/var/spack/repos/builtin/packages/swiftsim/package.py b/var/spack/repos/builtin/packages/swiftsim/package.py
index 6241634ab2..602a03fd73 100644
--- a/var/spack/repos/builtin/packages/swiftsim/package.py
+++ b/var/spack/repos/builtin/packages/swiftsim/package.py
@@ -33,10 +33,9 @@ class Swiftsim(AutotoolsPackage):
     """
 
     homepage = 'http://icc.dur.ac.uk/swift/'
-    url = 'http://gitlab.cosma.dur.ac.uk/swift/swiftsim/repository/archive.tar.gz?ref=v0.3.0'
+    url = 'https://gitlab.cosma.dur.ac.uk/api/v4/projects/swift%2Fswiftsim/repository/archive.tar.gz?sha=v0.3.0'
 
-    version('0.3.0', git='https://gitlab.cosma.dur.ac.uk/swift/swiftsim.git',
-            commit='254cc1b563b2f88ddcf437b1f71da123bb9db733')
+    version('0.3.0', '162ec2bdfdf44a31a08b3fcee23a886a')
 
     variant('mpi', default=True,
             description='Enable distributed memory parallelism')
diff --git a/var/spack/repos/builtin/packages/vecgeom/package.py b/var/spack/repos/builtin/packages/vecgeom/package.py
index 1e5a1542ff..8945f07ea5 100644
--- a/var/spack/repos/builtin/packages/vecgeom/package.py
+++ b/var/spack/repos/builtin/packages/vecgeom/package.py
@@ -32,9 +32,9 @@ class Vecgeom(CMakePackage):
     (toolkits)."""
 
     homepage = "https://gitlab.cern.ch/VecGeom/VecGeom"
+    url = "https://gitlab.cern.ch/api/v4/projects/VecGeom%2FVecGeom/repository/archive.tar.gz?sha=v0.3.rc"
 
-    version('0.3.rc', git='https://gitlab.cern.ch/VecGeom/VecGeom.git',
-            tag='v0.3.rc')
+    version('0.3.rc', 'c1f5d620f655f3c0610a44e7735203b5')
 
     depends_on('cmake@3.5:', type='build')
 
diff --git a/var/spack/repos/builtin/packages/vtkm/package.py b/var/spack/repos/builtin/packages/vtkm/package.py
index a461c70b72..f9075b33da 100644
--- a/var/spack/repos/builtin/packages/vtkm/package.py
+++ b/var/spack/repos/builtin/packages/vtkm/package.py
@@ -36,7 +36,7 @@ class Vtkm(Package):
     architectures."""
 
     homepage = "https://m.vtk.org/"
-    url      = "https://gitlab.kitware.com/vtk/vtk-m/repository/v1.1.0/archive.tar.gz"
+    url      = "https://gitlab.kitware.com/api/v4/projects/vtk%2Fvtk-m/repository/archive.tar.gz?sha=v1.1.0"
 
     version('1.1.0', "6aab1c0885f6ffaaffcf07930873d0df")