diff options
| author | Chuck Atkins <chuck.atkins@kitware.com> | 2020-11-30 17:54:24 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-11-30 23:54:24 +0100 |
| commit | 7d79db2de781896e11efbdb7064639f581060c83 (patch) | |
| tree | cc0a502276339caa29679dc38d6e1ab83b38a1c1 /var | |
| parent | bb9f5d613cc6e1796222d164aacb17adc622d28f (diff) | |
| download | spack-7d79db2de781896e11efbdb7064639f581060c83.tar.gz spack-7d79db2de781896e11efbdb7064639f581060c83.tar.bz2 spack-7d79db2de781896e11efbdb7064639f581060c83.tar.xz spack-7d79db2de781896e11efbdb7064639f581060c83.zip | |
Fix Mesa GLES conflicts (#20184)
Diffstat (limited to 'var')
| -rw-r--r-- | var/spack/repos/builtin/packages/mesa/package.py | 3 | ||||
| -rw-r--r-- | var/spack/repos/builtin/packages/mesa18/package.py | 19 |
2 files changed, 8 insertions, 14 deletions
diff --git a/var/spack/repos/builtin/packages/mesa/package.py b/var/spack/repos/builtin/packages/mesa/package.py index e7f2dcc575..c3988fbb30 100644 --- a/var/spack/repos/builtin/packages/mesa/package.py +++ b/var/spack/repos/builtin/packages/mesa/package.py @@ -80,6 +80,9 @@ class Mesa(MesonPackage): # TODO: Add vulkan to this conflict once made available conflicts('~opengl ~opengles') + # OpenGL ES requires OpenGL + conflicts('~opengl +opengles') + def meson_args(self): spec = self.spec args = [ diff --git a/var/spack/repos/builtin/packages/mesa18/package.py b/var/spack/repos/builtin/packages/mesa18/package.py index 1dcead5965..b882c9aa70 100644 --- a/var/spack/repos/builtin/packages/mesa18/package.py +++ b/var/spack/repos/builtin/packages/mesa18/package.py @@ -52,12 +52,11 @@ class Mesa18(AutotoolsPackage): is_linux = sys.platform.startswith('linux') variant('glx', default=is_linux, description="Enable the GLX frontend.") - # Back ends - variant('opengl', default=True, description="Enable full OpenGL support.") + # Additional backends variant('opengles', default=False, description="Enable OpenGL ES support.") # Provides - provides('gl@4.5', when='+opengl') + provides('gl@4.5') provides('glx@1.4', when='+glx') provides('osmesa', when='+osmesa') @@ -71,9 +70,6 @@ class Mesa18(AutotoolsPackage): # Require at least 1 front-end conflicts('~osmesa ~glx') - # Require at least 1 back-end - conflicts('~opengl ~opengles') - # Prevent an unnecessary xcb-dri dependency patch('autotools-x11-nodri.patch') @@ -103,7 +99,8 @@ class Mesa18(AutotoolsPackage): '--with-vulkan-drivers=', '--disable-egl', '--disable-gbm', - '--disable-dri'] + '--disable-dri', + '--enable-opengl'] args_platforms = [] args_gallium_drivers = ['swrast'] @@ -126,11 +123,6 @@ class Mesa18(AutotoolsPackage): else: args.append('--disable-glx') - if '+opengl' in spec: - args.append('--enable-opengl') - else: - args.append('--disable-opengl') - if '+opengles' in spec: args.extend(['--enable-gles1', '--enable-gles2']) else: @@ -184,8 +176,7 @@ class Mesa18(AutotoolsPackage): if '+glx' in spec: libs_to_seek.add('libGL') - if '+opengl' in spec: - libs_to_seek.add('libGL') + libs_to_seek.add('libGL') if '+opengles' in spec: libs_to_seek.add('libGLES') |