summaryrefslogtreecommitdiff
path: root/var
diff options
context:
space:
mode:
authorGreg Becker <becker33@llnl.gov>2021-11-02 10:55:50 -0700
committerGitHub <noreply@github.com>2021-11-02 10:55:50 -0700
commitb3711c0d9d07b8b0e673adc49f5742d90cf48a12 (patch)
treee45e5504804d80715eac746fc30f88d0ddf96c4d /var
parent3187689862bf3a6c0eced724614944449213fcb1 (diff)
downloadspack-b3711c0d9d07b8b0e673adc49f5742d90cf48a12.tar.gz
spack-b3711c0d9d07b8b0e673adc49f5742d90cf48a12.tar.bz2
spack-b3711c0d9d07b8b0e673adc49f5742d90cf48a12.tar.xz
spack-b3711c0d9d07b8b0e673adc49f5742d90cf48a12.zip
Improved error messages from clingo (#26719)
This PR adds error message sentinels to the clingo solve, attached to each of the rules that could fail a solve. The unsat core is then restricted to these messages, which makes the minimization problem tractable. Errors that can only be generated by a bug in the logic program or generating code are prefaced with "Internal error" to make clear to users that something has gone wrong on the Spack side of things. * minimize unsat cores manually * only errors messages are choices/assumptions for performance * pre-check for unreachable nodes * update tests for new error message * make clingo concretization errors show up in cdash reports fully * clingo: make import of clingo.ast parsing routines robust to clingo version Older `clingo` has `parse_string`; newer `clingo` has `parse_files`. Make the code work wtih both. * make AST access functions backward-compatible with clingo 5.4.0 Clingo AST API has changed since 5.4.0; make some functions to help us handle both versions of the AST. Co-authored-by: Todd Gamblin <tgamblin@llnl.gov>
Diffstat (limited to 'var')
0 files changed, 0 insertions, 0 deletions