summaryrefslogtreecommitdiff
path: root/var
diff options
context:
space:
mode:
authorDenis Davydov <davydden@gmail.com>2016-08-29 08:45:28 +0200
committerDenis Davydov <davydden@gmail.com>2016-08-29 08:45:28 +0200
commit5333a799ea1dd22a829b509d30840b740206924a (patch)
treefcd67604b8aaa7ac22e81a2c90fa96107624386c /var
parent90070c317dd10c0e12babe71e90e98cea0447693 (diff)
downloadspack-5333a799ea1dd22a829b509d30840b740206924a.tar.gz
spack-5333a799ea1dd22a829b509d30840b740206924a.tar.bz2
spack-5333a799ea1dd22a829b509d30840b740206924a.tar.xz
spack-5333a799ea1dd22a829b509d30840b740206924a.zip
octopus: in-code comments to explain compiler flags
Diffstat (limited to 'var')
-rw-r--r--var/spack/repos/builtin/packages/octopus/package.py11
1 files changed, 7 insertions, 4 deletions
diff --git a/var/spack/repos/builtin/packages/octopus/package.py b/var/spack/repos/builtin/packages/octopus/package.py
index 6fa2e0368f..ff4a106940 100644
--- a/var/spack/repos/builtin/packages/octopus/package.py
+++ b/var/spack/repos/builtin/packages/octopus/package.py
@@ -70,10 +70,13 @@ class Octopus(Package):
# --with-berkeleygw-prefix=${prefix}
])
- # Supposedly configure does not pick up the required flags for gfortran
- # Without it there are:
- # Error: Line truncated @ global.F90:157:132
- # Error: Unterminated character constant @ global.F90:157:20
+ # When preprocessor expands macros (i.e. CFLAGS) defined as quoted
+ # strings the result may be > 132 chars and is terminated.
+ # This will look to a compiler as an Unterminated character constant
+ # and produce Line truncated errors. To vercome this, add flags to
+ # let compiler know that the entire line is meaningful.
+ # TODO: For the lack of better approach, assume that clang is mixed
+ # with GNU fortran.
if spec.satisfies('%clang') or spec.satisfies('%gcc'):
args.extend([
'FCFLAGS=-O2 -ffree-line-length-none'