diff options
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/spack/spack/solver/concretize.lp | 3 | ||||
| -rw-r--r-- | lib/spack/spack/test/concretize.py | 8 |
2 files changed, 11 insertions, 0 deletions
diff --git a/lib/spack/spack/solver/concretize.lp b/lib/spack/spack/solver/concretize.lp index 938f4ece89..d0174ca2e0 100644 --- a/lib/spack/spack/solver/concretize.lp +++ b/lib/spack/spack/solver/concretize.lp @@ -88,6 +88,9 @@ dependency_conditions_hold(ID, Parent, Dependency) :- attr(Name, Arg1, Arg2) : required_dependency_condition(ID, Name, Arg1, Arg2); attr(Name, Arg1, Arg2, Arg3) : required_dependency_condition(ID, Name, Arg1, Arg2, Arg3); dependency_condition(ID, Parent, Dependency); + % There must be at least a dependency type declared, + % otherwise the dependency doesn't hold + dependency_type(ID, _); node(Parent); not external(Parent). diff --git a/lib/spack/spack/test/concretize.py b/lib/spack/spack/test/concretize.py index 3eab265d8c..dae162a12f 100644 --- a/lib/spack/spack/test/concretize.py +++ b/lib/spack/spack/test/concretize.py @@ -1089,3 +1089,11 @@ class TestConcretize(object): ).concretized() assert root.dag_hash() == new_root.dag_hash() + + @pytest.mark.regression('20784') + def test_concretization_of_test_dependencies(self): + # With clingo we emit dependency_conditions regardless of the type + # of the dependency. We need to ensure that there's at least one + # dependency type declared to infer that the dependency holds. + s = Spec('test-dep-with-imposed-conditions').concretized() + assert 'c' not in s |