summaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)AuthorFilesLines
2020-08-14spack config update (bugfix): packages.yaml with empty attributes (#18057)Massimiliano Culpo2-1/+30
Before this PR, packages.yaml files that contained an empty "paths" or "modules" attribute were not updated correctly, since the update function was not reporting them as changed after the update. This PR fixes that issue and adds a unit test to avoid regression.
2020-08-13Improve output of the external find command (#18017)Massimiliano Culpo2-6/+38
This commit adds output to the "spack external find" command to inform users of the result of the operation. It also fixes a bug introduced in #17804 due to the fact that a function was not updated to conform to the new packages.yaml format (_get_predefined_externals).
2020-08-13fix buildcache create for environments with uninstalled root specs (#17859)Harmen Stoppels1-13/+21
* Handle uninstalled rootspecs in buildcache - Do not parse specs / find matching specs when in an environment and no package string is provided - Error only when a spec.yaml or spec string are not installed. In an environment it is fine when the root spec does not exist. - When iterating through the matched specs, simply skip uninstalled packages
2020-08-13"spack config update" can handle comments in YAML files (#18045)Massimiliano Culpo2-1/+37
fixes #18031 With this fix "spack config update" can update YAML files that contain comments, while previously it couldn't.
2020-08-13Merge tag 'v0.15.4' into developTodd Gamblin3-6/+10
2020-08-13bump version number for 0.15.4Todd Gamblin3-6/+10
2020-08-13Move Python 2.6 unit tests to Github Actions (#17279)Massimiliano Culpo3-18/+38
* Run Python2.6 unit tests on Github Actions * Skip url tests on Python 2.6 to reduce waiting times * Skip foreground background tests on Python 2.6 to reduce waiting times * Removed references to Travis in the documentation * Deleted install_patchelf.sh (can be installed from repo on CentOS 6)
2020-08-13Buildcache: bindist test without invoking spack compiler wrappers. (#15687)Patrick Gartung2-0/+472
* Buildcache: * Try mocking an install of quux, corge and garply using prebuilt binaries * Put patchelf install after ccache restore * Add script to install patchelf from source so it can be used on Ubuntu:Trusty which does not have a patchelf pat package. The script will skip building on macOS * Remove mirror at end of bindist test * Add patchelf to Ubuntu build env * Revert mock patchelf package to allow other tests to run. * Remove depends_on('patchelf', type='build') relying instead on * Test fixture to ensure patchelf is available. * Call g++ command to build libraries directly during test build * Flake8 * Install patchelf in before_install stage using apt unless on Trusty where a build is done. * Add some symbolic links between packages * Flake8 * Flake8: * Update mock packages to write their own source files * Create the stage because spec search does not create it any longer * updates after change of list command arguments * cleanup after merge * flake8
2020-08-13docs: document releases and branches in SpackTodd Gamblin5-6/+384
- [x] Remove references to `master` branch - [x] Document how release branches are structured - [x] Document how to make a major release - [x] Document how to make a point release - [x] Document how to do work in our release projects
2020-08-13Remove references to `master` from CITodd Gamblin1-1/+1
- [x] remove master from github actions - [x] remove master from .travis.yml - [x] make `develop` the default branch for `spack ci`
2020-08-13Moved flake8, shell and documentation tests to Github Action (#17328)Massimiliano Culpo1-2/+0
* Move flake8 tests on Github Actions * Move shell test to Github Actions * Moved documentation build to Github Action * Don't run coverage on Python 2.6 Since we get connection errors consistently on Travis when trying to upload coverage results for Python 2.6, avoid computing coverage entirely to speed-up tests.
2020-08-12bugfix: fix spack -V with releases/latest and shallow clones (#17884)Todd Gamblin1-2/+2
`spack -V` stopped working when we added the `releases/latest` tag to track the most recent release. It started just reporting the version, even on a `develop` checkout. We need to tell it to *only* search for tags that start with `v`, so that it will ignore `releases/latest`. `spack -V` also would print out unwanted git eror output on a shallow clone. - [x] add `--match 'v*'` to `git describe` arguments - [x] route error output to `os.devnull`
2020-08-12Buildcache create: change NoOverwriteException back to a warning as in v0.14 ↵Patrick Gartung1-3/+6
(#17832) * Change buildcache create `NoOverwriteException` back to a warning.
2020-08-12bugfix: fix spack buildcache list --allarchTodd Gamblin3-17/+53
`spack buildcache list` was trying to construct an `Arch` object and compare it to `arch_for_spec(<spec>)`. for each spec in the buildcache. `Arch` objects are only intended to be constructed for the machine they describe. The `ArchSpec` object (part of the `Spec`) is the descriptor that lets us talk about architectures anywhere. - [x] Modify `spack buildcache list` and `spack buildcache install` to filter with `Spec` matching instead of using `Arch`.
2020-08-12architecture: make it easier to get a Spec for the default archTodd Gamblin1-2/+15
- [x] Make it easier to get a `Spec` with a proper `ArchSpec` from an `Arch` object via new `Arch.to_spec()` method. - [x] Pull `spack.architecture.default_arch()` out of `spack.architecture.sys_type()` so we can get an `Arch` instead of a string.
2020-08-12allow GNUPGHOME to come from SPACK_GNUPGHOME in env, if set (#17139)eugeneswalker1-1/+1
2020-08-12Axom + Conduit updates (#17863)Chris White1-1/+1
* Loosen Axom's variants, add shared variant for axom, fix clang/xlf rpath'ing problem on blueos * Fix flake8 * Add main branch to list of known git branches
2020-08-12Respect $PATH ordering when registering compilers (#17967)Harmen Stoppels2-3/+33
2020-08-11Fix loading of compiler modules on CRAY (#17984)Massimiliano Culpo2-1/+3
The modifications in 193e8333fa23a2e9b44d44a80e153d9a27033860 introduced a bug in the loading of compiler modules, since a function that was expecting a list of string was just getting a string. This commit fixes the bug and adds an assertion to verify the prerequisite of the function.
2020-08-11Fix typo in spack external debug msg (#17982)Adam J. Stewart2-3/+3
2020-08-10Removed references to BlueGene/Q in docs and commentsMassimiliano Culpo5-36/+37
2020-08-10Removed references to BlueGene/Q in core SpackMassimiliano Culpo7-71/+3
2020-08-10Simplify the detection protocol for packagesMassimiliano Culpo7-80/+453
Packages can implement “detect_version” to support detection of external instances of a package. This is generally easier than implementing “determine_spec_details”. The API for determine_version is similar: for example you can return “None” to indicate that an executable is not an instance of a package. Users may implement a “determine_variants” method for a package. When doing external detection, executables are grouped by version and each group results in a single invocation of “determine_variants” for the associated spec. The method returns a string specifying the variants for the package. The method may additionally return a dictionary representing extra attributes for the package. These will be stored in the spec yaml and can be retrieved from self.spec.extra_attributes The Spack GCC package has been updated with an implementation of “determine_variants” which adds the following extra attributes to the package: c, cxx, fortran
2020-08-10Update packages.yaml format and support configuration updatesMassimiliano Culpo29-215/+1063
The YAML config for paths and modules of external packages has changed: the new format allows a single spec to load multiple modules. Spack will automatically convert from the old format when reading the configs (the updates do not add new essential properties, so this change in Spack is backwards-compatible). With this update, Spack cannot modify existing configs/environments without updating them (e.g. “spack config add” will fail if the configuration is in a format that predates this PR). The user is prompted to do this explicitly and commands are provided. All config scopes can be updated at once. Each environment must be updated one at a time.
2020-08-10Hotfix for config singleton initialization (#17263)Michael Kuhn1-0/+4
Fixes #17262
2020-08-09deptypes: move deptype formatting code from Spec.format to dependency.py ↵Todd Gamblin2-10/+31
(#17843) - This simplifies Spec.format somewhat - Makes code to generate deptype strings (e.g., '[blrt]') reusable
2020-08-07Fujitsu compiler: Accept alphabet as version. (#17890)Tomoki, Karatsu2-7/+7
* Fujitsu compiler: Accept alphabet as version. * Fujitsu copiler: Updated test pattern.
2020-08-05bugfix: fix spack -V with releases/latest and shallow clones (#17884)Todd Gamblin1-2/+2
`spack -V` stopped working when we added the `releases/latest` tag to track the most recent release. It started just reporting the version, even on a `develop` checkout. We need to tell it to *only* search for tags that start with `v`, so that it will ignore `releases/latest`. `spack -V` also would print out unwanted git eror output on a shallow clone. - [x] add `--match 'v*'` to `git describe` arguments - [x] route error output to `os.devnull`
2020-08-03Fix typo: yaml -> json (#17854)Harmen Stoppels1-1/+1
2020-08-03Fix docs about containers on cray (#17431)Harmen Stoppels2-7/+7
* For detecting Cray: CRAYPE_VERSION is not used, but MODULEPATH * Fix typo and write Cray with a capital
2020-08-02Buildcache create: change NoOverwriteException back to a warning as in v0.14 ↵Patrick Gartung1-3/+6
(#17832) * Change buildcache create `NoOverwriteException` back to a warning.
2020-08-02Add bindist tests for macOS.Patrick Gartung1-13/+13
2020-08-01bugfix: fix spack buildcache list --allarchTodd Gamblin3-17/+53
`spack buildcache list` was trying to construct an `Arch` object and compare it to `arch_for_spec(<spec>)`. for each spec in the buildcache. `Arch` objects are only intended to be constructed for the machine they describe. The `ArchSpec` object (part of the `Spec`) is the descriptor that lets us talk about architectures anywhere. - [x] Modify `spack buildcache list` and `spack buildcache install` to filter with `Spec` matching instead of using `Arch`.
2020-08-01architecture: make it easier to get a Spec for the default archTodd Gamblin1-2/+15
- [x] Make it easier to get a `Spec` with a proper `ArchSpec` from an `Arch` object via new `Arch.to_spec()` method. - [x] Pull `spack.architecture.default_arch()` out of `spack.architecture.sys_type()` so we can get an `Arch` instead of a string.
2020-07-31Move Python 2.6 unit tests to Github Actions (#17279)Massimiliano Culpo3-18/+38
* Run Python2.6 unit tests on Github Actions * Skip url tests on Python 2.6 to reduce waiting times * Skip foreground background tests on Python 2.6 to reduce waiting times * Removed references to Travis in the documentation * Deleted install_patchelf.sh (can be installed from repo on CentOS 6)
2020-07-28Merge tag 'v0.15.3' into developTodd Gamblin3-5/+10
2020-07-28bump version number for 0.15.3Todd Gamblin3-5/+10
2020-07-27bugfix: allow relative view paths (#17721)Greg Becker1-14/+28
Relative paths in views have been broken since #17608 or earlier. - [x] Fix by passing base path of the environment into the `ViewDescriptor`. Relative paths are calculated from this path.
2020-07-27bugfix: allow relative view paths (#17721)Greg Becker1-14/+28
Relative paths in views have been broken since #17608 or earlier. - [x] Fix by passing base path of the environment into the `ViewDescriptor`. Relative paths are calculated from this path.
2020-07-27Relocation of sbang needs to be done when the spack prefix changes even if ↵Patrick Gartung2-4/+17
the install tree has not changed. (#17455)
2020-07-27Relocate rpaths for all binaries, then do text bin replacement if the rpaths ↵Patrick Gartung1-7/+10
still exist after running patchelf/otool (#17418)
2020-07-26bugfix: don't redundantly print ChildErrors (#17709)Todd Gamblin2-5/+12
A bug was introduced in #13100 where ChildErrors would be redundantly printed when raised during a build. We should eventually revisit error handling in builds and figure out what the right separation of responsibilities is for distributed builds, but for now just skip printing. - [x] SpackErrors were designed to be printed by the forked process, not by the parent, so check if they've already been printed. - [x] update tests
2020-07-26bugfix: don't redundantly print ChildErrors (#17709)Todd Gamblin2-5/+12
A bug was introduced in #13100 where ChildErrors would be redundantly printed when raised during a build. We should eventually revisit error handling in builds and figure out what the right separation of responsibilities is for distributed builds, but for now just skip printing. - [x] SpackErrors were designed to be printed by the forked process, not by the parent, so check if they've already been printed. - [x] update tests
2020-07-24Relax architecture compatibility check (#15972)Dennis Klein2-8/+77
* Relax architecture compatibility check * Add test coverage for the spack.abi module
2020-07-24spack help --spec: add compiler flags (#17584)Adam J. Stewart1-0/+4
2020-07-24Initialize new_specs in Environment.remove() (#17592)Dmitriy1-0/+1
2020-07-23Merge tag 'v0.15.2' into developGregory Becker3-6/+10
2020-07-23bump version number for 0.15.2Gregory Becker3-6/+10
2020-07-23Revert "Add libglvnd packages/Add EGL support (#14572)" (#17682)Chuck Atkins1-94/+0
This reverts commit 573489db710c6fd315170a45d6c609db2e30e5e4.
2020-07-23cray: detect shasta os properly (#17467)Greg Becker2-1/+4
Fixes #17299 Cray Shasta systems appear to use an unmodified Sles or other Linux operating system on the backend (like Cray "Cluster" systems and unlike Cray "XC40" systems that use CNL). This updates the CNL version detection to properly note that this is the underlying OS instead of CNL and delegate to LinuxDistro.