summaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)AuthorFilesLines
2023-05-25Windows: fix "spack build-env" (#37923)John W. Parent3-3/+21
"spack build-env" was not generating proper environment variable definitions on Windows; this commit updates the generated commands to succeed with batch/PowerShell.
2023-05-25Bugfix/tests: write not append stand-alone test status (#37841)Tamara Dahlgren2-1/+26
2023-05-24bugfix: env concretize after remove (#37877)Greg Becker2-0/+27
2023-05-24spack remove: fix traversal when user specs intersect (#37882)Harmen Stoppels1-21/+20
drop unnecessary double loop over the matching user specs.
2023-05-23Remove myself as maintainer of R packages (#37859)Glenn Johnson1-3/+1
* Remove myself as maintainer of R packages I will no longer have the time to properly maintain these packages. * fix flake8 test for import
2023-05-22deleted package.py better error message (#37814)simonleary-umass-edu1-1/+1
adds the namespace to the exception object's string representation
2023-05-19spack env create: generate a view when newly created env has concrete specs ↵Harmen Stoppels2-1/+23
(#37799)
2023-05-19archspec: fix entry in the JSON file (#37793)Massimiliano Culpo2-2/+2
2023-05-19lmod: allow core compiler to be specified with a version range (#37789)Massimiliano Culpo5-22/+48
Use CompilerSpec with satisfies instead of string equality tests Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
2023-05-19compiler specs: do not print '@=' when clear from context (#37787)Greg Becker4-12/+22
Ensure that spack compiler add/find/list and lists of concrete specs print the compiler effectively as {compiler.name}{@compiler.version}. Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
2023-05-18Remove references to gmake executable, only use make (#37280)Dom Heinzeller2-2/+0
2023-05-18Bump Spack version on develop to 0.21.0.dev0 (#37760)Massimiliano Culpo1-1/+1
2023-05-18Bugfix: allow preferred new versions from externals (#37747)Peter Scheibel2-92/+126
2023-05-17maintainers: switch from list to directive (#37752)Tamara Dahlgren4-1195/+1284
2023-05-17Limit deepcopy to just the initial "all" section (#37718)Massimiliano Culpo1-12/+7
Modifications: - [x] Limit the scope of the deepcopy when initializing module file writers
2023-05-17gitlab ci: no copy-only pipelines w/ deprecated config (#37720)Scott Wittenburg1-6/+22
Make it clear that copy-only pipelines are not supported while still using the deprecated ci config format. Also ensure that the deprecated stack does not fail on spack pipelines for tags.
2023-05-17spack test: fix stand-alone test suite status reporting (#37602)Tamara Dahlgren4-40/+187
* Fix reporting of packageless specs as having no tests * Add test_test_output_multiple_specs with update to simple-standalone-test (and tests) * Refactored test status summary; added more tests or checks
2023-05-17Add recently added Spack Docker Images to documentation (#37732)Yoshiaki Senda1-0/+20
Signed-off-by: Yoshiaki Senda <yoshiaki@live.it>
2023-05-17Fix `spack find` not able to display version ranges in compilers (#37715)Massimiliano Culpo2-1/+16
2023-05-16Windows: fix MSVC version handling (#37711)John W. Parent1-2/+2
MSVC compiler logic was using string parsing to extract version from compiler spec, which was fragile. This broke in #37572, so has been fixed and made more robust by using attribute access.
2023-05-16Requirements and preferences should not define (non-git) versions (#37687)Peter Scheibel4-9/+174
Ensure that requirements `packages:*:require:@x` and preferences `packages:*:version:[x]` fail concretization when no version defined in the package satisfies `x`. This always holds except for git versions -- they are defined on the fly.
2023-05-16check_modules_set_name: do not check for "enable" key (#37701)Harmen Stoppels2-14/+46
2023-05-16unify: when_possible and unify: true -- Bugfix for error in 37438 (#37681)Greg Becker1-6/+15
Two bugs came in from #37438 1. `unify: when_possible` was broken, because of an incorrect assertion. abstract/concrete spec pairs were compared against the results that were in the process of being computed, rather than against the previous results. 2. `unify: true` had an ordering bug that could mix the association between abstract and concrete specs - [x] 1 is resolved by creating a lookup from old concrete specs to old abstract specs, and we use that to associate the "new" concrete specs that happen to be the old ones with their abstract specs (since those are stripped out for concretization - [x] 2 is resolved by combining the new and old abstract as lists instead of combining them as sets. This is important because `set() | set()` does not make any ordering promises, even though set ordering is otherwise guaranteed in `python@3.7:`
2023-05-15Improve package source code context display on error (#37655)Carson Woods2-12/+22
Spack displays package code context when it shouldn't (e.g., on `FetchError`s) and doesn't display it when it should (e.g., when errors occur in builder classes. The line attribution can sometimes be off by one, as well. - [x] Display package context when errors occur in a subclass of `PackageBase` - [x] Display package context when errors occur in a subclass of `BaseBuilder` - [x] Do not display package context when errors occur in `PackageBase`, `BaseBuilder` or other core code that is not in a `package.py` file. - [x] Fix off-by-one error for core code (don't subtract one from the line number *unless* it's in an actual `package.py` file. --------- Co-authored-by: Todd Gamblin <tgamblin@llnl.gov>
2023-05-15bugfix: allow reuse of packages from foreign namespacesTodd Gamblin1-5/+19
We currently throw a nasty error if you try to reuse packages from some other namespace (e.g., OLCF), but we should be able to reuse patched local versions of builtin packages. Right now the only obstacle to that is that we try to look up virtual info for unknown namespaces, and we can't get the package from the repo to do that. We *can* assume that a package with a known namespace is similar, and that its virtual provider information is reasonably accurate, so we now do that. This isn't 100% accurate, but neither is relying on the package itself, as it may have gone out of date. The real solution here is virtual edge information, but this is a stopgap until we have that.
2023-05-15bugfix: don't look up virtual information for unknown packagesTodd Gamblin1-3/+14
`spec_clauses()` attempts to look up package information for concrete specs in order to determine which virtuals they may provide. This fails for renamed/deleted dependencies of buildcaches and installed packages. This will eventually be fixed by #35258, which adds virtual information on edges, but we need a workaround to make older buildcaches usable. - [x] make an exception for renamed packages and omit their virtual constraints - [x] add a note that this will be solved by adding virtuals to edges
2023-05-15bugfix: don't look up patches from packages for concrete specsTodd Gamblin1-3/+3
The concretizer can fail with `reuse:true` if a buildcache or installation contains a package with a dependency that has been renamed or deleted in the main repo (e.g., `netcdf` was refactored to `netcdf-c`, `netcdf-fortran`, etc., but there are still binary packages with dependencies called `netcdf`). We should still be able to install things for which we are missing `package.py` files. `Spec.inject_patches_variant()` was failing this requirement by attempting to look up the package class for concrete specs. This isn't needed -- we can skip it. - [x] swap two conditions in `Spec.inject_patches_variant()`
2023-05-15Bump tutorial command (#37674)Harmen Stoppels1-1/+1
2023-05-15`spack find`: get rid of @= in arch/compiler headers (#37672)Todd Gamblin1-1/+1
The @= in `spack find` output adds a bit of noise. Remove it as we did for `spack spec` and `spack concretize`. This modifies display_specs so it actually covers other places we use that routine, as well, e.g., `spack buildcache list`. before: ``` -- linux-ubuntu20.04-aarch64 / gcc@=11.1.0 ----------------------- ofdlcpi libpressio@0.88.0 ``` after: ``` -- linux-ubuntu20.04-aarch64 / gcc@11.1.0 ----------------------- ofdlcpi libpressio@0.88.0 ```
2023-05-14concretizer: don't change concrete environments without `--force` (#37438)Greg Becker3-32/+71
If a user does not explicitly `--force` the concretization of an entire environment, Spack will try to reuse the concrete specs that are already in the lockfile. --------- Co-authored-by: becker33 <becker33@users.noreply.github.com> Co-authored-by: Todd Gamblin <tgamblin@llnl.gov>
2023-05-13`spack spec`: remove noisy `@=` from output (#37663)Todd Gamblin5-21/+39
@= is accurate, but noisy. Other UI commands tend not to print the redundant `@=` for known concrete versions; make `spack spec` consistent with them.
2023-05-12gitlab ci: release fixes and improvements (#37601)Scott Wittenburg2-4/+21
* gitlab ci: release fixes and improvements - use rules to reduce boilerplate in .gitlab-ci.yml - support copy-only pipeline jobs - make pipelines for release branches rebuild everything - make pipelines for protected tags copy-only * gitlab ci: remove url changes used in testing * gitlab ci: tag mirrors need public key Make sure that mirrors associated with release branches and tags contain the public key needed to verify the signed binaries. This also ensures that when stack-specific mirror contents are copied to the root, the root mirror has the public key as well. * review: be more specific about tags, curl flags * Make the check in ci.yaml consistent with the .gitlab-ci.yml --------- Co-authored-by: Ryan Krattiger <ryan.krattiger@kitware.com>
2023-05-12Allow buildcache specs to be referenced by hash (#35042)Nathan Hanford8-93/+256
Currently, specs on buildcache mirrors must be referenced by their full description. This PR allows buildcache specs to be referenced by their hashes, rather than their full description. ### How it works Hash resolution has been moved from `SpecParser` into `Spec`, and now includes the ability to execute a `BinaryCacheQuery` after checking the local store, but before concluding that the hash doesn't exist. ### Side-effects of Proposed Changes Failures will take longer when nonexistent hashes are parsed, as mirrors will now be scanned. ### Other Changes - `BinaryCacheIndex.update` has been modified to fail appropriately only when mirrors have been configured. - Tests of hash failures have been updated to use `mutable_empty_config` so they don't needlessly search mirrors. - Documentation has been clarified for `BinaryCacheQuery`, and more documentation has been added to the hash resolution functions added to `Spec`.
2023-05-12Update archspec to v0.2.1 (#37633)Massimiliano Culpo2-4/+14
2023-05-12Fix logic in setting oneapi microarchitecture flags (#37634)Robert Cohn1-2/+4
2023-05-12Improve error message for buildcaches (#37626)Massimiliano Culpo2-6/+23
2023-05-12Improve error messages when Spack finds a too new DB / lockfile (#37614)Massimiliano Culpo4-10/+56
This PR ensures that we'll get a comprehensible error message whenever an old version of Spack tries to use a DB or a lockfile that is "too new". * Fix error message when using a too new DB * Add a unit-test to ensure we have a comprehensible error message
2023-05-11Environments: store spack version/commit in spack.lock (#32801)Tamara Dahlgren4-25/+61
Add a section to the lock file to track the Spack version/commit that produced an environment. This should (eventually) enhance reproducibility, though we do not currently do anything with the information. It just adds to provenance at the moment. Changes include: - [x] adding the version/commit to `spack.lock` - [x] refactor `spack.main.get_version() - [x] fix a couple of environment lock file-related typos
2023-05-11Allow using -j to control the parallelism of concretization (#37608)Massimiliano Culpo2-1/+5
fixes #29464 This PR allows to use ``` $ spack concretize -j X ``` to set a cap on the parallelism of concretization from the command line
2023-05-11lmod: fix CompilerSpec concrete version / range (#37604)Harmen Stoppels2-3/+3
2023-05-11Improve the message for errors in package recipes (#37589)Massimiliano Culpo1-0/+3
fixes #30355
2023-05-11Improve error message for missing "command" entry in containerize (#37590)Massimiliano Culpo1-4/+25
fixes #21242
2023-05-11Allow clingo to enforce flags when they appear in requirements (#37584)Peter Scheibel3-3/+37
Flags are encoded differently from other variants, and they need a choice rule to ensure clingo has a choice to impose (or not) a constraint.
2023-05-10ci: remove --mirror-url flag (#37457)Harmen Stoppels2-8/+4
The flags --mirror-name / --mirror-url / --directory were deprecated in favor of just passing a positional name, url or directory, and letting spack figure it out. --------- Co-authored-by: Scott Wittenburg <scott.wittenburg@kitware.com>
2023-05-10Windows: Fix external detection for service accounts (#37293)John W. Parent1-2/+4
Prior to this PR, the HOMEDRIVE environment variable was used to detect what drive we are operating in. This variable is not available for service account logins (like what is used for CI), so switch to extracting the drive from PROGRAMFILES (which is more-widely defined).
2023-05-10Windows: prefer Python decompression support (#36507)John W. Parent2-113/+257
On Windows, several commonly available system tools for decompression are unreliable (gz/bz2/xz). This commit refactors `decompressor_for` to call out to a Windows or Unix-specific method: * The decompressor_for_nix method behaves the same as before and generally treats the Python/system support options for decompression as interchangeable (although avoids using Python's built-in tar support since that has had issues with permissions). * The decompressor_for_win method can only use Python support for gz/bz2/xz, although for a tar.gz it does use system support for untar (after the decompression step). .zip uses the system tar utility, and .Z depends on external support (i.e. that the user has installed 7zip). A naming scheme has been introduced for the various _decompression methods: * _system_gunzip means to use a system tool (and fail if it's not available) * _py_gunzip means to use Python's built-in support for decompressing .gzip files (and fail if it's not available) * _gunzip is a method that can do either
2023-05-10Fix compiler version issues (concrete vs range) (#37572)Harmen Stoppels3-13/+15
2023-05-10cuda: add versions 12.0.1, 12.1.0 and 12.1.1 (#37083)matteo-chesi1-1/+2
2023-05-10New option "--first" for "spack location" (#36283)G-Ragghianti2-1/+18
2023-05-10Create include/lib in prefix for oneapi packages (#37552)Robert Cohn1-0/+28