summaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)AuthorFilesLines
2022-08-11Don't set `LD_LIBRARY_PATH` by default on Linux (#28354)Harmen Stoppels4-15/+26
`LD_LIBRARY_PATH` can break system executables (e.g., when an enviornment is loaded) and isn't necessary thanks to `RPATH`s. Packages that require `LD_LIBRARY_PATH` can set this in `setup_run_environment`. - [x] Prefix inspections no longer set `LD_LIBRARY_PATH` by default - [x] Document changes and workarounds for people who want `LD_LIBRARY_PATH`
2022-08-11Add missing info to diagnostic for circular provides (#32027)Chris Green1-1/+1
2022-08-11info: properly report default when for overridden variants (#32040)Tamara Dahlgren1-4/+2
2022-08-10Update tests so /tmp/store can be accessed (#32003)Richarda Butler2-13/+14
2022-08-10Patch /usr/bin/file to file when on nixos (#30718)Mikael Simberg1-0/+9
These changes make many packages build on nixos where nearly nothing comes from /bin or /usr/bin (the only things in "system locations" are /bin/sh and /usr/bin/env, all the rest is found through PATH). Many configuration scripts hardcode /usr/bin/file instead of using the one from PATH. This patches them to use file from PATH.
2022-08-10core: add a helpful long message for UnknownPackageError (#31996)Seth R. Johnson1-0/+2
``` Error: Package 'armpl' not found. ``` is pretty useless after an upgrade unless you're a spack pro. I've recently hit this on multiple machines. See https://github.com/spack/spack/issues/31453 , https://github.com/spack/spack/issues/31489 .
2022-08-10modules: add missing Python imports (#32012)Harmen Stoppels2-0/+4
2022-08-09Reduce installation noise: filter path padding and make some details debug ↵Tamara Dahlgren5-14/+61
level 2 (#31998)
2022-08-09PythonPackage: add --config-settings support (#31823)Adam J. Stewart2-4/+91
2022-08-09Add base class for directory visitor (#32008)Harmen Stoppels3-31/+103
2022-08-09Update release procedure, keep CHANGELOG up-to-date (#31969)Massimiliano Culpo1-5/+16
Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
2022-08-05spack mirror: skip non-concretizable specs (#31897)Massimiliano Culpo2-2/+38
fixes #31736 Catch errors when concretizing specs and report them as debug messages. The corresponding spec is skipped. Co-authored-by: Greg Becker <becker33@llnl.gov>
2022-08-05Refactor `cmd/install.py` for better readability (#31936)Massimiliano Culpo1-234/+252
* Extracted two functions in cmd/install.py * Extracted a function to perform installation from the active environment * Rename a few functions, remove args from their arguments * Rework conditional in install_from_active_environment to reduce nesting in the function * Extract functions to parsespecs from cli and files * Extract functions to getuser confirmation for overwrite * Extract functions to install specs inside and outside environments * Rename a couple of functions * Fix outdated comment * Add missing imports * Split conditional to dedent one level * Invert check and exit early to dedent one level when requiring user confirmation
2022-08-05Fix doc format for code blocks: GitRef versions (#31937)psakievich1-2/+2
Rendering was not pretty using `console` from #31914
2022-08-04Move type hint to satisfy Python 3.6, 3.7 interpreters (#31932)Chris Green1-2/+2
2022-08-04Add documentation for git refs as versions (#31914)psakievich3-1/+133
* document git commit versions Include documentation for manually specifying associated known version * document spack develop command Co-authorerd-by: psakievich <psakiev@sandia.gov> Co-authored-by: Gregory Becker <becker33@llnl.gov> Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
2022-08-04Git Ref versions can be paired to defined versions in the spec (#30998)psakievich9-20/+145
The current use of git ref's as a version requires a search algorithm to pick the right matching version based on the tags in the git history of the package. This is less than ideal for the use case where users already know the specific version they want the git ref to be associated with. This PR makes a new version syntax [package]@[ref]=[version] to allow the users to specify the exact hash they wish to use.
2022-08-04Deprecate support for Python 3.5 (by removing it from CI) (#31908)Massimiliano Culpo2-2/+2
* Deprecate support for Python 3.5 (by removing it from CI) * Restore Python 3.9
2022-08-03asp: refactor low level API to permit the injection of configurationMassimiliano Culpo4-77/+78
This allows writing extension commands that can benchmark different configurations in clingo, or try different configurations for a single test.
2022-08-03Match documentation of spack create with actual behavior. (#31892)dunatotatos1-1/+1
2022-08-02spack ci rebuild: Don't install in a login shell (#31771)Jonathon Anderson1-3/+2
On some systems the shell in login mode wipes important parts of the environment, such as PATH. This causes the build to fail since it can't find `spack`. For better robustness, don't use a login shell. In a full CI job the final spack install is run in an environment formed by scripts running in this order: export AWS_SECRET=... # 1. Load environment from GitLab project variables source spack/share/spack/setup-env.sh # 2. Load Spack into the environment (PATH) spack env activate -V concrete_env # 3. Activate the concrete environment source /etc/profile # 4. Bash login shell (from -l) spack install ... Whereas when a user launches their own container with (docker|podman) run -it, they end up running spack install in an environment formed in this order: source /etc/bash.bashrc # (not 4). Bash interactive shell (default with TTY) export AWS_SECRET=... #~1. Manually load environment from GitLab project variables source spack/share/spack/setup-env.sh # 2. Load Spack into the environment (PATH) spack env activate -V concrete_env # 3. Activate the concrete environment spack install ... The big problem being that (4) has a completely different position and content (on Leap 15 and possibly other containers). So in context, this PR removes (4) from the CI job case, leaving us with the simpler: export AWS_SECRET=... # 1. Load environment from GitLab project variables source spack/share/spack/setup-env.sh # 2. Load Spack into the environment (PATH) spack env activate -V concrete_env # 3. Activate the concrete environment spack install ...
2022-08-02Optimize reuse from buildcaches (#30806)Massimiliano Culpo2-11/+13
* database: don't sort on return from query_local * ASP-based solver: don't build the hash-lookup dictionary twice Building this dictionary twice and traversing all the specs might be time-consuming for large buildcaches.
2022-08-02Style fixesMassimiliano Culpo3-10/+11
2022-08-02Remove line that sets non-existing attribute?Massimiliano Culpo1-1/+0
2022-08-02Use __slots__ for fast attribute accessMassimiliano Culpo2-0/+12
2022-08-02Use __slots__ for fast attribute access during parsingMassimiliano Culpo2-0/+8
2022-08-02Document that reuse is higher priority than preferences in packages.yaml ↵Harmen Stoppels2-0/+35
(#31864) Resurrect Known issues, since users ask frequently about that.
2022-08-02docs: Fix outdated pre-0.18 text on build dependencies (#31860)Todd Gamblin1-5/+13
2022-08-02Add meson Python build backend (#31809)Adam J. Stewart1-36/+51
2022-08-02spack checksum: black compliance (#31851)Adam J. Stewart1-1/+1
2022-08-01Add c++14 support flag for xl compiler (#31826)Peter Scheibel1-0/+8
2022-08-01Add support for macOS Ventura (#31812)Adam J. Stewart1-0/+1
2022-08-01CUDA: add new GCC conflict (#31820)Adam J. Stewart1-0/+1
2022-07-31tests: remove old `changed_files()` testTodd Gamblin1-10/+0
This test relied on an old version of the `flake8_package` fixture that modified the spack repository, but it doesn't do that anymore. There are other tests for `changed_files()` that do a better job of mocking up a git repository with changes, so we can just delete this one.
2022-07-31style: simplify arguments with `--tool TOOL` and `--skip TOOL`Todd Gamblin2-58/+68
`spack style` tests were annoyingly brittle because we could not easily be specific about which tools to run (we had to use `--no-black`, `--no-isort`, `--no-flake8`, and `--no-mypy`). We should be able to specify what to run OR what to skip. Now you can run, e.g.: spack style --tool black,flake8 or: spack style --skip black,isort - [x] Remove `--no-black`, `--no-isort`, `--no-flake8`, and `--no-mypy` args. - [x] Add `--tool TOOL` argument. - [x] Add `--skip TOOL` argument. - [x] Allow either `--tool black --tool flake8` or `--tool black,flake8` syntax.
2022-07-31black: ensure that `spack create` templates are black-compliantTodd Gamblin2-114/+101
- [x] remove alignment spaces from tempaltes - [x] replace single with double quotes - [x] Makefile template now generates parsable code (function body is `pass` instead of just a comment) - [x] template checks now run black to check output
2022-07-31black: do not align `sha56`'s with spaces in `spack checksum` outputTodd Gamblin1-9/+1
2022-07-31black: bootstrap if black in `PATH` is too newTodd Gamblin1-4/+27
Previously we'd accept any version for bootstrapping black, but we need <= 21. - [x] modify bootstrapping code to check black version before accepting an executable from `PATH`.
2022-07-31black: add .git-blame-ignore-revs toignore black reformatting in blameTodd Gamblin1-2/+12
- [x] add `.git-blame-ignore-revs` to ignore black reformatting - [x] make `spack blame` respect `.git-blame-ignore-revs` (even if the user hasn't configured git to do so)
2022-07-31black: fix format-sensitive testsTodd Gamblin3-7/+7
Some of our tests rely on single vs. double quotes, and others rely on specific line numbers in the source. These needed fixing after the switch to Black.
2022-07-31black: reformat entire repository with blackTodd Gamblin462-35680/+36530
2022-07-31black: fix style check package and flake8 formatting for blackTodd Gamblin3-42/+33
Black will automatically fix a lot of the exceptions we previously allowed for directives, so we don't need them in our custom `flake8_formatter` anymore. - [x] remove `E501` (long line) exceptions for directives from `flake8_formatter`, as they won't help us now. - [x] Refine exceptions for long URLs in the `flake8_formatter`. - [x] Adjust the mock `flake8-package` to exhibit the exceptions we still allow. - [x] Update style tests for new `flake8-package`. - [x] Blacken style test.
2022-07-31black: clean up noqa comments from most of the codeTodd Gamblin27-71/+103
Many noqa's in the code are no longer necessary now that the column limit is 99 characters. Others can easily be eliminated, and still more can just be made more specific if they do not have to do with line length. The only E501's still in the code are in the tests for `spack.util.path` and the tests for `spack style`.
2022-07-31black: break up long strings that black cannot fixTodd Gamblin6-107/+160
2022-07-31black: configurationTodd Gamblin2-39/+56
This adds necessary configuration for flake8 and black to work together. This also sets the line length to 99, per the data here: * https://github.com/spack/spack/pull/24718#issuecomment-876933636 Given the data and the spirit of black's 88-character limit, we set the limit to 99 characters for all of Spack, because: * 99 is one less than 100, a nice round number, and all lines will fit in a 100-character wide terminal (even when the text editor puts a \ at EOL). * 99 is just past the knee the file size curve for packages, and it means that packages remain readable and not significantly longer than they are now. * It doesn't seem to hurt core -- files in core might change length by a few percent but seem like they'll be mostly the same as before -- just a bit more roomy. - [x] set line length to 99 - [x] remove most exceptions from `.flake8` and add the ones black cares about - [x] add `[tool.black]` to `pyproject.toml` - [x] make `black` run if available in `spack style --fix` Co-Authored-By: Tom Scogland <tscogland@llnl.gov>
2022-07-30MACOSX_DEPLOYMENT_TARGET: MAJOR.MINOR (#31811)Adam J. Stewart1-1/+2
2022-07-28environment.py: only install root specs explicitly (#31645)Harmen Stoppels2-3/+6
2022-07-28Fix parsing of clean_url (#31783)Stephen Sachs1-2/+2
In #31618 the idea was to determine the file extension heuristically by dropping query params etc from a url and then consider it as a file path. That broke for URLs that only have query params like http://example.com/?patch=x as it would result in empty string as basename. This PR reverts to the old behavior of saving files as ?patch=x in that case. Co-authored-by: Stephen Sachs <stesachs@amazon.com>
2022-07-26environment.py: reduce # of locks further (#31643)Harmen Stoppels2-27/+49
* environment.py: reduce # of locks further
2022-07-26containerize: fix concretization -> concretizer (#31594)Harmen Stoppels3-8/+8
* containerize: fix concretization -> concretizer * fix test