summaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)AuthorFilesLines
2023-06-15Add virtual information on DAG edges (#34821)Massimiliano Culpo18-136/+290
* DependencySpec: add virtuals attribute on edges This works for both the new and the old concretizer. Also, added type hints to involved functions. * Improve virtual reconstruction from old format * Reconstruct virtuals when reading from Cray manifest * Reconstruct virtual information on test dependencies
2023-06-14modules: use depends-on to autoload module with Lmod on Tcl (#38347)Xavier Delaruelle1-0/+27
Update Tcl modulefile template to use the `depends-on` command to autoload modules if Lmod is the current module tool. Autoloading modules with `module load` command in Tcl modulefile does not work well for Lmod at some extend. An attempt to unload then load designated module is performed each time such command is encountered. It may lead to a load storm that may not end correctly with large number of module dependencies. `depends-on` command should be used for Lmod instead of `module load`, as it checks if module is already loaded, and does not attempt to reload this module. Lua modulefile template already uses `depends_on` command to autoload dependencies. Thus it is already considered that to use Lmod with Spack, it must support `depends_on` command (version 7.6+). Environment Modules copes well with `module load` command to autoload dependencies (version 3.2+). `depends-on` command is supported starting version 5.1 (as an alias of `prereq-all` command) which was relased last year. This change introduces a test to determine if current module tool that evaluates modulefile is Lmod. If so, autoload dependencies are defined with `depends-on` command. Otherwise `module load` command is used. Test is based on `LMOD_VERSION_MAJOR` environment variable, which is set by Lmod starting version 5.1. Fixes #36764
2023-06-14build(deps): bump python-levenshtein in /lib/spack/docs (#38339)dependabot[bot]1-1/+1
Bumps [python-levenshtein](https://github.com/maxbachmann/python-Levenshtein) from 0.21.0 to 0.21.1. - [Release notes](https://github.com/maxbachmann/python-Levenshtein/releases) - [Changelog](https://github.com/maxbachmann/python-Levenshtein/blob/main/HISTORY.md) - [Commits](https://github.com/maxbachmann/python-Levenshtein/compare/v0.21.0...v0.21.1) --- updated-dependencies: - dependency-name: python-levenshtein dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-13Windows bugfix: path-to-URL conversion (#37827)Dan Lipsa2-12/+5
When interpreting local paths as relative URL endpoints, they were formatted as Windows paths on Windows (i.e. with '\'). URLs should always be POSIX-style.
2023-06-13modules: append trailing delimiter to MANPATH when set (#36678)Xavier Delaruelle3-1/+86
Update modulefile templates to append a trailing delimiter to MANPATH environment variable, if the modulefile sets it. With a trailing delimiter at ends of MANPATH's value, man will search the system man pages after searching the specific paths set. Using append-path/append_path to add this element, the module tool ensures it is appended only once. When modulefile is unloaded, the number of append attempt is decreased, thus the trailing delimiter is removed only if this number equals 0. Disclaimer: no path element should be appended to MANPATH by generated modulefiles. It should always be prepended to ensure this variable's value ends with the trailing delimiter. Fixes #11355.
2023-06-12pip is a pythonextension not a pythonpackage, and it turns out we werent ↵Peter Scheibel2-47/+46
doing our external surgery on things that inherited pythonextension (#38186)
2023-06-12buildcache: remove deprecated api (#37246)Harmen Stoppels10-347/+66
The API was deprecated in v0.20 and is slated for removal in v0.21
2023-06-12bootstrap: add minimum versions required for flake8 and pytest (#38322)Massimiliano Culpo1-2/+2
2023-06-11Fix typo in example code block (#38318)Christopher Christofi1-1/+1
2023-06-11build(deps): bump urllib3 from 2.0.2 to 2.0.3 in /lib/spack/docs (#38244)dependabot[bot]1-1/+1
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](https://github.com/urllib3/urllib3/compare/2.0.2...2.0.3) --- updated-dependencies: - dependency-name: urllib3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-11build(deps): bump sphinx-rtd-theme in /lib/spack/docs (#38245)dependabot[bot]1-1/+1
Bumps [sphinx-rtd-theme](https://github.com/readthedocs/sphinx_rtd_theme) from 1.2.1 to 1.2.2. - [Changelog](https://github.com/readthedocs/sphinx_rtd_theme/blob/master/docs/changelog.rst) - [Commits](https://github.com/readthedocs/sphinx_rtd_theme/compare/1.2.1...1.2.2) --- updated-dependencies: - dependency-name: sphinx-rtd-theme dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-09install status arg: update to default true and add inverse (#38252)Greg Becker4-5/+24
* install status arg: update to default true and add inverse * update bash completion * fix tests broken by output change
2023-06-08Forbid using `env:` as a top level environment attribute (#38199)Massimiliano Culpo10-80/+60
* Remove "env" from environment schema * Remove spack.env.schema.keys * Remove spack.environment.config_dict
2023-06-08CMake/Windows bugfix: Make CMAKE_INSTALL_PREFIX a posix path (#36842)John W. Parent1-2/+2
CMake gives off a warning when passed Windows style paths as install prefixes as the resultant path often causes invalid escape sequences.
2023-06-08Fix compiler removal from command line (#38057)Massimiliano Culpo9-251/+200
* Improve lib/spack/spack/test/cmd/compiler.py * Use "tmp_path" in the "mock_executable" fixture * Return a pathlib.Path from mock_executable * Fix mock_executable fixture on Windows "mock_gcc" was very similar to mock_executable, so use the latter to reduce code duplication * Remove wrong compiler cache, fix compiler removal fixes #37996 _CACHE_CONFIG_FILES was both unneeded and wrong, if called subsequently with different scopes. Here we remove that cache, and we fix an issue with compiler removal triggered by having the same compiler spec in multiple scopes.
2023-06-07Add documentation about package signing model (#30939)Christopher Kotfila2-0/+485
Co-authored-by: Scott Wittenburg <scott.wittenburg@kitware.com> Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
2023-06-06E4S Cray CI Stack (#37837)eugeneswalker1-1/+1
* e4s cray ci stack * e4s ci: add cray * add zen4 tag * WIP: new defintions just for cray * updates * remove ci signing job overrride, not necessary * echo $PATH and show modules loaded * add mirror * add external def for cray-libsci * comment out quantum-espresso * use /etc/protected-runner as key path * cray ci stack: do not remove tags: [spack, public] * make cray stack composable * generate job should run on public tagged runner, override default config:install_tree:root * CI: Use relative path in default script * CI: Use relative includes paths for shell runners * Use concrete_env_dir for relpath * ml-darwin-aarch64-mps: jax has bazel codesign issue --------- Co-authored-by: Scott Wittenburg <scott.wittenburg@kitware.com> Co-authored-by: Ryan Krattiger <ryan.krattiger@kitware.com>
2023-06-06CachedCMakePackage: fix bug where CMAKE_CUDA_ARCHITECTURES=none is set (#38169)Mikael Simberg1-2/+2
#37592 updated cached cmake packages to set CMAKE_CUDA_ARCHITECTURES. The condition `if archs != "none"` lead to `CMAKE_CUDA_ARCHITECTURES=none` when cuda_arch=none (incorrect check on the value of a multi-valued variant), i.e. CMAKE_CUDA_ARCHITECTURES is always set. This PR udpates the condition to if archs[0] != "none" to ensure CMAKE_CUDA_ARCHITECTURES is only set if cuda_arch is not none (which seems to be the pattern used in other packages). This does the same for HIP (although in general ROCmPackage disallows amdgpu_target=none when +rocm).
2023-06-06containers: don't install epel-release on Fedora (#37766)Jonathon Anderson2-8/+18
2023-06-05Update RtD and Sphinx configuration (#38046)Massimiliano Culpo3-42/+29
2023-06-01Memoize a few hot functions during module file generation (#37739)Massimiliano Culpo5-13/+16
2023-06-01Spec.format: print false attributes if requested (#37932)Greg Becker2-1/+2
2023-05-31CachedCMakePackage: add CUDA/HIP options and improve independent builds (#37592)Brian Van Essen1-9/+83
* Add CMake options for building with CUDA/HIP support to CachedCMakePackages (intended to reduce duplication across packages building with +hip/+cuda and using CachedCMakePackage) * Define generic variables like CMAKE_PREFIX_PATH for CachedCMakePackages (so that a user may invoke "cmake" themselves without needing to setthem on the command line). * Make `lbann` a CachedCMakePackage. Co-authored-by: Chris White <white238@llnl.gov>
2023-05-30Bugfix: cray manifest parsing regression (#37909)Tiziano Müller3-4/+18
fa7719a changed syntax for specifying exact versions, which are required for some compiler specs (including those read as part of parsing a Cray manifest). This fixes that and also makes a couple other improvements to manifest parsing. * Instantiate compiler specs with exact versions (fixes #37893) * fix slingshot network detection (CPE 22.10+ has libcxi.so in /usr/lib64) * "spack external find": add arg to ignore default dir for cray manifests
2023-05-30Simplify implementation of "get_compiler_config" (#37989)Massimiliano Culpo1-28/+18
2023-05-29Remove patchelf self-relocation (#33834)Harmen Stoppels2-43/+1
2023-05-29fix InternalConcretizerError msg (#37791)Harmen Stoppels1-6/+7
2023-05-29Bugfix/tests: add slash to test log message (#37874)Tamara Dahlgren1-1/+1
2023-05-29tests/sip: convert to new stand-alone test process (#35693)Tamara Dahlgren1-7/+10
2023-05-28modules: improve default naming scheme (#37808)Xavier Delaruelle4-38/+38
Change default naming scheme for tcl modules for a more user-friendly experience. Change from flat projection to "per software name" projection. Flat naming scheme restrains module selection capabilities. The `{name}/{version}...` scheme make possible to use user-friendly mechanisms: * implicit defaults (`module load git`) * extended default (`module load git/2`) * advanced version specifiers (`module load git@2:`)
2023-05-26CI: Use relative path in default script (#36649)kwryankrattiger1-1/+1
2023-05-25Windows MSVC: do not set sdk version if installing sdk (#37930)John W. Parent1-1/+5
Note the win-sdk package is not installable and reports an error which instructs the user how to add it. Without this fix, a (more confusing) error occurs before this message can be generated.
2023-05-25Windows: fix "spack build-env" (#37923)John W. Parent3-3/+21
"spack build-env" was not generating proper environment variable definitions on Windows; this commit updates the generated commands to succeed with batch/PowerShell.
2023-05-25Bugfix/tests: write not append stand-alone test status (#37841)Tamara Dahlgren2-1/+26
2023-05-24bugfix: env concretize after remove (#37877)Greg Becker2-0/+27
2023-05-24spack remove: fix traversal when user specs intersect (#37882)Harmen Stoppels1-21/+20
drop unnecessary double loop over the matching user specs.
2023-05-23Remove myself as maintainer of R packages (#37859)Glenn Johnson1-3/+1
* Remove myself as maintainer of R packages I will no longer have the time to properly maintain these packages. * fix flake8 test for import
2023-05-22deleted package.py better error message (#37814)simonleary-umass-edu1-1/+1
adds the namespace to the exception object's string representation
2023-05-19spack env create: generate a view when newly created env has concrete specs ↵Harmen Stoppels2-1/+23
(#37799)
2023-05-19archspec: fix entry in the JSON file (#37793)Massimiliano Culpo2-2/+2
2023-05-19lmod: allow core compiler to be specified with a version range (#37789)Massimiliano Culpo5-22/+48
Use CompilerSpec with satisfies instead of string equality tests Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
2023-05-19compiler specs: do not print '@=' when clear from context (#37787)Greg Becker4-12/+22
Ensure that spack compiler add/find/list and lists of concrete specs print the compiler effectively as {compiler.name}{@compiler.version}. Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
2023-05-18Remove references to gmake executable, only use make (#37280)Dom Heinzeller2-2/+0
2023-05-18Bump Spack version on develop to 0.21.0.dev0 (#37760)Massimiliano Culpo1-1/+1
2023-05-18Bugfix: allow preferred new versions from externals (#37747)Peter Scheibel2-92/+126
2023-05-17maintainers: switch from list to directive (#37752)Tamara Dahlgren4-1195/+1284
2023-05-17Limit deepcopy to just the initial "all" section (#37718)Massimiliano Culpo1-12/+7
Modifications: - [x] Limit the scope of the deepcopy when initializing module file writers
2023-05-17gitlab ci: no copy-only pipelines w/ deprecated config (#37720)Scott Wittenburg1-6/+22
Make it clear that copy-only pipelines are not supported while still using the deprecated ci config format. Also ensure that the deprecated stack does not fail on spack pipelines for tags.
2023-05-17spack test: fix stand-alone test suite status reporting (#37602)Tamara Dahlgren4-40/+187
* Fix reporting of packageless specs as having no tests * Add test_test_output_multiple_specs with update to simple-standalone-test (and tests) * Refactored test status summary; added more tests or checks
2023-05-17Add recently added Spack Docker Images to documentation (#37732)Yoshiaki Senda1-0/+20
Signed-off-by: Yoshiaki Senda <yoshiaki@live.it>