1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
|
# Copyright 2013-2022 Lawrence Livermore National Security, LLC and other
# Spack Project Developers. See the top-level COPYRIGHT file for details.
#
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
import sys
import pytest
import spack.directives
import spack.error
from spack.error import SpecError, UnsatisfiableSpecError
from spack.spec import (
Spec,
SpecFormatSigilError,
SpecFormatStringError,
UnconstrainableDependencySpecError,
UnsupportedCompilerError,
)
from spack.variant import (
InvalidVariantValueError,
MultipleValuesInExclusiveVariantError,
UnknownVariantError,
substitute_abstract_variants,
)
def make_spec(spec_like, concrete):
if isinstance(spec_like, Spec):
return spec_like
spec = Spec(spec_like)
if concrete:
spec._mark_concrete()
substitute_abstract_variants(spec)
return spec
def _specify(spec_like):
if isinstance(spec_like, Spec):
return spec_like
return Spec(spec_like)
def check_satisfies(target_spec, constraint_spec, target_concrete=False):
target = make_spec(target_spec, target_concrete)
constraint = _specify(constraint_spec)
# Satisfies is one-directional.
assert target.satisfies(constraint)
# If target satisfies constraint, then we should be able to constrain
# constraint by target. Reverse is not always true.
constraint.copy().constrain(target)
def check_unsatisfiable(target_spec, constraint_spec, target_concrete=False):
target = make_spec(target_spec, target_concrete)
constraint = _specify(constraint_spec)
assert not target.satisfies(constraint)
with pytest.raises(UnsatisfiableSpecError):
constraint.copy().constrain(target)
def check_constrain(expected, spec, constraint):
exp = Spec(expected)
spec = Spec(spec)
constraint = Spec(constraint)
spec.constrain(constraint)
assert exp == spec
def check_constrain_changed(spec, constraint):
spec = Spec(spec)
assert spec.constrain(constraint)
def check_constrain_not_changed(spec, constraint):
spec = Spec(spec)
assert not spec.constrain(constraint)
def check_invalid_constraint(spec, constraint):
spec = Spec(spec)
constraint = Spec(constraint)
with pytest.raises((UnsatisfiableSpecError, UnconstrainableDependencySpecError)):
spec.constrain(constraint)
@pytest.mark.usefixtures("config", "mock_packages")
class TestSpecSematics(object):
"""This tests satisfies(), constrain() and other semantic operations
on specs.
"""
def test_satisfies(self):
check_satisfies("libelf@0.8.13", "@0:1")
check_satisfies("libdwarf^libelf@0.8.13", "^libelf@0:1")
def test_empty_satisfies(self):
# Basic satisfaction
check_satisfies("libelf", Spec())
check_satisfies("libdwarf", Spec())
check_satisfies("%intel", Spec())
check_satisfies("^mpi", Spec())
check_satisfies("+debug", Spec())
check_satisfies("@3:", Spec())
# Concrete (strict) satisfaction
check_satisfies("libelf", Spec(), True)
check_satisfies("libdwarf", Spec(), True)
check_satisfies("%intel", Spec(), True)
check_satisfies("^mpi", Spec(), True)
# TODO: Variants can't be called concrete while anonymous
# check_satisfies('+debug', Spec(), True)
check_satisfies("@3:", Spec(), True)
# Reverse (non-strict) satisfaction
check_satisfies(Spec(), "libelf")
check_satisfies(Spec(), "libdwarf")
check_satisfies(Spec(), "%intel")
check_satisfies(Spec(), "^mpi")
# TODO: Variant matching is auto-strict
# we should rethink this
# check_satisfies(Spec(), '+debug')
check_satisfies(Spec(), "@3:")
def test_satisfies_namespace(self):
check_satisfies("builtin.mpich", "mpich")
check_satisfies("builtin.mock.mpich", "mpich")
# TODO: only works for deps now, but shouldn't we allow for root spec?
# check_satisfies('builtin.mock.mpich', 'mpi')
check_satisfies("builtin.mock.mpich", "builtin.mock.mpich")
check_unsatisfiable("builtin.mock.mpich", "builtin.mpich")
def test_satisfies_namespaced_dep(self):
"""Ensure spec from same or unspecified namespace satisfies namespace
constraint."""
check_satisfies("mpileaks ^builtin.mock.mpich", "^mpich")
check_satisfies("mpileaks ^builtin.mock.mpich", "^mpi")
check_satisfies("mpileaks ^builtin.mock.mpich", "^builtin.mock.mpich")
check_unsatisfiable("mpileaks ^builtin.mock.mpich", "^builtin.mpich")
def test_satisfies_compiler(self):
check_satisfies("foo%gcc", "%gcc")
check_satisfies("foo%intel", "%intel")
check_unsatisfiable("foo%intel", "%gcc")
check_unsatisfiable("foo%intel", "%pgi")
def test_satisfies_compiler_version(self):
check_satisfies("foo%gcc", "%gcc@4.7.2")
check_satisfies("foo%intel", "%intel@4.7.2")
check_satisfies("foo%pgi@4.5", "%pgi@4.4:4.6")
check_satisfies("foo@2.0%pgi@4.5", "@1:3%pgi@4.4:4.6")
check_unsatisfiable("foo%pgi@4.3", "%pgi@4.4:4.6")
check_unsatisfiable("foo@4.0%pgi", "@1:3%pgi")
check_unsatisfiable("foo@4.0%pgi@4.5", "@1:3%pgi@4.4:4.6")
check_satisfies("foo %gcc@4.7.3", "%gcc@4.7")
check_unsatisfiable("foo %gcc@4.7", "%gcc@4.7.3")
def test_satisfies_architecture(self):
check_satisfies("foo platform=test", "platform=test")
check_satisfies("foo platform=linux", "platform=linux")
check_satisfies("foo platform=test", "platform=test target=frontend")
check_satisfies("foo platform=test", "platform=test os=frontend target=frontend")
check_satisfies("foo platform=test os=frontend target=frontend", "platform=test")
check_unsatisfiable("foo platform=linux", "platform=test os=redhat6 target=x86")
check_unsatisfiable("foo os=redhat6", "platform=test os=debian6 target=x86_64")
check_unsatisfiable("foo target=x86_64", "platform=test os=redhat6 target=x86")
check_satisfies("foo arch=test-None-None", "platform=test")
check_satisfies("foo arch=test-None-frontend", "platform=test target=frontend")
check_satisfies(
"foo arch=test-frontend-frontend", "platform=test os=frontend target=frontend"
)
check_satisfies("foo arch=test-frontend-frontend", "platform=test")
check_unsatisfiable(
"foo arch=test-frontend-frontend", "platform=test os=frontend target=backend"
)
check_satisfies(
"foo platform=test target=frontend os=frontend",
"platform=test target=frontend os=frontend",
)
check_satisfies(
"foo platform=test target=backend os=backend",
"platform=test target=backend os=backend",
)
check_satisfies(
"foo platform=test target=default_target os=default_os", "platform=test os=default_os"
)
check_unsatisfiable(
"foo platform=test target=x86 os=redhat6", "platform=linux target=x86 os=redhat6"
)
def test_satisfies_dependencies(self):
check_satisfies("mpileaks^mpich", "^mpich")
check_satisfies("mpileaks^zmpi", "^zmpi")
check_unsatisfiable("mpileaks^mpich", "^zmpi")
check_unsatisfiable("mpileaks^zmpi", "^mpich")
def test_satisfies_dependency_versions(self):
check_satisfies("mpileaks^mpich@2.0", "^mpich@1:3")
check_unsatisfiable("mpileaks^mpich@1.2", "^mpich@2.0")
check_satisfies("mpileaks^mpich@2.0^callpath@1.5", "^mpich@1:3^callpath@1.4:1.6")
check_unsatisfiable("mpileaks^mpich@4.0^callpath@1.5", "^mpich@1:3^callpath@1.4:1.6")
check_unsatisfiable("mpileaks^mpich@2.0^callpath@1.7", "^mpich@1:3^callpath@1.4:1.6")
check_unsatisfiable("mpileaks^mpich@4.0^callpath@1.7", "^mpich@1:3^callpath@1.4:1.6")
def test_satisfies_virtual_dependencies(self):
check_satisfies("mpileaks^mpi", "^mpi")
check_satisfies("mpileaks^mpi", "^mpich")
check_satisfies("mpileaks^mpi", "^zmpi")
check_unsatisfiable("mpileaks^mpich", "^zmpi")
def test_satisfies_virtual_dependency_versions(self):
check_satisfies("mpileaks^mpi@1.5", "^mpi@1.2:1.6")
check_unsatisfiable("mpileaks^mpi@3", "^mpi@1.2:1.6")
check_satisfies("mpileaks^mpi@2:", "^mpich")
check_satisfies("mpileaks^mpi@2:", "^mpich@3.0.4")
check_satisfies("mpileaks^mpi@2:", "^mpich2@1.4")
check_satisfies("mpileaks^mpi@1:", "^mpich2")
check_satisfies("mpileaks^mpi@2:", "^mpich2")
check_unsatisfiable("mpileaks^mpi@3:", "^mpich2@1.4")
check_unsatisfiable("mpileaks^mpi@3:", "^mpich2")
check_unsatisfiable("mpileaks^mpi@3:", "^mpich@1.0")
def test_satisfies_matching_variant(self):
check_satisfies("mpich+foo", "mpich+foo")
check_satisfies("mpich~foo", "mpich~foo")
check_satisfies("mpich foo=1", "mpich foo=1")
# confirm that synonymous syntax works correctly
check_satisfies("mpich+foo", "mpich foo=True")
check_satisfies("mpich foo=true", "mpich+foo")
check_satisfies("mpich~foo", "mpich foo=FALSE")
check_satisfies("mpich foo=False", "mpich~foo")
check_satisfies("mpich foo=*", "mpich~foo")
check_satisfies("mpich +foo", "mpich foo=*")
def test_satisfies_multi_value_variant(self):
# Check quoting
check_satisfies('multivalue-variant foo="bar,baz"', 'multivalue-variant foo="bar,baz"')
check_satisfies("multivalue-variant foo=bar,baz", "multivalue-variant foo=bar,baz")
check_satisfies('multivalue-variant foo="bar,baz"', "multivalue-variant foo=bar,baz")
# A more constrained spec satisfies a less constrained one
check_satisfies('multivalue-variant foo="bar,baz"', "multivalue-variant foo=*")
check_satisfies("multivalue-variant foo=*", 'multivalue-variant foo="bar,baz"')
check_satisfies('multivalue-variant foo="bar,baz"', 'multivalue-variant foo="bar"')
check_satisfies('multivalue-variant foo="bar,baz"', 'multivalue-variant foo="baz"')
check_satisfies(
'multivalue-variant foo="bar,baz,barbaz"', 'multivalue-variant foo="bar,baz"'
)
check_satisfies('multivalue-variant foo="bar,baz"', 'foo="bar,baz"')
check_satisfies('multivalue-variant foo="bar,baz"', 'foo="bar"')
def test_satisfies_single_valued_variant(self):
"""Tests that the case reported in
https://github.com/spack/spack/pull/2386#issuecomment-282147639
is handled correctly.
"""
a = Spec("a foobar=bar")
a.concretize()
assert a.satisfies("foobar=bar")
assert a.satisfies("foobar=*")
# Assert that an autospec generated from a literal
# gives the right result for a single valued variant
assert "foobar=bar" in a
assert "foobar=baz" not in a
assert "foobar=fee" not in a
# ... and for a multi valued variant
assert "foo=bar" in a
# Check that conditional dependencies are treated correctly
assert "^b" in a
def test_unsatisfied_single_valued_variant(self):
a = Spec("a foobar=baz")
a.concretize()
assert "^b" not in a
mv = Spec("multivalue-variant")
mv.concretize()
assert "a@1.0" not in mv
def test_indirect_unsatisfied_single_valued_variant(self):
spec = Spec("singlevalue-variant-dependent")
spec.concretize()
assert "a@1.0" not in spec
def test_unsatisfiable_multi_value_variant(self):
# Semantics for a multi-valued variant is different
# Depending on whether the spec is concrete or not
a = make_spec('multivalue-variant foo="bar"', concrete=True)
spec_str = 'multivalue-variant foo="bar,baz"'
b = Spec(spec_str)
assert not a.satisfies(b)
assert not a.satisfies(spec_str)
# A concrete spec cannot be constrained further
with pytest.raises(UnsatisfiableSpecError):
a.constrain(b)
a = Spec('multivalue-variant foo="bar"')
spec_str = 'multivalue-variant foo="bar,baz"'
b = Spec(spec_str)
# The specs are abstract and they **could** be constrained
assert a.satisfies(b)
assert a.satisfies(spec_str)
# An abstract spec can instead be constrained
assert a.constrain(b)
a = make_spec('multivalue-variant foo="bar,baz"', concrete=True)
spec_str = 'multivalue-variant foo="bar,baz,quux"'
b = Spec(spec_str)
assert not a.satisfies(b)
assert not a.satisfies(spec_str)
# A concrete spec cannot be constrained further
with pytest.raises(UnsatisfiableSpecError):
a.constrain(b)
a = Spec('multivalue-variant foo="bar,baz"')
spec_str = 'multivalue-variant foo="bar,baz,quux"'
b = Spec(spec_str)
# The specs are abstract and they **could** be constrained
assert a.satisfies(b)
assert a.satisfies(spec_str)
# An abstract spec can instead be constrained
assert a.constrain(b)
# ...but will fail during concretization if there are
# values in the variant that are not allowed
with pytest.raises(InvalidVariantValueError):
a.concretize()
# This time we'll try to set a single-valued variant
a = Spec('multivalue-variant fee="bar"')
spec_str = 'multivalue-variant fee="baz"'
b = Spec(spec_str)
# The specs are abstract and they **could** be constrained,
# as before concretization I don't know which type of variant
# I have (if it is not a BV)
assert a.satisfies(b)
assert a.satisfies(spec_str)
# A variant cannot be parsed as single-valued until we try to
# concretize. This means that we can constrain the variant above
assert a.constrain(b)
# ...but will fail during concretization if there are
# multiple values set
with pytest.raises(MultipleValuesInExclusiveVariantError):
a.concretize()
def test_unsatisfiable_variant_types(self):
# These should fail due to incompatible types
# FIXME: these needs to be checked as the new relaxed
# FIXME: semantic makes them fail (constrain does not raise)
# check_unsatisfiable('multivalue-variant +foo',
# 'multivalue-variant foo="bar"')
# check_unsatisfiable('multivalue-variant ~foo',
# 'multivalue-variant foo="bar"')
check_unsatisfiable(
target_spec='multivalue-variant foo="bar"',
constraint_spec="multivalue-variant +foo",
target_concrete=True,
)
check_unsatisfiable(
target_spec='multivalue-variant foo="bar"',
constraint_spec="multivalue-variant ~foo",
target_concrete=True,
)
def test_satisfies_unconstrained_variant(self):
# only asked for mpich, no constraints. Either will do.
check_satisfies("mpich+foo", "mpich")
check_satisfies("mpich~foo", "mpich")
check_satisfies("mpich foo=1", "mpich")
def test_unsatisfiable_variants(self):
# This case is different depending on whether the specs are concrete.
# 'mpich' is not concrete:
check_satisfies("mpich", "mpich+foo", False)
check_satisfies("mpich", "mpich~foo", False)
check_satisfies("mpich", "mpich foo=1", False)
# 'mpich' is concrete:
check_unsatisfiable("mpich", "mpich+foo", True)
check_unsatisfiable("mpich", "mpich~foo", True)
check_unsatisfiable("mpich", "mpich foo=1", True)
def test_unsatisfiable_variant_mismatch(self):
# No matchi in specs
check_unsatisfiable("mpich~foo", "mpich+foo")
check_unsatisfiable("mpich+foo", "mpich~foo")
check_unsatisfiable("mpich foo=True", "mpich foo=False")
def test_satisfies_matching_compiler_flag(self):
check_satisfies('mpich cppflags="-O3"', 'mpich cppflags="-O3"')
check_satisfies('mpich cppflags="-O3 -Wall"', 'mpich cppflags="-O3 -Wall"')
def test_satisfies_unconstrained_compiler_flag(self):
# only asked for mpich, no constraints. Any will do.
check_satisfies('mpich cppflags="-O3"', "mpich")
def test_unsatisfiable_compiler_flag(self):
# This case is different depending on whether the specs are concrete.
# 'mpich' is not concrete:
check_satisfies("mpich", 'mpich cppflags="-O3"', False)
# 'mpich' is concrete:
check_unsatisfiable("mpich", 'mpich cppflags="-O3"', True)
def test_copy_satisfies_transitive(self):
spec = Spec("dttop")
spec.concretize()
copy = spec.copy()
for s in spec.traverse():
assert s.satisfies(copy[s.name])
assert copy[s.name].satisfies(s)
def test_unsatisfiable_compiler_flag_mismatch(self):
# No matchi in specs
check_unsatisfiable('mpich cppflags="-O3"', 'mpich cppflags="-O2"')
def test_satisfies_virtual(self):
# Don't use check_satisfies: it checks constrain() too, and
# you can't constrain a non-virtual by a virtual.
assert Spec("mpich").satisfies(Spec("mpi"))
assert Spec("mpich2").satisfies(Spec("mpi"))
assert Spec("zmpi").satisfies(Spec("mpi"))
def test_satisfies_virtual_dep_with_virtual_constraint(self):
"""Ensure we can satisfy virtual constraints when there are multiple
vdep providers in the specs."""
assert Spec("netlib-lapack ^openblas").satisfies("netlib-lapack ^openblas")
assert not Spec("netlib-lapack ^netlib-blas").satisfies("netlib-lapack ^openblas")
assert not Spec("netlib-lapack ^openblas").satisfies("netlib-lapack ^netlib-blas")
assert Spec("netlib-lapack ^netlib-blas").satisfies("netlib-lapack ^netlib-blas")
def test_satisfies_same_spec_with_different_hash(self):
"""Ensure that concrete specs are matched *exactly* by hash."""
s1 = Spec("mpileaks").concretized()
s2 = s1.copy()
assert s1.satisfies(s2)
assert s2.satisfies(s1)
# Simulate specs that were installed before and after a change to
# Spack's hashing algorithm. This just reverses s2's hash.
s2._hash = s1.dag_hash()[-1::-1]
assert not s1.satisfies(s2)
assert not s2.satisfies(s1)
# ========================================================================
# Indexing specs
# ========================================================================
def test_self_index(self):
s = Spec("callpath")
assert s["callpath"] == s
def test_dep_index(self):
s = Spec("callpath")
s.normalize()
assert s["callpath"] == s
assert type(s["dyninst"]) == Spec
assert type(s["libdwarf"]) == Spec
assert type(s["libelf"]) == Spec
assert type(s["mpi"]) == Spec
assert s["dyninst"].name == "dyninst"
assert s["libdwarf"].name == "libdwarf"
assert s["libelf"].name == "libelf"
assert s["mpi"].name == "mpi"
def test_spec_contains_deps(self):
s = Spec("callpath")
s.normalize()
assert "dyninst" in s
assert "libdwarf" in s
assert "libelf" in s
assert "mpi" in s
@pytest.mark.usefixtures("config")
def test_virtual_index(self):
s = Spec("callpath")
s.concretize()
s_mpich = Spec("callpath ^mpich")
s_mpich.concretize()
s_mpich2 = Spec("callpath ^mpich2")
s_mpich2.concretize()
s_zmpi = Spec("callpath ^zmpi")
s_zmpi.concretize()
assert s["mpi"].name != "mpi"
assert s_mpich["mpi"].name == "mpich"
assert s_mpich2["mpi"].name == "mpich2"
assert s_zmpi["zmpi"].name == "zmpi"
for spec in [s, s_mpich, s_mpich2, s_zmpi]:
assert "mpi" in spec
# ========================================================================
# Constraints
# ========================================================================
def test_constrain_variants(self):
check_constrain("libelf@2.1:2.5", "libelf@0:2.5", "libelf@2.1:3")
check_constrain(
"libelf@2.1:2.5%gcc@4.5:4.6", "libelf@0:2.5%gcc@2:4.6", "libelf@2.1:3%gcc@4.5:4.7"
)
check_constrain("libelf+debug+foo", "libelf+debug", "libelf+foo")
check_constrain("libelf+debug+foo", "libelf+debug", "libelf+debug+foo")
check_constrain("libelf debug=2 foo=1", "libelf debug=2", "libelf foo=1")
check_constrain("libelf debug=2 foo=1", "libelf debug=2", "libelf debug=2 foo=1")
check_constrain("libelf+debug~foo", "libelf+debug", "libelf~foo")
check_constrain("libelf+debug~foo", "libelf+debug", "libelf+debug~foo")
def test_constrain_multi_value_variant(self):
check_constrain(
'multivalue-variant foo="bar,baz"',
'multivalue-variant foo="bar"',
'multivalue-variant foo="baz"',
)
check_constrain(
'multivalue-variant foo="bar,baz,barbaz"',
'multivalue-variant foo="bar,barbaz"',
'multivalue-variant foo="baz"',
)
check_constrain("libelf foo=bar,baz", "libelf foo=bar,baz", "libelf foo=*")
check_constrain("libelf foo=bar,baz", "libelf foo=*", "libelf foo=bar,baz")
def test_constrain_compiler_flags(self):
check_constrain(
'libelf cflags="-O3" cppflags="-Wall"',
'libelf cflags="-O3"',
'libelf cppflags="-Wall"',
)
check_constrain(
'libelf cflags="-O3" cppflags="-Wall"',
'libelf cflags="-O3"',
'libelf cflags="-O3" cppflags="-Wall"',
)
def test_constrain_architecture(self):
check_constrain(
"libelf target=default_target os=default_os",
"libelf target=default_target os=default_os",
"libelf target=default_target os=default_os",
)
check_constrain(
"libelf target=default_target os=default_os",
"libelf",
"libelf target=default_target os=default_os",
)
def test_constrain_compiler(self):
check_constrain("libelf %gcc@4.4.7", "libelf %gcc@4.4.7", "libelf %gcc@4.4.7")
check_constrain("libelf %gcc@4.4.7", "libelf", "libelf %gcc@4.4.7")
def test_invalid_constraint(self):
check_invalid_constraint("libelf@0:2.0", "libelf@2.1:3")
check_invalid_constraint("libelf@0:2.5%gcc@4.8:4.9", "libelf@2.1:3%gcc@4.5:4.7")
check_invalid_constraint("libelf+debug", "libelf~debug")
check_invalid_constraint("libelf+debug~foo", "libelf+debug+foo")
check_invalid_constraint("libelf debug=True", "libelf debug=False")
check_invalid_constraint('libelf cppflags="-O3"', 'libelf cppflags="-O2"')
check_invalid_constraint("libelf platform=test target=be os=be", "libelf target=fe os=fe")
check_invalid_constraint("libdwarf", "^%gcc")
def test_constrain_changed(self):
check_constrain_changed("libelf", "@1.0")
check_constrain_changed("libelf", "@1.0:5.0")
check_constrain_changed("libelf", "%gcc")
check_constrain_changed("libelf%gcc", "%gcc@4.5")
check_constrain_changed("libelf", "+debug")
check_constrain_changed("libelf", "debug=*")
check_constrain_changed("libelf", "~debug")
check_constrain_changed("libelf", "debug=2")
check_constrain_changed("libelf", 'cppflags="-O3"')
platform = spack.platforms.host()
check_constrain_changed("libelf", "target=" + platform.target("default_target").name)
check_constrain_changed("libelf", "os=" + platform.operating_system("default_os").name)
def test_constrain_not_changed(self):
check_constrain_not_changed("libelf", "libelf")
check_constrain_not_changed("libelf@1.0", "@1.0")
check_constrain_not_changed("libelf@1.0:5.0", "@1.0:5.0")
check_constrain_not_changed("libelf%gcc", "%gcc")
check_constrain_not_changed("libelf%gcc@4.5", "%gcc@4.5")
check_constrain_not_changed("libelf+debug", "+debug")
check_constrain_not_changed("libelf~debug", "~debug")
check_constrain_not_changed("libelf debug=2", "debug=2")
check_constrain_not_changed("libelf debug=2", "debug=*")
check_constrain_not_changed('libelf cppflags="-O3"', 'cppflags="-O3"')
platform = spack.platforms.host()
default_target = platform.target("default_target").name
check_constrain_not_changed("libelf target=" + default_target, "target=" + default_target)
def test_constrain_dependency_changed(self):
check_constrain_changed("libelf^foo", "libelf^foo@1.0")
check_constrain_changed("libelf^foo", "libelf^foo@1.0:5.0")
check_constrain_changed("libelf^foo", "libelf^foo%gcc")
check_constrain_changed("libelf^foo%gcc", "libelf^foo%gcc@4.5")
check_constrain_changed("libelf^foo", "libelf^foo+debug")
check_constrain_changed("libelf^foo", "libelf^foo~debug")
check_constrain_changed("libelf", "^foo")
platform = spack.platforms.host()
default_target = platform.target("default_target").name
check_constrain_changed("libelf^foo", "libelf^foo target=" + default_target)
def test_constrain_dependency_not_changed(self):
check_constrain_not_changed("libelf^foo@1.0", "libelf^foo@1.0")
check_constrain_not_changed("libelf^foo@1.0:5.0", "libelf^foo@1.0:5.0")
check_constrain_not_changed("libelf^foo%gcc", "libelf^foo%gcc")
check_constrain_not_changed("libelf^foo%gcc@4.5", "libelf^foo%gcc@4.5")
check_constrain_not_changed("libelf^foo+debug", "libelf^foo+debug")
check_constrain_not_changed("libelf^foo~debug", "libelf^foo~debug")
check_constrain_not_changed('libelf^foo cppflags="-O3"', 'libelf^foo cppflags="-O3"')
platform = spack.platforms.host()
default_target = platform.target("default_target").name
check_constrain_not_changed(
"libelf^foo target=" + default_target, "libelf^foo target=" + default_target
)
def test_exceptional_paths_for_constructor(self):
with pytest.raises(TypeError):
Spec((1, 2))
with pytest.raises(ValueError):
Spec("")
with pytest.raises(ValueError):
Spec("libelf foo")
def test_spec_formatting(self):
spec = Spec("multivalue-variant cflags=-O2")
spec.concretize()
# Since the default is the full spec see if the string rep of
# spec is the same as the output of spec.format()
# ignoring whitespace (though should we?) and ignoring dependencies
spec_string = str(spec)
idx = spec_string.index(" ^")
assert spec_string[:idx] == spec.format().strip()
# Testing named strings ie {string} and whether we get
# the correct component
# Mixed case intentional to test both
package_segments = [
("{NAME}", "name"),
("{VERSION}", "versions"),
("{compiler}", "compiler"),
("{compiler_flags}", "compiler_flags"),
("{variants}", "variants"),
("{architecture}", "architecture"),
]
sigil_package_segments = [
("{@VERSIONS}", "@" + str(spec.version)),
("{%compiler}", "%" + str(spec.compiler)),
("{arch=architecture}", "arch=" + str(spec.architecture)),
]
compiler_segments = [("{compiler.name}", "name"), ("{compiler.version}", "versions")]
sigil_compiler_segments = [
("{%compiler.name}", "%" + spec.compiler.name),
("{@compiler.version}", "@" + str(spec.compiler.version)),
]
architecture_segments = [
("{architecture.platform}", "platform"),
("{architecture.os}", "os"),
("{architecture.target}", "target"),
]
other_segments = [
("{spack_root}", spack.paths.spack_root),
("{spack_install}", spack.store.layout.root),
("{hash:7}", spec.dag_hash(7)),
("{/hash}", "/" + spec.dag_hash()),
]
for named_str, prop in package_segments:
expected = getattr(spec, prop, "")
actual = spec.format(named_str)
assert str(expected).strip() == actual
for named_str, expected in sigil_package_segments:
actual = spec.format(named_str)
assert expected == actual
compiler = spec.compiler
for named_str, prop in compiler_segments:
expected = getattr(compiler, prop, "")
actual = spec.format(named_str)
assert str(expected) == actual
for named_str, expected in sigil_compiler_segments:
actual = spec.format(named_str)
assert expected == actual
arch = spec.architecture
for named_str, prop in architecture_segments:
expected = getattr(arch, prop, "")
actual = spec.format(named_str)
assert str(expected) == actual
for named_str, expected in other_segments:
actual = spec.format(named_str)
assert expected == actual
def test_spec_formatting_escapes(self):
spec = Spec("multivalue-variant cflags=-O2")
spec.concretize()
sigil_mismatches = [
"{@name}",
"{@version.concrete}",
"{%compiler.version}",
"{/hashd}",
"{arch=architecture.os}",
]
for fmt_str in sigil_mismatches:
with pytest.raises(SpecFormatSigilError):
spec.format(fmt_str)
bad_formats = [
r"{}",
r"name}",
r"\{name}",
r"{name",
r"{name\}",
r"{_concrete}",
r"{dag_hash}",
r"{foo}",
r"{+variants.debug}",
]
for fmt_str in bad_formats:
with pytest.raises(SpecFormatStringError):
spec.format(fmt_str)
def test_spec_deprecated_formatting(self):
spec = Spec("libelf cflags=-O2")
spec.concretize()
# Since the default is the full spec see if the string rep of
# spec is the same as the output of spec.format()
# ignoring whitespace (though should we?)
assert str(spec) == spec.format("$_$@$%@+$+$=").strip()
# Testing named strings ie {string} and whether we get
# the correct component
# Mixed case intentional for testing both
package_segments = [
("${PACKAGE}", "name"),
("${VERSION}", "versions"),
("${compiler}", "compiler"),
("${compilerflags}", "compiler_flags"),
("${options}", "variants"),
("${architecture}", "architecture"),
]
compiler_segments = [("${compilername}", "name"), ("${compilerver}", "versions")]
architecture_segments = [
("${PLATFORM}", "platform"),
("${OS}", "os"),
("${TARGET}", "target"),
]
for named_str, prop in package_segments:
expected = getattr(spec, prop, "")
actual = spec.format(named_str)
assert str(expected) == actual
compiler = spec.compiler
for named_str, prop in compiler_segments:
expected = getattr(compiler, prop, "")
actual = spec.format(named_str)
assert str(expected) == actual
arch = spec.architecture
for named_str, prop in architecture_segments:
expected = getattr(arch, prop, "")
actual = spec.format(named_str)
assert str(expected) == actual
@pytest.mark.regression("9908")
def test_spec_flags_maintain_order(self):
# Spack was assembling flags in a manner that could result in
# different orderings for repeated concretizations of the same
# spec and config
spec_str = "libelf %gcc@4.7.2 os=redhat6"
for _ in range(25):
s = Spec(spec_str).concretized()
assert all(
s.compiler_flags[x] == ["-O0", "-g"] for x in ("cflags", "cxxflags", "fflags")
)
def test_combination_of_wildcard_or_none(self):
# Test that using 'none' and another value raises
with pytest.raises(spack.variant.InvalidVariantValueCombinationError):
Spec("multivalue-variant foo=none,bar")
# Test that using wildcard and another value raises
with pytest.raises(spack.variant.InvalidVariantValueCombinationError):
Spec("multivalue-variant foo=*,bar")
@pytest.mark.skipif(sys.version_info[0] == 2, reason="__wrapped__ requires python 3")
def test_errors_in_variant_directive(self):
variant = spack.directives.variant.__wrapped__
class Pkg(object):
name = "PKG"
# We can't use names that are reserved by Spack
fn = variant("patches")
with pytest.raises(spack.directives.DirectiveError) as exc_info:
fn(Pkg())
assert "The name 'patches' is reserved" in str(exc_info.value)
# We can't have conflicting definitions for arguments
fn = variant("foo", values=spack.variant.any_combination_of("fee", "foom"), default="bar")
with pytest.raises(spack.directives.DirectiveError) as exc_info:
fn(Pkg())
assert " it is handled by an attribute of the 'values' " "argument" in str(exc_info.value)
# We can't leave None as a default value
fn = variant("foo", default=None)
with pytest.raises(spack.directives.DirectiveError) as exc_info:
fn(Pkg())
assert "either a default was not explicitly set, or 'None' was used" in str(exc_info.value)
# We can't use an empty string as a default value
fn = variant("foo", default="")
with pytest.raises(spack.directives.DirectiveError) as exc_info:
fn(Pkg())
assert "the default cannot be an empty string" in str(exc_info.value)
def test_abstract_spec_prefix_error(self):
spec = Spec("libelf")
with pytest.raises(SpecError):
spec.prefix
def test_forwarding_of_architecture_attributes(self):
spec = Spec("libelf target=x86_64").concretized()
# Check that we can still access each member through
# the architecture attribute
assert "test" in spec.architecture
assert "debian" in spec.architecture
assert "x86_64" in spec.architecture
# Check that we forward the platform and os attribute correctly
assert spec.platform == "test"
assert spec.os == "debian6"
# Check that the target is also forwarded correctly and supports
# all the operators we expect
assert spec.target == "x86_64"
assert spec.target.family == "x86_64"
assert "avx512" not in spec.target
assert spec.target < "broadwell"
@pytest.mark.parametrize("transitive", [True, False])
def test_splice(self, transitive):
# Tests the new splice function in Spec using a somewhat simple case
# with a variant with a conditional dependency.
spec = Spec("splice-t")
dep = Spec("splice-h+foo")
spec.concretize()
dep.concretize()
# Sanity checking that these are not the same thing.
assert dep.dag_hash() != spec["splice-h"].dag_hash()
# Do the splice.
out = spec.splice(dep, transitive)
# Returned spec should still be concrete.
assert out.concrete
# Traverse the spec and assert that all dependencies are accounted for.
for node in spec.traverse():
assert node.name in out
# If the splice worked, then the dag hash of the spliced dep should
# now match the dag hash of the build spec of the dependency from the
# returned spec.
out_h_build = out["splice-h"].build_spec
assert out_h_build.dag_hash() == dep.dag_hash()
# Transitivity should determine whether the transitive dependency was
# changed.
expected_z = dep["splice-z"] if transitive else spec["splice-z"]
assert out["splice-z"].dag_hash() == expected_z.dag_hash()
# Sanity check build spec of out should be the original spec.
assert out["splice-t"].build_spec.dag_hash() == spec["splice-t"].dag_hash()
# Finally, the spec should know it's been spliced:
assert out.spliced
@pytest.mark.parametrize("transitive", [True, False])
def test_splice_with_cached_hashes(self, transitive):
spec = Spec("splice-t")
dep = Spec("splice-h+foo")
spec.concretize()
dep.concretize()
# monkeypatch hashes so we can test that they are cached
spec._hash = "aaaaaa"
dep._hash = "bbbbbb"
spec["splice-h"]._hash = "cccccc"
spec["splice-z"]._hash = "dddddd"
dep["splice-z"]._hash = "eeeeee"
out = spec.splice(dep, transitive=transitive)
out_z_expected = (dep if transitive else spec)["splice-z"]
assert out.dag_hash() != spec.dag_hash()
assert (out["splice-h"].dag_hash() == dep.dag_hash()) == transitive
assert out["splice-z"].dag_hash() == out_z_expected.dag_hash()
@pytest.mark.parametrize("transitive", [True, False])
def test_splice_input_unchanged(self, transitive):
spec = Spec("splice-t").concretized()
dep = Spec("splice-h+foo").concretized()
orig_spec_hash = spec.dag_hash()
orig_dep_hash = dep.dag_hash()
spec.splice(dep, transitive)
# Post-splice, dag hash should still be different; no changes should be
# made to these specs.
assert spec.dag_hash() == orig_spec_hash
assert dep.dag_hash() == orig_dep_hash
@pytest.mark.parametrize("transitive", [True, False])
def test_splice_subsequent(self, transitive):
spec = Spec("splice-t")
dep = Spec("splice-h+foo")
spec.concretize()
dep.concretize()
out = spec.splice(dep, transitive)
# Now we attempt a second splice.
dep = Spec("splice-z+bar")
dep.concretize()
# Transitivity shouldn't matter since Splice Z has no dependencies.
out2 = out.splice(dep, transitive)
assert out2.concrete
assert out2["splice-z"].dag_hash() != spec["splice-z"].dag_hash()
assert out2["splice-z"].dag_hash() != out["splice-z"].dag_hash()
assert out2["splice-t"].build_spec.dag_hash() == spec["splice-t"].dag_hash()
assert out2.spliced
@pytest.mark.parametrize("transitive", [True, False])
def test_splice_dict(self, transitive):
spec = Spec("splice-t")
dep = Spec("splice-h+foo")
spec.concretize()
dep.concretize()
out = spec.splice(dep, transitive)
# Sanity check all hashes are unique...
assert spec.dag_hash() != dep.dag_hash()
assert out.dag_hash() != dep.dag_hash()
assert out.dag_hash() != spec.dag_hash()
node_list = out.to_dict()["spec"]["nodes"]
root_nodes = [n for n in node_list if n["hash"] == out.dag_hash()]
build_spec_nodes = [n for n in node_list if n["hash"] == spec.dag_hash()]
assert spec.dag_hash() == out.build_spec.dag_hash()
assert len(root_nodes) == 1
assert len(build_spec_nodes) == 1
@pytest.mark.parametrize("transitive", [True, False])
def test_splice_dict_roundtrip(self, transitive):
spec = Spec("splice-t")
dep = Spec("splice-h+foo")
spec.concretize()
dep.concretize()
out = spec.splice(dep, transitive)
# Sanity check all hashes are unique...
assert spec.dag_hash() != dep.dag_hash()
assert out.dag_hash() != dep.dag_hash()
assert out.dag_hash() != spec.dag_hash()
out_rt_spec = Spec.from_dict(out.to_dict()) # rt is "round trip"
assert out_rt_spec.dag_hash() == out.dag_hash()
out_rt_spec_bld_hash = out_rt_spec.build_spec.dag_hash()
out_rt_spec_h_bld_hash = out_rt_spec["splice-h"].build_spec.dag_hash()
out_rt_spec_z_bld_hash = out_rt_spec["splice-z"].build_spec.dag_hash()
# In any case, the build spec for splice-t (root) should point to the
# original spec, preserving build provenance.
assert spec.dag_hash() == out_rt_spec_bld_hash
assert out_rt_spec.dag_hash() != out_rt_spec_bld_hash
# The build spec for splice-h should always point to the introduced
# spec, since that is the spec spliced in.
assert dep["splice-h"].dag_hash() == out_rt_spec_h_bld_hash
# The build spec for splice-z will depend on whether or not the splice
# was transitive.
expected_z_bld_hash = (
dep["splice-z"].dag_hash() if transitive else spec["splice-z"].dag_hash()
)
assert expected_z_bld_hash == out_rt_spec_z_bld_hash
@pytest.mark.parametrize(
"spec,constraint,expected_result",
[
("libelf target=haswell", "target=broadwell", False),
("libelf target=haswell", "target=haswell", True),
("libelf target=haswell", "target=x86_64:", True),
("libelf target=haswell", "target=:haswell", True),
("libelf target=haswell", "target=icelake,:nocona", False),
("libelf target=haswell", "target=haswell,:nocona", True),
# Check that a single target is not treated as the start
# or the end of an open range
("libelf target=haswell", "target=x86_64", False),
("libelf target=x86_64", "target=haswell", False),
],
)
@pytest.mark.regression("13111")
def test_target_constraints(self, spec, constraint, expected_result):
s = Spec(spec)
assert s.satisfies(constraint) is expected_result
@pytest.mark.regression("13124")
def test_error_message_unknown_variant(self):
s = Spec("mpileaks +unknown")
with pytest.raises(UnknownVariantError, match=r"package has no such"):
s.concretize()
@pytest.mark.regression("18527")
def test_satisfies_dependencies_ordered(self):
d = Spec("zmpi ^fake")
s = Spec("mpileaks")
s._add_dependency(d, ())
assert s.satisfies("mpileaks ^zmpi ^fake", strict=True)
@pytest.mark.parametrize("transitive", [True, False])
def test_splice_swap_names(self, transitive):
spec = Spec("splice-t")
dep = Spec("splice-a+foo")
spec.concretize()
dep.concretize()
out = spec.splice(dep, transitive)
assert dep.name in out
assert transitive == ("+foo" in out["splice-z"])
@pytest.mark.parametrize("transitive", [True, False])
def test_splice_swap_names_mismatch_virtuals(self, transitive):
spec = Spec("splice-t")
dep = Spec("splice-vh+foo")
spec.concretize()
dep.concretize()
with pytest.raises(spack.spec.SpliceError, match="will not provide the same virtuals."):
spec.splice(dep, transitive)
def test_spec_override(self):
init_spec = Spec("a foo=baz foobar=baz cflags=-O3 cxxflags=-O1")
change_spec = Spec("a foo=fee cflags=-O2")
new_spec = Spec.override(init_spec, change_spec)
new_spec.concretize()
assert "foo=fee" in new_spec
# This check fails without concretizing: apparently if both specs are
# abstract, then the spec will always be considered to satisfy
# 'variant=value' (regardless of whether it in fact does).
assert "foo=baz" not in new_spec
assert "foobar=baz" in new_spec
assert new_spec.compiler_flags["cflags"] == ["-O2"]
assert new_spec.compiler_flags["cxxflags"] == ["-O1"]
@pytest.mark.regression("3887")
@pytest.mark.parametrize("spec_str", ["git", "hdf5", "py-flake8"])
def test_is_extension_after_round_trip_to_dict(config, spec_str):
# x is constructed directly from string, y from a
# round-trip to dict representation
x = Spec(spec_str)
x.concretize()
y = Spec.from_dict(x.to_dict())
# Using 'y' since the round-trip make us lose build dependencies
for d in y.traverse():
assert x[d.name].package.is_extension == y[d.name].package.is_extension
def test_malformed_spec_dict():
with pytest.raises(SpecError, match="malformed"):
Spec.from_dict({"spec": {"nodes": [{"dependencies": {"name": "foo"}}]}})
def test_spec_dict_hashless_dep():
with pytest.raises(SpecError, match="Couldn't parse"):
Spec.from_dict(
{
"spec": {
"nodes": [
{"name": "foo", "hash": "thehash", "dependencies": [{"name": "bar"}]}
]
}
}
)
@pytest.mark.parametrize(
"specs,expected",
[
# Anonymous specs without dependencies
(["+baz", "+bar"], "+baz+bar"),
(["@2.0:", "@:5.1", "+bar"], "@2.0:5.1 +bar"),
# Anonymous specs with dependencies
(["^mpich@3.2", "^mpich@:4.0+foo"], "^mpich@3.2 +foo"),
# Mix a real package with a virtual one. This test
# should fail if we start using the repository
(["^mpich@3.2", "^mpi+foo"], "^mpich@3.2 ^mpi+foo"),
],
)
def test_merge_abstract_anonymous_specs(specs, expected):
specs = [Spec(x) for x in specs]
result = spack.spec.merge_abstract_anonymous_specs(*specs)
assert result == Spec(expected)
@pytest.mark.parametrize(
"anonymous,named,expected",
[
("+plumed", "gromacs", "gromacs+plumed"),
("+plumed ^plumed%gcc", "gromacs", "gromacs+plumed ^plumed%gcc"),
("+plumed", "builtin.gromacs", "builtin.gromacs+plumed"),
],
)
def test_merge_anonymous_spec_with_named_spec(anonymous, named, expected):
s = Spec(anonymous)
changed = s.constrain(named)
assert changed
assert s == Spec(expected)
def test_spec_installed(install_mockery, database):
"""Test whether Spec.installed works."""
# a known installed spec should say that it's installed
specs = database.query()
spec = specs[0]
assert spec.installed
assert spec.copy().installed
# an abstract spec should say it's not installed
spec = Spec("not-a-real-package")
assert not spec.installed
# 'a' is not in the mock DB and is not installed
spec = Spec("a").concretized()
assert not spec.installed
@pytest.mark.regression("30678")
def test_call_dag_hash_on_old_dag_hash_spec(mock_packages, config):
# create a concrete spec
a = Spec("a").concretized()
dag_hashes = {spec.name: spec.dag_hash() for spec in a.traverse()}
# make it look like an old DAG hash spec with no package hash on the spec.
for spec in a.traverse():
assert spec.concrete
spec._package_hash = None
for spec in a.traverse():
assert dag_hashes[spec.name] == spec.dag_hash()
with pytest.raises(ValueError, match="Cannot call package_hash()"):
spec.package_hash()
@pytest.mark.regression("30861")
def test_concretize_partial_old_dag_hash_spec(mock_packages, config):
# create an "old" spec with no package hash
bottom = Spec("dt-diamond-bottom").concretized()
delattr(bottom, "_package_hash")
dummy_hash = "zd4m26eis2wwbvtyfiliar27wkcv3ehk"
bottom._hash = dummy_hash
# add it to an abstract spec as a dependency
top = Spec("dt-diamond")
top.add_dependency_edge(bottom, ())
# concretize with the already-concrete dependency
top.concretize()
for spec in top.traverse():
assert spec.concrete
# make sure dag_hash is untouched
assert spec["dt-diamond-bottom"].dag_hash() == dummy_hash
assert spec["dt-diamond-bottom"]._hash == dummy_hash
# make sure package hash is NOT recomputed
assert not getattr(spec["dt-diamond-bottom"], "_package_hash", None)
def test_unsupported_compiler():
with pytest.raises(UnsupportedCompilerError):
Spec("gcc%fake-compiler").validate_or_raise()
def test_package_hash_affects_dunder_and_dag_hash(mock_packages, config):
a1 = Spec("a").concretized()
a2 = Spec("a").concretized()
assert hash(a1) == hash(a2)
assert a1.dag_hash() == a2.dag_hash()
assert a1.process_hash() == a2.process_hash()
a1.clear_cached_hashes()
a2.clear_cached_hashes()
# tweak the dag hash of one of these specs
new_hash = "00000000000000000000000000000000"
if new_hash == a1._package_hash:
new_hash = "11111111111111111111111111111111"
a1._package_hash = new_hash
assert hash(a1) != hash(a2)
assert a1.dag_hash() != a2.dag_hash()
assert a1.process_hash() != a2.process_hash()
|