diff options
author | Rich Felker <dalias@aerifal.cx> | 2017-04-11 22:01:31 -0400 |
---|---|---|
committer | Rich Felker <dalias@aerifal.cx> | 2017-04-11 22:09:10 -0400 |
commit | 1ca597551bab424a1302938dd3504ddf73904efd (patch) | |
tree | 829fe539b9b62f57e74b8daabebcadcbe7d20109 /include/search.h | |
parent | 54807d47acecab778498ced88ce8f62bfa16e379 (diff) | |
download | musl-1ca597551bab424a1302938dd3504ddf73904efd.tar.gz musl-1ca597551bab424a1302938dd3504ddf73904efd.tar.bz2 musl-1ca597551bab424a1302938dd3504ddf73904efd.tar.xz musl-1ca597551bab424a1302938dd3504ddf73904efd.zip |
fix read past end of buffer in getaddrinfo backend
due to testing buf[i].family==AF_INET before checking i==cnt, it was
possible to read past the end of the array, or past the valid part. in
practice, without active bounds/indeterminate-value checking by the
compiler, the worst that happened was failure to return early and
optimize out the sorting that's unneeded for v4-only results.
returning on i==cnt-1 rather than i==cnt would be an alternate fix,
but the approach this patch takes is more idiomatic and less
error-prone.
patch by Timo Teräs.
Diffstat (limited to 'include/search.h')
0 files changed, 0 insertions, 0 deletions