diff options
| author | Rich Felker <dalias@aerifal.cx> | 2015-04-14 23:45:08 -0400 |
|---|---|---|
| committer | Rich Felker <dalias@aerifal.cx> | 2015-04-14 23:45:08 -0400 |
| commit | 81e18eb3cd61f7b68a8f99b3e6c728f2a4d79221 (patch) | |
| tree | 2ea334c40a3b59607be4f3f9ae524cdcf5b69d21 /src/ldso/i386 | |
| parent | 9c738dc183f44de40d263e4ff8dc540915a41aed (diff) | |
| download | musl-81e18eb3cd61f7b68a8f99b3e6c728f2a4d79221.tar.gz musl-81e18eb3cd61f7b68a8f99b3e6c728f2a4d79221.tar.bz2 musl-81e18eb3cd61f7b68a8f99b3e6c728f2a4d79221.tar.xz musl-81e18eb3cd61f7b68a8f99b3e6c728f2a4d79221.zip | |
use hidden __tls_get_new for tls/tlsdesc lookup fallback cases
previously, the dynamic tlsdesc lookup functions and the i386
special-ABI ___tls_get_addr (3 underscores) function called
__tls_get_addr when the slot they wanted was not already setup;
__tls_get_addr would then in turn also see that it's not setup and
call __tls_get_new.
calling __tls_get_new directly is both more efficient and avoids the
issue of calling a non-hidden (public API/ABI) function from asm.
for the special i386 function, a weak reference to __tls_get_new is
used since this function is not defined when static linking (the code
path that needs it is unreachable in static-linked programs).
Diffstat (limited to 'src/ldso/i386')
| -rw-r--r-- | src/ldso/i386/tlsdesc.s | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/ldso/i386/tlsdesc.s b/src/ldso/i386/tlsdesc.s index 3ac61297..00a9fc09 100644 --- a/src/ldso/i386/tlsdesc.s +++ b/src/ldso/i386/tlsdesc.s @@ -5,6 +5,8 @@ __tlsdesc_static: mov 4(%eax),%eax ret +.hidden __tls_get_new + .global __tlsdesc_dynamic .type __tlsdesc_dynamic,@function __tlsdesc_dynamic: @@ -22,6 +24,6 @@ __tlsdesc_dynamic: pop %edx ret 1: push %eax - call __tls_get_addr + call __tls_get_new pop %ecx jmp 2b |