diff options
author | Rich Felker <dalias@aerifal.cx> | 2019-07-28 19:29:28 -0400 |
---|---|---|
committer | Rich Felker <dalias@aerifal.cx> | 2019-07-29 00:19:21 -0400 |
commit | 4c307bed03d97da4cfd9224c5b7669bb22cd9faf (patch) | |
tree | 893bd71eb654621d6d475bef13757d4669a536ac /src/thread/x32/syscall_cp.s | |
parent | 01f3480d377a764135a1bd28af0d901d765ded50 (diff) | |
download | musl-4c307bed03d97da4cfd9224c5b7669bb22cd9faf.tar.gz musl-4c307bed03d97da4cfd9224c5b7669bb22cd9faf.tar.bz2 musl-4c307bed03d97da4cfd9224c5b7669bb22cd9faf.tar.xz musl-4c307bed03d97da4cfd9224c5b7669bb22cd9faf.zip |
remove x32 syscall timespec fixup hacks
the x32 syscall interfaces treat timespec's tv_nsec member as 64-bit
despite the API type being long and long being 32-bit in the ABI. this
is no problem for syscalls that store timespecs to userspace as
results, but caused uninitialized padding to be misinterpreted as the
high bits in syscalls that take timespecs as input.
since the beginning of the port, we've dealt with this situation with
hacks in syscall_arch.h, and injected between __syscall_cp_c and
__syscall_cp_asm, to special-case the syscall numbers that involve
timespecs as inputs and copy them to a form suitable to pass to the
kernel.
commit 40aa18d55ab763e69ad16d0cf1cebea708ffde47 set the stage for
removal of these hacks by letting us treat the "normal" x32 syscalls
dealing with timespec as if they're x32's "time64" syscalls,
effectively making x32 ax "time64-only 32-bit arch" like riscv32 will
be when it's added. since then, all users of syscalls that x32's
syscall_arch.h had hacks for have been updated to use time64 syscalls,
so the hacks can be removed.
there are still at least a few other timespec-related syscalls broken
on x32, which were overlooked when the x32 hacks were done or added
later. these include at least recvmmsg, adjtimex/clock_adjtime, and
timerfd_settime, and they will be fixed independently later on.
Diffstat (limited to 'src/thread/x32/syscall_cp.s')
-rw-r--r-- | src/thread/x32/syscall_cp.s | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/thread/x32/syscall_cp.s b/src/thread/x32/syscall_cp.s index 9805af0a..4f101716 100644 --- a/src/thread/x32/syscall_cp.s +++ b/src/thread/x32/syscall_cp.s @@ -6,10 +6,10 @@ .global __cp_cancel .hidden __cp_cancel .hidden __cancel -.global __syscall_cp_internal -.hidden __syscall_cp_internal -.type __syscall_cp_internal,@function -__syscall_cp_internal: +.global __syscall_cp_asm +.hidden __syscall_cp_asm +.type __syscall_cp_asm,@function +__syscall_cp_asm: __cp_begin: mov (%rdi),%eax |