diff options
author | Zach van Rijn <me@zv.io> | 2023-03-21 16:58:08 +0000 |
---|---|---|
committer | Zach van Rijn <me@zv.io> | 2023-03-21 17:24:04 +0000 |
commit | c57df9efeda39dd0347a957565a60c159ef86278 (patch) | |
tree | d69ffa5926e5e16c77d56506e7d53f30909a2bd7 /user/node/flaky-sigint-test.patch | |
parent | b673b979e840bd379d655e98135ed8c18969a5cc (diff) | |
download | packages-c57df9efeda39dd0347a957565a60c159ef86278.tar.gz packages-c57df9efeda39dd0347a957565a60c159ef86278.tar.bz2 packages-c57df9efeda39dd0347a957565a60c159ef86278.tar.xz packages-c57df9efeda39dd0347a957565a60c159ef86278.zip |
user/node: bump { 18.12.1 --> 18.15.0 }. temporarily disable flaky tests.
See #971.
It is not clear whether these tests ever passed in their current form.
Upstream changed these tests (and relevant code) since v16.15.0:
https://github.com/nodejs/node/pull/41431
https://github.com/nodejs/node/issues/43014
In v16.15.0, these tests passed on this platform, but they have been
modified in subsequent releases, and we've bumped twice since then:
b282640c5353f37b706d3395718e80db244644b2 to v16.19.0
5d1083c1c688a496fbf9565046a1e22309cd9ad5 to v18.12.1
I don't see any binaries for aarch64 for either of these versions,
suggesting we never rebuilt node on aarch64 after going to v18.12.1,
likely due to the ARM builder being out of service between around
2022-12-27 and 2023-01-03. I think we just didn't catch this since
bumping to v18.12.1.
Temporarily disabling these tests to unblock progress; the
bump to v18.15.0 is for some CVEs and expected to be safe.
Diffstat (limited to 'user/node/flaky-sigint-test.patch')
-rw-r--r-- | user/node/flaky-sigint-test.patch | 73 |
1 files changed, 0 insertions, 73 deletions
diff --git a/user/node/flaky-sigint-test.patch b/user/node/flaky-sigint-test.patch deleted file mode 100644 index 0ac7a49b1..000000000 --- a/user/node/flaky-sigint-test.patch +++ /dev/null @@ -1,73 +0,0 @@ -From 80ade7f46f3cd6b969153dbfc34c451fc624bdc6 Mon Sep 17 00:00:00 2001 -From: Rich Trott <rtrott@gmail.com> -Date: Sun, 6 Nov 2022 22:41:28 -0800 -Subject: [PATCH 1/2] test: fix flaky test-repl-sigint-nested-eval - -There is a race condition where process.kill can be sent before the -target is ready to receive the signal. - -Fixes: https://github.com/nodejs/node/issues/41123 ---- - test/parallel/test-repl-sigint-nested-eval.js | 12 +++++++----- - 1 files changed, 7 insertions(+), 5 deletions(-) - -diff --git a/test/parallel/test-repl-sigint-nested-eval.js b/test/parallel/test-repl-sigint-nested-eval.js -index 28e4d44b235c..5830e08629b9 100644 ---- a/test/parallel/test-repl-sigint-nested-eval.js -+++ b/test/parallel/test-repl-sigint-nested-eval.js -@@ -12,7 +12,7 @@ const spawn = require('child_process').spawn; - - process.env.REPL_TEST_PPID = process.pid; - const child = spawn(process.execPath, [ '-i' ], { -- stdio: [null, null, 2] -+ stdio: [null, null, 2, 'ipc'] - }); - - let stdout = ''; -@@ -22,7 +22,8 @@ child.stdout.on('data', function(c) { - }); - - child.stdout.once('data', common.mustCall(() => { -- process.on('SIGUSR2', common.mustCall(() => { -+ child.on('message', common.mustCall((msg) => { -+ assert.strictEqual(msg, 'repl is busy'); - process.kill(child.pid, 'SIGINT'); - child.stdout.once('data', common.mustCall(() => { - // Make sure REPL still works. -@@ -30,9 +31,10 @@ child.stdout.once('data', common.mustCall(() => { - })); - })); - -- child.stdin.write('process.kill(+process.env.REPL_TEST_PPID, "SIGUSR2");' + -- 'vm.runInThisContext("while(true){}", ' + -- '{ breakOnSigint: true });\n'); -+ child.stdin.write( -+ 'vm.runInThisContext("process.send(\'repl is busy\'); while(true){}", ' + -+ '{ breakOnSigint: true });\n' -+ ); - })); - - child.on('close', function(code) { - -From 2d9cf095d12420ef825e9ba83deb46426561ddbb Mon Sep 17 00:00:00 2001 -From: Rich Trott <rtrott@gmail.com> -Date: Thu, 10 Nov 2022 09:00:55 -0800 -Subject: [PATCH 2/2] Update test/parallel/test-repl-sigint-nested-eval.js - -Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> ---- - test/parallel/test-repl-sigint-nested-eval.js | 1 - - 1 file changed, 1 deletion(-) - -diff --git a/test/parallel/test-repl-sigint-nested-eval.js b/test/parallel/test-repl-sigint-nested-eval.js -index 5830e08629b9..62eb46e0af67 100644 ---- a/test/parallel/test-repl-sigint-nested-eval.js -+++ b/test/parallel/test-repl-sigint-nested-eval.js -@@ -10,7 +10,6 @@ if (!common.isMainThread) - const assert = require('assert'); - const spawn = require('child_process').spawn; - --process.env.REPL_TEST_PPID = process.pid; - const child = spawn(process.execPath, [ '-i' ], { - stdio: [null, null, 2, 'ipc'] - }); |