diff options
author | John W. Parent <45471568+johnwparent@users.noreply.github.com> | 2024-02-23 16:30:11 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-02-23 13:30:11 -0800 |
commit | f51c9fc6c3fcfcf0144c1813c1ce84391e46e773 (patch) | |
tree | b9d58ac4d212310428c6880313c32de001a98e5f /.codecov.yml | |
parent | 3e713bb0faf742e97a517bfd612495e0b98d930a (diff) | |
download | spack-f51c9fc6c3fcfcf0144c1813c1ce84391e46e773.tar.gz spack-f51c9fc6c3fcfcf0144c1813c1ce84391e46e773.tar.bz2 spack-f51c9fc6c3fcfcf0144c1813c1ce84391e46e773.tar.xz spack-f51c9fc6c3fcfcf0144c1813c1ce84391e46e773.zip |
Windows path handling: change representation for paths with spaces (#42754)
Some builds on Windows break when encountering paths with spaces. This
reencodes some paths in Windows 8.3 filename format (when on Windows):
this serves as an equivalent identifier for the file, but in a form that
does not have spaces.
8.3 filenames are also truncated in length, which could be helpful, but
that is not the primary intended purpose of using this format.
Overall
* nmake/msbuild packages do this generally for the install prefix
* curl/perl require additional modifications (as written now, each package
may require calls to `windows_sfn` to work when the Spack
root/install/staging prefixes contain spaces)
Some items for follow-up:
* Spack itself does not create paths with spaces "on top" of whatever
the user configures or where it is placed (e.g. the Spack root, the
staging directory, etc.), so it might be possible to edit some of these
paths once and avoid a proliferation of individual `windows_sfn`
calls in individual packages.
* This approach may result in the insertion of 8.3-style paths into
build artifacts (on Windows), handling this may require additional
bookkeeping (e.g. when relocating).
Diffstat (limited to '.codecov.yml')
0 files changed, 0 insertions, 0 deletions