diff options
| author | Paul Henning <40867327+pjh40@users.noreply.github.com> | 2021-07-08 13:17:44 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-07-08 15:17:44 -0400 |
| commit | 620836a80960396487b5eeba41c2a57c0b4674d2 (patch) | |
| tree | 398fead7c88806c776b47da0cfe22935968325a8 /.flake8 | |
| parent | 0c5402ea5cf1e28c392aa455ca432040de9a830a (diff) | |
| download | spack-620836a80960396487b5eeba41c2a57c0b4674d2.tar.gz spack-620836a80960396487b5eeba41c2a57c0b4674d2.tar.bz2 spack-620836a80960396487b5eeba41c2a57c0b4674d2.tar.xz spack-620836a80960396487b5eeba41c2a57c0b4674d2.zip | |
hdf5: Fix compiler identification for warning flags (#24627)
* Fix compiler test
Use `self.spec.satisfies` on compiler to determine if a flag should be
applied or not. This approach avoids issues with the strings `gcc`
or `clang` appearing in the full path to the compiler executables, as
happens with spack-installed compilers (e.g. `nvhpc%gcc`).
* Limit compiler name search to last path component
@skosukhin pointed out that the cflag modification should happen for any
clang or gcc compiler, regardless of what compiler spec provides them.
This commit reverts to searching for a compiler name containing "gcc"
or "clang", but limits the search to the last path component, which
avoids matching spack-installed compilers built with gcc (e.g.
`nvhpc%gcc`), which will have "gcc" in the compiler path.
* Use `os.path` rather than `pathlib`
Co-authored-by: Paul Henning <phenning@lanl.gov>
Diffstat (limited to '.flake8')
0 files changed, 0 insertions, 0 deletions