diff options
| author | psakievich <psakiev@sandia.gov> | 2024-06-11 14:57:09 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-11 14:57:09 -0600 |
| commit | 337bf3b944cdd11ab6cdd9c93bcae879abad873a (patch) | |
| tree | c93f222df182584c2382662dab14a5809a5bf047 /.github | |
| parent | a49b2f4f16155cbd36b9091291f897016969341a (diff) | |
| download | spack-337bf3b944cdd11ab6cdd9c93bcae879abad873a.tar.gz spack-337bf3b944cdd11ab6cdd9c93bcae879abad873a.tar.bz2 spack-337bf3b944cdd11ab6cdd9c93bcae879abad873a.tar.xz spack-337bf3b944cdd11ab6cdd9c93bcae879abad873a.zip | |
Enable and constrain reuse for GitVersion installations (#43859)
* Preserve higher weight for CLI git ref versions
Currently the concretizer fails if you reuse a git ref version
that has already been installed but modify the spec at all.
See #38484 for futher diagnosis
The issue here is that since there is no established provenance for
these versions the highest weight they are currently assigned is
that of prior install. Re-use checks then fail because the weight of
the version is identical to the solver.
Ironically, these versions are given the highest weights possible when
specified on the CLI for the first time. They should only appear in a
DAG if they are an exact match or if the user specifies them at the CLI.
Therefore it makes sense to preserve their higher ordering.
Getting this right is critical to moving all branch based versions to a pinned
git-ref in the future.
* [@spackbot] updating style on behalf of psakievich
* Update lib/spack/spack/solver/asp.py
Co-authored-by: Greg Becker <becker33@llnl.gov>
* Add provenance specific to git ref installs
* Sensitvity to name that I could not track down
* Add regression test
* Adjust test
* Add prefer standard unit-test
* Style
* Add required mock
* Format and mark
* Make unit-test case reproduce CLI investigation
* Remove unnecessary mock package
* [@spackbot] updating style on behalf of psakievich
* Use already developed fixture
* Add zlib-ng to mocks again
* Remove accidental adds
* Remove maintainer
* [@spackbot] updating style on behalf of psakievich
* Rename test file
* [@spackbot] updating style on behalf of psakievich
* Remove unused imports
* Update tests
* [@spackbot] updating style on behalf of psakievich
* Style
* Update lib/spack/spack/test/concretize.py
Co-authored-by: Greg Becker <becker33@llnl.gov>
* Update solver rule
* Duplicate installed rules for installed_git_version
* Revert "Duplicate installed rules for installed_git_version"
This reverts commit 17223fc8d1c9461cb87e5a230f397167d1ab6d40.
---------
Co-authored-by: psakievich <psakievich@users.noreply.github.com>
Co-authored-by: Greg Becker <becker33@llnl.gov>
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions