summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHarmen Stoppels <harmenstoppels@gmail.com>2022-10-21 14:42:06 +0200
committerGitHub <noreply@github.com>2022-10-21 14:42:06 +0200
commitb1559cc831620ee2b2cf8e57fdecc5bb3bf8edfd (patch)
tree74bca487f76ef38914b29e1016f8fb016216ad7b
parent93db654b8de6ae76bef382dc3c37eb715baa68b5 (diff)
downloadspack-b1559cc831620ee2b2cf8e57fdecc5bb3bf8edfd.tar.gz
spack-b1559cc831620ee2b2cf8e57fdecc5bb3bf8edfd.tar.bz2
spack-b1559cc831620ee2b2cf8e57fdecc5bb3bf8edfd.tar.xz
spack-b1559cc831620ee2b2cf8e57fdecc5bb3bf8edfd.zip
gitlab: when_possible -> false (#33443)
`reuse` and `when_possible` concretization broke the invariant that `spec[pkg_name]` has unique keys. This invariant is relied on in tons of places, such as when setting up the build environment. When using `when_possible` concretization, one may end up with two or more `perl`s or `python`s among the transitive deps of a spec, because concretization does not consider build-only deps of reusable specs. Until the code base is fixed not to rely on this broken property of `__getitem__`, we should disable reuse in CI.
-rw-r--r--share/spack/gitlab/cloud_pipelines/stacks/build_systems/spack.yaml2
-rw-r--r--share/spack/gitlab/cloud_pipelines/stacks/e4s-oneapi/spack.yaml2
2 files changed, 2 insertions, 2 deletions
diff --git a/share/spack/gitlab/cloud_pipelines/stacks/build_systems/spack.yaml b/share/spack/gitlab/cloud_pipelines/stacks/build_systems/spack.yaml
index eb60dd85fe..4808763f37 100644
--- a/share/spack/gitlab/cloud_pipelines/stacks/build_systems/spack.yaml
+++ b/share/spack/gitlab/cloud_pipelines/stacks/build_systems/spack.yaml
@@ -3,7 +3,7 @@ spack:
concretizer:
reuse: false
- unify: when_possible
+ unify: false
config:
install_tree:
diff --git a/share/spack/gitlab/cloud_pipelines/stacks/e4s-oneapi/spack.yaml b/share/spack/gitlab/cloud_pipelines/stacks/e4s-oneapi/spack.yaml
index ce8441a5d8..944c110ac5 100644
--- a/share/spack/gitlab/cloud_pipelines/stacks/e4s-oneapi/spack.yaml
+++ b/share/spack/gitlab/cloud_pipelines/stacks/e4s-oneapi/spack.yaml
@@ -3,7 +3,7 @@ spack:
concretizer:
reuse: false
- unify: when_possible
+ unify: false
config:
concretizer: clingo