diff options
| author | Wouter Deconinck <wdconinc@gmail.com> | 2024-07-23 11:49:05 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-23 11:49:05 -0400 |
| commit | 66ed8ebbd9154eba42917a6f22923009089d1ebe (patch) | |
| tree | fc3d0e6d1e6ca0811bdaba30dd4ac615cb385e3b | |
| parent | 0d326f83b672ac7efd9cd01c4d16679c2acdf0c3 (diff) | |
| download | spack-66ed8ebbd9154eba42917a6f22923009089d1ebe.tar.gz spack-66ed8ebbd9154eba42917a6f22923009089d1ebe.tar.bz2 spack-66ed8ebbd9154eba42917a6f22923009089d1ebe.tar.xz spack-66ed8ebbd9154eba42917a6f22923009089d1ebe.zip | |
gh: convert to GoPackage (#45351)
* gh: convert to GoPackage
* gh: fix style
| -rw-r--r-- | var/spack/repos/builtin/packages/gh/package.py | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/var/spack/repos/builtin/packages/gh/package.py b/var/spack/repos/builtin/packages/gh/package.py index ca768b4eb0..90f40c6313 100644 --- a/var/spack/repos/builtin/packages/gh/package.py +++ b/var/spack/repos/builtin/packages/gh/package.py @@ -6,7 +6,7 @@ from spack.package import * -class Gh(Package): +class Gh(GoPackage): """GitHub's official command line tool.""" homepage = "https://github.com/cli/cli" @@ -43,14 +43,10 @@ class Gh(Package): depends_on("go@1.21:", type="build", when="@2.33.0:") depends_on("go@1.22:", type="build", when="@2.47.0:") - phases = ["build", "install"] - def setup_build_environment(self, env): - # Point GOPATH at the top of the staging dir for the build step. - env.prepend_path("GOPATH", self.stage.path) - - def build(self, spec, prefix): - make() - - def install(self, spec, prefix): - make("install", "prefix=" + prefix) +class GoBuilder(spack.build_systems.go.GoBuilder): + @property + def build_args(self): + args = super().build_args + args.extend(["-trimpath", "./cmd/gh"]) + return args |