diff options
| author | Brian Van Essen <vanessen1@llnl.gov> | 2017-08-15 14:57:11 -0700 |
|---|---|---|
| committer | Adam J. Stewart <ajstewart426@gmail.com> | 2017-08-15 16:57:11 -0500 |
| commit | 7b517916254ec1a6a4f6e09de3e861145c17d8a1 (patch) | |
| tree | 44068502e37fbdd49fbedc8b565da5678a15bb2d | |
| parent | 8df9f9e1f4ad747759dc69acd59266b847534353 (diff) | |
| download | spack-7b517916254ec1a6a4f6e09de3e861145c17d8a1.tar.gz spack-7b517916254ec1a6a4f6e09de3e861145c17d8a1.tar.bz2 spack-7b517916254ec1a6a4f6e09de3e861145c17d8a1.tar.xz spack-7b517916254ec1a6a4f6e09de3e861145c17d8a1.zip | |
Openblas clang fix (#5065)
* Added a package for the MDAnalysis toolkit.
* Openblas now builds with clang when using 0.2.20
* Fixed flake8 error
* Added a guard to fail for openblas+openmp when on OSX systems
* Changed the guard to look for Apple's build of clang and to improve
the error messages.
* Removed blank line.
| -rw-r--r-- | var/spack/repos/builtin/packages/openblas/package.py | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/var/spack/repos/builtin/packages/openblas/package.py b/var/spack/repos/builtin/packages/openblas/package.py index 7fe07a283e..73b89fcd23 100644 --- a/var/spack/repos/builtin/packages/openblas/package.py +++ b/var/spack/repos/builtin/packages/openblas/package.py @@ -84,12 +84,15 @@ class Openblas(MakefilePackage): 'OpenBLAS requires both C and Fortran compilers!' ) # Add support for OpenMP - if '+openmp' in self.spec and self.spec.satisfies('%clang'): - # Openblas (as of 0.2.18) hardcoded that OpenMP cannot - # be used with any (!) compiler named clang, bummer. - raise InstallError( - 'OpenBLAS does not support OpenMP with clang!' - ) + if (('+openmp' in self.spec) and self.spec.satisfies('%clang')): + if str(self.spec.compiler.version).endswith('-apple'): + raise InstallError("Apple's clang does not support OpenMP") + if '@:0.2.19' in self.spec: + # Openblas (as of 0.2.19) hardcoded that OpenMP cannot + # be used with any (!) compiler named clang, bummer. + raise InstallError( + 'OpenBLAS @:0.2.19 does not support OpenMP with clang!' + ) @property def make_defs(self): |