summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorpsakievich <psakiev@sandia.gov>2024-08-20 07:04:23 -0600
committerGitHub <noreply@github.com>2024-08-20 13:04:23 +0000
commit85905959dc40df71924c3445d9aca23825b24f6d (patch)
tree9506f3a879b2e5dd52273538dd35e870dde3d913
parent2ae5596e921d386761d96f52784d526ad8ce082b (diff)
downloadspack-85905959dc40df71924c3445d9aca23825b24f6d.tar.gz
spack-85905959dc40df71924c3445d9aca23825b24f6d.tar.bz2
spack-85905959dc40df71924c3445d9aca23825b24f6d.tar.xz
spack-85905959dc40df71924c3445d9aca23825b24f6d.zip
Increase min version for sparse_checkout (#45818)
* Increase min version for sparse_checkout * Update git_fetch.py * style
-rw-r--r--lib/spack/spack/fetch_strategy.py4
-rw-r--r--lib/spack/spack/test/git_fetch.py2
2 files changed, 4 insertions, 2 deletions
diff --git a/lib/spack/spack/fetch_strategy.py b/lib/spack/spack/fetch_strategy.py
index fd313e0463..3b22cfb94c 100644
--- a/lib/spack/spack/fetch_strategy.py
+++ b/lib/spack/spack/fetch_strategy.py
@@ -930,7 +930,9 @@ class GitFetchStrategy(VCSFetchStrategy):
dest = self.stage.source_path
git = self.git
- if self.git_version < spack.version.Version("2.25.0.0"):
+ if self.git_version < spack.version.Version("2.26.0"):
+ # technically this should be supported for 2.25, but bumping for OS issues
+ # see https://github.com/spack/spack/issues/45771
# code paths exist where the package is not set. Assure some indentifier for the
# package that was configured for sparse checkout exists in the error message
identifier = str(self.url)
diff --git a/lib/spack/spack/test/git_fetch.py b/lib/spack/spack/test/git_fetch.py
index b709780651..eb2e03db07 100644
--- a/lib/spack/spack/test/git_fetch.py
+++ b/lib/spack/spack/test/git_fetch.py
@@ -415,7 +415,7 @@ def test_git_sparse_paths_partial_clone(
for p in sparse_paths:
assert os.path.isdir(p)
- if git_version < Version("2.25.0.0"):
+ if git_version < Version("2.26.0.0"):
# older versions of git should fall back to a full clone
for p in omitted_paths:
assert os.path.isdir(p)