diff options
author | Mario Melara <maamelara@gmail.com> | 2016-10-11 07:04:29 -0700 |
---|---|---|
committer | Todd Gamblin <tgamblin@llnl.gov> | 2016-10-11 07:04:29 -0700 |
commit | b42dbc01fe7db1acf80ea47a60514057ab6e7a60 (patch) | |
tree | d899dc59aadda4351d97f085d405d62f9d2096fa | |
parent | 4d939802ae208a79ef685fe59b204bcc86df4b6b (diff) | |
download | spack-b42dbc01fe7db1acf80ea47a60514057ab6e7a60.tar.gz spack-b42dbc01fe7db1acf80ea47a60514057ab6e7a60.tar.bz2 spack-b42dbc01fe7db1acf80ea47a60514057ab6e7a60.tar.xz spack-b42dbc01fe7db1acf80ea47a60514057ab6e7a60.zip |
Use python platform.system for system ID (#1499)
* Rebase and merging using platform.system
Rebasing and merging using platform.system instead of uname -a.
* Add missing import platform statement
* Remove subprocess import
Remove ununsed import subprocess to make changes flak8 compliant
-rw-r--r-- | lib/spack/spack/platforms/darwin.py | 6 | ||||
-rw-r--r-- | lib/spack/spack/platforms/linux.py | 5 |
2 files changed, 3 insertions, 8 deletions
diff --git a/lib/spack/spack/platforms/darwin.py b/lib/spack/spack/platforms/darwin.py index 974ce3a3f9..ffefd36546 100644 --- a/lib/spack/spack/platforms/darwin.py +++ b/lib/spack/spack/platforms/darwin.py @@ -1,4 +1,4 @@ -import subprocess +import platform from spack.architecture import Platform, Target from spack.operating_systems.mac_os import MacOs @@ -22,6 +22,4 @@ class Darwin(Platform): @classmethod def detect(self): - platform = subprocess.Popen(['uname', '-a'], stdout=subprocess.PIPE) - platform, _ = platform.communicate() - return 'darwin' in platform.strip().lower() + return 'darwin' in platform.system().lower() diff --git a/lib/spack/spack/platforms/linux.py b/lib/spack/spack/platforms/linux.py index 38d2cdbfec..cee0cfd6e9 100644 --- a/lib/spack/spack/platforms/linux.py +++ b/lib/spack/spack/platforms/linux.py @@ -1,4 +1,3 @@ -import subprocess import platform from spack.architecture import Platform, Target from spack.operating_systems.linux_distro import LinuxDistro @@ -27,6 +26,4 @@ class Linux(Platform): @classmethod def detect(self): - platform = subprocess.Popen(['uname', '-a'], stdout=subprocess.PIPE) - platform, _ = platform.communicate() - return 'linux' in platform.strip().lower() + return 'linux' in platform.system().lower() |