librsb: added v1.3.0.1 (#30425)

* librsb: added v1.2.0.10 (#26043)

* librsb: add v1.2.0.11/v1.3.0.0 (#28636)

* librsb: add v1.3.0.1 (#30424)

* unconflict clang

* address apparent style issues

given
 https://github.com/spack/spack/runs/6248126997?check_suite_focus=true
and its excerpt

  var/spack/repos/builtin/packages/librsb/package.py:27: [E265] block comment should start with '# '
  var/spack/repos/builtin/packages/librsb/package.py:52: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:53: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:53: [E501] line too long (89 > 88 characters)
  var/spack/repos/builtin/packages/librsb/package.py:54: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:55: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:56: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:57: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:59: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:60: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:62: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:63: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:64: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:66: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:68: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:70: [E211] whitespace before '('
  var/spack/repos/builtin/packages/librsb/package.py:71: [E211] whitespace before '('

let these changes flow in.

* +asan+native: mark as conflict; thanks @tldahlgren

* +asan conflict grouped with other conflicts

As suggested as good Spack style by @tldahlgren .

1 files changed, 40 insertions, 4 deletions

diff --git a/var/spack/repos/builtin/packages/librsb/package.py b/var/spack/repos/builtin/packages/librsb/package.py
index 031ba9897d..15028dfe5b 100644
--- a/var/spack/repos/builtin/packages/librsb/package.py
+++ b/var/spack/repos/builtin/packages/librsb/package.py
@@ -11,9 +11,10 @@ class Librsb(AutotoolsPackage):
     library for the Recursive Sparse Blocks format"""
 
     homepage = "http://librsb.sourceforge.net/"
-    url      = "http://download.sourceforge.net/librsb/librsb-1.3.0.0.tar.gz"
+    url      = "http://download.sourceforge.net/librsb/librsb-1.3.0.1.tar.gz"
     list_url = "https://sourceforge.net/projects/librsb/files/"
 
+    version('1.3.0.1',   '3fc024a410f94aca2a7139ae79f4d713b11fa83304293630c363786874c17db4')
     version('1.3.0.0',   '2ac8725d1f988f57df9383ae6b0bb2ed221ec935187d31ebb62ea95ee868a790')
     version('1.2.0.11',  '0686be29bbe277e227c6021de6bd0564e4fc83f996b787886437d28048057bc8')
     version('1.2.0.10',  'ec49f3f78a7c43fc9e10976593d100aa49b1863309ed8fa3ccbb7aad52d2f7b8')
@@ -21,8 +22,24 @@ class Librsb(AutotoolsPackage):
     version('1.2.0.8',   '8bebd19a1866d80ade13eabfdd0f07ae7e8a485c0b975b5d15f531ac204d80cb')
 
     depends_on('zlib')
+    depends_on('googletest', type='build', when='+googletest')
     conflicts('%apple-clang')
-    conflicts('%clang')
+    # conflicts('%clang')
+    conflicts('%gcc@11.0.0:11.2.99', msg='gcc-11.0:gcc-11.3 can break librsb on x86_64')
+    conflicts('+asan', when='+native', msg='native must be disabled when asan is enabled')
+
+    variant('asan', default=False, description="Use ASAN.")
+    variant('debug', default=False, description="Enable debug features.")
+    variant('googletest', default=False, description="Use Google Test as prerequisite.")
+    variant('native', default=True, description="Use native flags.")
+    variant('nospblas', default=False, description="Disable Building The Sparse BLAS API.")
+    variant('serial', default=False, description="Disable OpenMP support.")
+    variant('verbose', default=False, description="Extra Library Verbosity. Good for learning.")
+
+    def setup_build_environment(self, spack_env):
+        if '+asan' in self.spec:
+            spack_env.set('LSAN_OPTIONS', 'verbosity=1:log_threads=1')
+            spack_env.set('ASAN_OPTS', 'detect_leaks=0')
 
     def configure_args(self):
         args = [
@@ -30,8 +47,27 @@ class Librsb(AutotoolsPackage):
             '--with-zlib',
             '--enable-fortran-module-install',
             'CPPFLAGS={0}'.format(self.spec['zlib'].headers.include_flags),
-            'CFLAGS=-O3',
-            'CXXFLAGS=-O3',
             'LDFLAGS={0}'.format(self.spec['zlib'].libs.search_flags)
         ]
+        if '+asan' in self.spec:
+            args.append('CFLAGS=-O0 -ggdb -fsanitize=address -fno-omit-frame-pointer')
+            args.append('CXXFLAGS=-O0 -ggdb -fsanitize=address -fno-omit-frame-pointer')
+            args.append('LIBS=-lasan')
+            args.append('FCLIBS=-lasan')
+            args.append('--disable-shared')
+            args.append('--enable-fortran-linker')
+        if '+debug' in self.spec:
+            args.append('--enable-allocator-wrapper')
+            args.append('--enable-debug')
+        if '+native' in self.spec:
+            args.append('CFLAGS=-O3 -march=native')
+            args.append('CXXFLAGS=-O3 -march=native')
+            args.append('FCFLAGS=-O3 -march=native')
+        if '+nospblas' in self.spec:
+            args.append('--disable-sparse-blas-interface')
+        if '+serial' in self.spec:
+            args.append('--disable-openmp')
+        if '+verbose' in self.spec:
+            args.append('--enable-internals-error-verbosity=1')
+            args.append('--enable-interface-error-verbosity=1')
         return args