summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStephen Nicholas Swatman <stephen@v25.nl>2024-08-22 19:14:20 +0200
committerGitHub <noreply@github.com>2024-08-22 11:14:20 -0600
commitd5eefcba87927edededca767bc8550daa0343bb7 (patch)
tree8b4edb5d32c8e8076f862dfcb79733ca05f67ec4
parent1bcb1fcebc42d9de78e48a950950d08d75bb2646 (diff)
downloadspack-d5eefcba87927edededca767bc8550daa0343bb7.tar.gz
spack-d5eefcba87927edededca767bc8550daa0343bb7.tar.bz2
spack-d5eefcba87927edededca767bc8550daa0343bb7.tar.xz
spack-d5eefcba87927edededca767bc8550daa0343bb7.zip
llvm-amdgpu: Conflict with MacOS (#45633)
Currently, the llvm-amdgpu package doesn't compile on MacOS, but it is also not marked as a conflict. This causes problems because it seems that Spack is very happy to pull in llvm-amdgpu as the default package to satisfy any virtual libllvm dependency, which can cause dependent specs to fail to install on MacOS. This commit marks a conflict between this llvm package and the Darwin platform.
-rw-r--r--var/spack/repos/builtin/packages/llvm-amdgpu/package.py5
1 files changed, 5 insertions, 0 deletions
diff --git a/var/spack/repos/builtin/packages/llvm-amdgpu/package.py b/var/spack/repos/builtin/packages/llvm-amdgpu/package.py
index fd451f796c..0c9f5987a0 100644
--- a/var/spack/repos/builtin/packages/llvm-amdgpu/package.py
+++ b/var/spack/repos/builtin/packages/llvm-amdgpu/package.py
@@ -75,6 +75,11 @@ class LlvmAmdgpu(CMakePackage, CompilerPackage):
depends_on("ncurses+termlib", type="link")
depends_on("pkgconfig", type="build")
+ # This flavour of LLVM doesn't work on MacOS, so we should ensure that it
+ # isn't used to satisfy any of the libllvm dependencies on the Darwin
+ # platform.
+ conflicts("platform=darwin")
+
# OpenMP clang toolchain looks for bitcode files in llvm/bin/../lib
# as per 5.2.0 llvm code. It used to be llvm/bin/../lib/libdevice.
# Below patch is to look in the old path.