summaryrefslogtreecommitdiff
path: root/LICENSE-APACHE
diff options
context:
space:
mode:
authorHarmen Stoppels <harmenstoppels@gmail.com>2023-04-28 15:24:24 +0200
committerGitHub <noreply@github.com>2023-04-28 13:24:24 +0000
commitc85877566f4793ae97848d9c23828d9fe8dd7edd (patch)
tree437e5abef365ffc364dd1457b50797f4d12e5076 /LICENSE-APACHE
parentfc201a2b7578e49078f066c7544c7b637309af38 (diff)
downloadspack-c85877566f4793ae97848d9c23828d9fe8dd7edd.tar.gz
spack-c85877566f4793ae97848d9c23828d9fe8dd7edd.tar.bz2
spack-c85877566f4793ae97848d9c23828d9fe8dd7edd.tar.xz
spack-c85877566f4793ae97848d9c23828d9fe8dd7edd.zip
Reduce the number of stat calls in "spack verify" (#37251)
Spack comes to a crawl post-install of nvhpc, which is partly thanks to this post install hook which has a lot of redundancy, and isn't correct. 1. There's no need to store "type" because that _is_ "mode". 2. There are more file types than "symlink", "dir", "file". 3. Don't checksum device type things 4. Don't run 3 stat calls (exists, stat, isdir/islink), but one lstat call 5. Don't read entire files into memory I also don't know why `spack.crypto` wasn't used for checksumming, but I guess it's too late for that now. Finally md5 would've been the faster algorithm, which would've been fine given that a non cryptographicall checksum was used anyways.
Diffstat (limited to 'LICENSE-APACHE')
0 files changed, 0 insertions, 0 deletions