diff options
author | becker33 <becker33@llnl.gov> | 2016-08-10 17:36:31 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-08-10 17:36:31 -0700 |
commit | f59653ac2c9b20ec5954d90fda019c7652644ac9 (patch) | |
tree | b0d6767d3a5c257ca2f75db31f81af84f4b082d9 /README.md | |
parent | 8061deb883c84016f282f7e388c3c019af86b4ca (diff) | |
parent | 84e331c58618f2c67da00cbc56f51c75bd61af91 (diff) | |
download | spack-f59653ac2c9b20ec5954d90fda019c7652644ac9.tar.gz spack-f59653ac2c9b20ec5954d90fda019c7652644ac9.tar.bz2 spack-f59653ac2c9b20ec5954d90fda019c7652644ac9.tar.xz spack-f59653ac2c9b20ec5954d90fda019c7652644ac9.zip |
Merge pull request #1496 from LLNL/features/pep8-compliance
PEP8 compliance
Diffstat (limited to 'README.md')
-rw-r--r-- | README.md | 21 |
1 files changed, 14 insertions, 7 deletions
@@ -58,17 +58,24 @@ can join it here: ### Contributions -At the moment, contributing to Spack is relatively simple. Just send us -a [pull request](https://help.github.com/articles/using-pull-requests/). +Contributing to Spack is relatively. Just send us a +[pull request](https://help.github.com/articles/using-pull-requests/). When you send your request, make ``develop`` the destination branch on the [Spack repository](https://github.com/LLNL/spack). -Your contribution will need to pass all the tests run by the `spack test` -command, as well as the formatting checks in `share/spack/qa/run-flake8`. -You should run both of these before submitting your pull request, to -ensure that the online checks succeed. +Before you send a PR, your code should pass the following checks: -Spack is using a rough approximation of the [Git +* Your contribution will need to pass the `spack test` command. + Run this before submitting your PR. + +* Also run the `share/spack/qa/run-flake8` script to check for PEP8 compliance. + To encourage contributions and readability by a broad audience, + Spack uses the [PEP8](https://www.python.org/dev/peps/pep-0008/) coding + standard with [a few exceptions](https://github.com/LLNL/spack/blob/develop/.flake8). + +We enforce these guidelines with [Travis CI](https://travis-ci.org/LLNL/spack). + +Spack uses a rough approximation of the [Git Flow](http://nvie.com/posts/a-successful-git-branching-model/) branching model. The ``develop`` branch contains the latest contributions, and ``master`` is always tagged and points to the |