diff options
| author | Kelly (KT) Thompson <KineticTheory@users.noreply.github.com> | 2018-01-05 12:45:21 -0700 |
|---|---|---|
| committer | Adam J. Stewart <ajstewart426@gmail.com> | 2018-01-05 13:45:21 -0600 |
| commit | 322b016230629c2e97f7d3457f72b13ad3e885b3 (patch) | |
| tree | 041f20ee5edd7e3712440d66bcad358fc2345d31 /issue_template.md | |
| parent | d4e4755ec9792d409e2df3dfd6ee92cd106e3e31 (diff) | |
| download | spack-322b016230629c2e97f7d3457f72b13ad3e885b3.tar.gz spack-322b016230629c2e97f7d3457f72b13ad3e885b3.tar.bz2 spack-322b016230629c2e97f7d3457f72b13ad3e885b3.tar.xz spack-322b016230629c2e97f7d3457f72b13ad3e885b3.zip | |
Provide build_type variant for Metis. (#6808)
* Provide build_type variant for Metis.
+ Ideally, we would make Metis a CMakePackage, but `metis@:5` doesn't use CMake.
+ For now, provide a `build_type=` variant similar what is found in
CMakePackage.
+ There is a potential for duplicate specification of `CMAKE_BUILD_TYPE` if both
variants `+debug` and `build_type=` are specified. I am looking for advice on
how this can be resolved.
* Update metis recipe in response to flake8 and user comments.
+ Wrap comment lines that used more than 80 columns.
+ Change `+debug` variant to avoid potential for multiple `-DCMAKE_BUID_TYPE=`
arguments provided to cmake. Specifying this variant no longer appends this
configure option. However, if `+debug` is specified, require
`build_type=Debug` to maintain expected behavior.
* For metis, remove +debug variant; use build_type= instead.
+ Update recipe for metis@4 to extract `build_type=` values and set `OPTFLAGS`
accordingly.
+ For metis@5:, the behavior from the previously supported variant `+debug` can
be obtained with the options `+gdb build_type=Debug`
* Conflicts added for metis@4 when build_type != Release|Debug.
* Use spack function conflicts instead of 'raise InstallError'.
Diffstat (limited to 'issue_template.md')
0 files changed, 0 insertions, 0 deletions