diff options
| author | Tom Scogland <scogland1@llnl.gov> | 2022-09-02 14:09:23 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-02 14:09:23 -0700 |
| commit | 69f7a8f4d142cf5b7142bf8f20925b214e56316a (patch) | |
| tree | 32b2c22f0b6ada94fd0047be4278f79465d7b8b3 /lib | |
| parent | 80389911cce2daae5b0e4df069a3be9575954dc3 (diff) | |
| download | spack-69f7a8f4d142cf5b7142bf8f20925b214e56316a.tar.gz spack-69f7a8f4d142cf5b7142bf8f20925b214e56316a.tar.bz2 spack-69f7a8f4d142cf5b7142bf8f20925b214e56316a.tar.xz spack-69f7a8f4d142cf5b7142bf8f20925b214e56316a.zip | |
Reorder workflow execution in GHA (#32183)
This patchset refactors our GitHub actions into a single top-level ci workflow that
invokes a series of reusable actions. The main goal of this is to be able to easily
control which tests run and in what order based on the success or failure of top-level
prechecks. Our previous workflows ran in three sets:
* nix tests: style and verification first, then linux and macos tests if successful
* windows tests: style and verification first, then linux and macos tests if successful
* bootstrap tests
As a result, the bootstrap tests ran even if the style failed, and style and verification
had to run on two different platforms despite running identical checks. I'm relatively
sure that's because of the limitation on dependencies between steps in the jobs.
Reusable workflows allow us to run the style, verification and now audit checks once,
then depending on the results, and the files changed, run the appropriate nix, windows
and bootstrap tests. While it saves only a few minutes by itself, this makes it easier to
refactor checks to subset tests without having to replicate tests or other workflow
components in the future.
Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/spack/spack/test/cmd/env.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/spack/spack/test/cmd/env.py b/lib/spack/spack/test/cmd/env.py index e465060392..ceefd3323b 100644 --- a/lib/spack/spack/test/cmd/env.py +++ b/lib/spack/spack/test/cmd/env.py @@ -788,7 +788,7 @@ def test_env_with_included_config_file(packages_file): e = ev.read("test") included_path = os.path.join(e.path, include_filename) - fs.rename(packages_file.strpath, included_path) + shutil.move(packages_file.strpath, included_path) with e: e.concretize() |