summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorAdam J. Stewart <ajstewart426@gmail.com>2021-06-29 18:49:18 -0500
committerGitHub <noreply@github.com>2021-06-29 23:49:18 +0000
commita2b7f9997d96624e85c5db285592ac0c20f6ec9e (patch)
treeea55dd797e65a93ececffda5759666e211e2dbc5 /lib
parent1c6504d2f58ec05660b2498ef5dc67710e2cf18d (diff)
downloadspack-a2b7f9997d96624e85c5db285592ac0c20f6ec9e.tar.gz
spack-a2b7f9997d96624e85c5db285592ac0c20f6ec9e.tar.bz2
spack-a2b7f9997d96624e85c5db285592ac0c20f6ec9e.tar.xz
spack-a2b7f9997d96624e85c5db285592ac0c20f6ec9e.zip
spack style: warn if flake8-import-order is missing (#24590)
Diffstat (limited to 'lib')
-rw-r--r--lib/spack/spack/cmd/style.py11
1 files changed, 7 insertions, 4 deletions
diff --git a/lib/spack/spack/cmd/style.py b/lib/spack/spack/cmd/style.py
index 899ba5b6d7..43c8b52d3b 100644
--- a/lib/spack/spack/cmd/style.py
+++ b/lib/spack/spack/cmd/style.py
@@ -5,15 +5,14 @@
from __future__ import print_function
-import re
+import argparse
import os
+import re
import sys
-import argparse
-from llnl.util.filesystem import working_dir
import llnl.util.tty as tty
-
import spack.paths
+from llnl.util.filesystem import working_dir
from spack.util.executable import which
if sys.version_info < (3, 0):
@@ -206,6 +205,10 @@ def run_flake8(file_list, args):
print_tool_header("flake8")
flake8_cmd = which("flake8", required=True)
+ # Check if plugins are installed
+ if "import-order" not in flake8_cmd("--version", output=str, error=str):
+ tty.warn("style: flake8-import-order plugin is not installed, skipping")
+
output = ""
# run in chunks of 100 at a time to avoid line length limit
# filename parameter in config *does not work* for this reliably