diff options
| author | Massimiliano Culpo <massimiliano.culpo@gmail.com> | 2024-08-11 01:12:27 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-10 16:12:27 -0700 |
| commit | 2079b888c8b14a72bd1558af532f1befd32bcc7c (patch) | |
| tree | f9f66fcc0b11b3a936d5dd505dc08714d74e4946 /pytest.ini | |
| parent | 2dbc5213b02c3c5f2e021a0493e8cf593e7082e3 (diff) | |
| download | spack-2079b888c8b14a72bd1558af532f1befd32bcc7c.tar.gz spack-2079b888c8b14a72bd1558af532f1befd32bcc7c.tar.bz2 spack-2079b888c8b14a72bd1558af532f1befd32bcc7c.tar.xz spack-2079b888c8b14a72bd1558af532f1befd32bcc7c.zip | |
Remove the old concretizer (#45215)
The old concretizer is still used to bootstrap clingo from source. If we switch to a DAG model
where compilers are treated as nodes, we need to either:
1. fix the old concretizer to support this (which is a lot of work and possibly research), or
2. bootstrap `clingo` without the old concretizer.
This PR takes the second approach and gets rid of the old concretizer code. To bootstrap
`clingo`, we store some concrete spec prototypes as JSON, select one according to the
coarse-grained system architecture, and tweak them according to the current host.
The old concretizer and related dead code are removed. In particular, this removes
`Spec.normalize()` and related methods, which were used in many unit-tests to set
up the test context. The tests have been updated not to use `normalize()`.
- [x] Bootstrap clingo concretization based on a JSON file
- [x] Bootstrap clingo *before* patchelf
- [x] Remove any use of the old concretizer, including:
* Remove only_clingo and only_original fixtures
* Remove _old_concretize and _new_concretize
* Remove _concretize_together_old
* Remove _concretize_together_new
* Remove any use of `SPACK_TEST_SOLVER`
* Simplify CI jobs
- [x] ensure bootstrapping `clingo` works on on Darwin and Windows
- [x] Raise an intelligible error when a compiler is missing
- [x] Ensure bootstrapping works on FreeBSD
- [x] remove normalize and related methods
Signed-off-by: Todd Gamblin <tgamblin@llnl.gov>
Diffstat (limited to 'pytest.ini')
| -rw-r--r-- | pytest.ini | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/pytest.ini b/pytest.ini index 2a3152da3d..8465cb8085 100644 --- a/pytest.ini +++ b/pytest.ini @@ -14,6 +14,4 @@ markers = enable_compiler_verification: enable compiler verification within unit tests enable_compiler_execution: enable compiler execution to detect link paths and libc disable_clean_stage_check: avoid failing tests if there are leftover files in the stage area - only_clingo: mark unit tests that run only with clingo - only_original: mark unit tests that are specific to the original concretizer not_on_windows: mark tests that are skipped on Windows |